improvement(db): keep declarations, route reads through live-column maps

Restructures the contract prep per review: the no-op 0309 migration is
gone and schema.ts keeps the deprecated declarations (with the
contract-pending markers on the columns), so the follow-up PR ships the
declaration removal and the real generated DROP migration together. What
makes that safe is that no deployed query names the doomed columns
anymore: every argless select()/returning()/relational read of
user_stats, organization, and workflow_execution_logs (29 sites) now
goes through omit(getTableColumns(...)) live-column maps, following the
workspaceFileColumns precedent. scripts/check-pending-drop-tables.ts
enforces this — it derives the guarded tables from the contract-pending
markers themselves (picking up workspace_files' pending size drop too)
and fails CI on any argless read, so the invariant holds between the two
PRs and retires itself when the markers are deleted.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

Author: icecrasher321

apps/sim/app/api/organizations/[id]/route.ts

@@ -1,6 +1,6 @@
 import { AuditAction, AuditResourceType, recordAudit } from '@sim/audit'
 import { db } from '@sim/db'
-import { member, organization } from '@sim/db/schema'
+import { member, organization, organizationColumns } from '@sim/db/schema'
 import { createLogger } from '@sim/logger'
 import { isOrgAdminRole } from '@sim/platform-authz/workspace'
 import { and, eq, ne } from 'drizzle-orm'
@@ -64,7 +64,7 @@ export const GET = withRouteHandler(
       }
 
       const organizationEntry = await db
-        .select()
+        .select(organizationColumns)
         .from(organization)
         .where(eq(organization.id, organizationId))
         .limit(1)
@@ -156,7 +156,7 @@ export const PUT = withRouteHandler(
       if (name !== undefined || slug !== undefined || logo !== undefined) {
         if (slug !== undefined) {
           const existingSlug = await db
-            .select()
+            .select(organizationColumns)
             .from(organization)
             .where(and(eq(organization.slug, slug), ne(organization.id, organizationId)))
             .limit(1)
@@ -180,7 +180,7 @@ export const PUT = withRouteHandler(
           .update(organization)
           .set(updateData)
           .where(eq(organization.id, organizationId))
-          .returning()
+          .returning(organizationColumns)
 
         if (updatedOrg.length === 0) {
           return NextResponse.json({ error: 'Organization not found' }, { status: 404 })

apps/sim/app/api/v1/admin/organizations/[id]/billing/route.ts

@@ -16,7 +16,7 @@
  */
 
 import { db, dbReplica } from '@sim/db'
-import { member, organization } from '@sim/db/schema'
+import { member, organization, organizationColumns } from '@sim/db/schema'
 import { createLogger } from '@sim/logger'
 import { count, eq } from 'drizzle-orm'
 import {
@@ -155,7 +155,7 @@ export const PATCH = withRouteHandler(
       if (!parsed.success) return parsed.response
 
       const [orgData] = await db
-        .select()
+        .select(organizationColumns)
         .from(organization)
         .where(eq(organization.id, organizationId))
         .limit(1)

apps/sim/app/api/v1/admin/organizations/[id]/route.ts

@@ -38,7 +38,7 @@ import {
   recordAuditBatch,
 } from '@sim/audit'
 import { db } from '@sim/db'
-import { member, organization, subscription } from '@sim/db/schema'
+import { member, organization, organizationColumns, subscription } from '@sim/db/schema'
 import { createLogger } from '@sim/logger'
 import { and, count, eq, inArray, isNull, not, or } from 'drizzle-orm'
 import {
@@ -92,7 +92,7 @@ export const GET = withRouteHandler(
 
     try {
       const [orgData] = await db
-        .select()
+        .select(organizationColumns)
         .from(organization)
         .where(eq(organization.id, organizationId))
         .limit(1)
@@ -143,7 +143,7 @@ export const PATCH = withRouteHandler(
 
     try {
       const [existing] = await db
-        .select()
+        .select(organizationColumns)
         .from(organization)
         .where(eq(organization.id, organizationId))
         .limit(1)
@@ -182,7 +182,7 @@ export const PATCH = withRouteHandler(
         .update(organization)
         .set(updateData)
         .where(eq(organization.id, organizationId))
-        .returning()
+        .returning(organizationColumns)
 
       const updatedFields = auditUpdatedFields(updateData)
       logger.info(`Admin API: Updated organization ${organizationId}`, { updatedFields })

apps/sim/app/api/v1/admin/organizations/route.ts

@@ -23,7 +23,7 @@
 
 import { AuditAction, AuditResourceType, recordAudit } from '@sim/audit'
 import { db, dbReplica } from '@sim/db'
-import { member, organization, user } from '@sim/db/schema'
+import { member, organization, organizationColumns, user } from '@sim/db/schema'
 import { createLogger } from '@sim/logger'
 import { slugify } from '@sim/utils/string'
 import { count, eq } from 'drizzle-orm'
@@ -151,7 +151,7 @@ export const POST = withRouteHandler(
       })
 
       const [createdOrg] = await db
-        .select()
+        .select(organizationColumns)
         .from(organization)
         .where(eq(organization.id, organizationId))
         .limit(1)

apps/sim/app/api/v1/admin/users/[id]/billing/route.ts

@@ -20,7 +20,14 @@
  */
 
 import { db } from '@sim/db'
-import { member, organization, subscription, user, userStats } from '@sim/db/schema'
+import {
+  member,
+  organization,
+  subscription,
+  user,
+  userStats,
+  userStatsColumns,
+} from '@sim/db/schema'
 import { createLogger } from '@sim/logger'
 import { generateShortId } from '@sim/utils/id'
 import { eq, or } from 'drizzle-orm'
@@ -78,7 +85,11 @@ export const GET = withRouteHandler(
         return notFoundResponse('User')
       }
 
-      const [stats] = await db.select().from(userStats).where(eq(userStats.userId, userId)).limit(1)
+      const [stats] = await db
+        .select(userStatsColumns)
+        .from(userStats)
+        .where(eq(userStats.userId, userId))
+        .limit(1)
 
       // Canonical current-period usage (attributed usage_log, refresh-adjusted)
       // comes from the same helper users see.
@@ -168,7 +179,7 @@ export const PATCH = withRouteHandler(
       }
 
       const [existingStats] = await db
-        .select()
+        .select(userStatsColumns)
         .from(userStats)
         .where(eq(userStats.userId, userId))
         .limit(1)

apps/sim/lib/admin/dashboard.ts

@@ -3,6 +3,7 @@ import { db } from '@sim/db'
 import {
   member,
   organization,
+  organizationColumns,
   organizationMemberUsageLimit,
   outboxEvent,
   permissions,
@@ -651,7 +652,11 @@ export async function listDashboardUsers({ search, limit, offset }: PaginationIn
 async function getDashboardOrganizationSummary(organizationId: string) {
   const [[org], [memberCountRow], [externalCountRow], latestSubscription, provisionings] =
     await Promise.all([
-      db.select().from(organization).where(eq(organization.id, organizationId)).limit(1),
+      db
+        .select(organizationColumns)
+        .from(organization)
+        .where(eq(organization.id, organizationId))
+        .limit(1),
       db.select({ value: count() }).from(member).where(eq(member.organizationId, organizationId)),
       db
         .select({ value: countDistinct(permissions.userId) })
@@ -1277,7 +1282,7 @@ export async function updateDashboardOrganizationLimits(
   const providerBacked = await db.transaction(async (tx) => {
     await acquireOrganizationMutationLock(tx, organizationId)
     const [org] = await tx
-      .select()
+      .select(organizationColumns)
       .from(organization)
       .where(eq(organization.id, organizationId))
       .for('update')
@@ -1411,7 +1416,7 @@ export async function grantDashboardOrganizationBalance(
       }),
       operation: async () => {
         const [org] = await tx
-          .select()
+          .select(organizationColumns)
           .from(organization)
           .where(eq(organization.id, organizationId))
           .for('update')

apps/sim/lib/auth/anonymous.ts

@@ -32,6 +32,7 @@ export async function ensureAnonymousUserExists(): Promise<void> {
     }
 
     const existingStats = await db.query.userStats.findFirst({
+      columns: { id: true },
       where: eq(schema.userStats.userId, ANONYMOUS_USER_ID),
     })
 

apps/sim/lib/billing/core/organization.ts

@@ -1,5 +1,12 @@
 import { db } from '@sim/db'
-import { member, organization, usageLog, user, userStats } from '@sim/db/schema'
+import {
+  member,
+  organization,
+  organizationColumns,
+  usageLog,
+  user,
+  userStats,
+} from '@sim/db/schema'
 import { createLogger } from '@sim/logger'
 import { and, count, eq, gte, lt, sql } from 'drizzle-orm'
 import { isOrganizationBillingBlocked } from '@/lib/billing/core/access'
@@ -189,7 +196,7 @@ export async function getOrganizationBillingData(
   try {
     // Get organization info
     const orgRecord = await executor
-      .select()
+      .select(organizationColumns)
       .from(organization)
       .where(eq(organization.id, organizationId))
       .limit(1)
@@ -368,7 +375,7 @@ export async function updateOrganizationUsageLimit(
   try {
     // Validate the organization exists
     const orgRecord = await db
-      .select()
+      .select(organizationColumns)
       .from(organization)
       .where(eq(organization.id, organizationId))
       .limit(1)

apps/sim/lib/billing/core/usage.ts

@@ -1,5 +1,5 @@
 import { db } from '@sim/db'
-import { member, organization, settings, user, userStats } from '@sim/db/schema'
+import { member, organization, settings, user, userStats, userStatsColumns } from '@sim/db/schema'
 import { createLogger } from '@sim/logger'
 import { isOrgAdminRole } from '@sim/platform-authz/workspace'
 import { generateId } from '@sim/utils/id'
@@ -207,7 +207,7 @@ export async function getResolvedUserUsageData(
       // inserted, which a lagging replica can miss (this path throws on a
       // missing row). Stays on the primary deliberately.
       db
-        .select()
+        .select(userStatsColumns)
         .from(userStats)
         .where(eq(userStats.userId, userId))
         .limit(1),
@@ -324,7 +324,7 @@ export async function getUserUsageLimitInfo(userId: string): Promise<UsageLimitI
   try {
     const [subscription, userStatsRecord] = await Promise.all([
       getHighestPrioritySubscription(userId),
-      db.select().from(userStats).where(eq(userStats.userId, userId)).limit(1),
+      db.select(userStatsColumns).from(userStats).where(eq(userStats.userId, userId)).limit(1),
     ])
 
     if (userStatsRecord.length === 0) {
@@ -576,7 +576,7 @@ export async function checkUsageStatus(userId: string): Promise<{
 export async function syncUsageLimitsFromSubscription(userId: string): Promise<void> {
   const [subscription, currentUserStats] = await Promise.all([
     getHighestPrioritySubscription(userId),
-    db.select().from(userStats).where(eq(userStats.userId, userId)).limit(1),
+    db.select(userStatsColumns).from(userStats).where(eq(userStats.userId, userId)).limit(1),
   ])
 
   if (currentUserStats.length === 0) {

apps/sim/lib/billing/threshold-billing.ts

@@ -1,6 +1,13 @@
 import { AuditAction, AuditResourceType, recordAudit } from '@sim/audit'
 import { db } from '@sim/db'
-import { member, organization, subscription, userStats } from '@sim/db/schema'
+import {
+  member,
+  organization,
+  organizationColumns,
+  subscription,
+  userStats,
+  userStatsColumns,
+} from '@sim/db/schema'
 import { createLogger } from '@sim/logger'
 import { toError } from '@sim/utils/errors'
 import { and, eq, sql } from 'drizzle-orm'
@@ -342,7 +349,7 @@ export async function checkAndBillOverageThreshold(
         await tx.execute(sql.raw(`SET LOCAL lock_timeout = '${BILLING_LOCK_TIMEOUT_MS}ms'`))
 
         const statsRecords = await tx
-          .select()
+          .select(userStatsColumns)
           .from(userStats)
           .where(eq(userStats.userId, userId))
           .for('update')
@@ -697,7 +704,7 @@ async function checkAndBillOrganizationOverageThreshold(
         }
 
         const ownerStatsLock = await tx
-          .select()
+          .select(userStatsColumns)
           .from(userStats)
           .where(eq(userStats.userId, lockedOwnerId))
           .for('update')
@@ -724,7 +731,7 @@ async function checkAndBillOrganizationOverageThreshold(
         }
 
         const orgLock = await tx
-          .select()
+          .select(organizationColumns)
           .from(organization)
           .where(eq(organization.id, organizationId))
           .for('update')