Commit 1be2336
committed
fix(helm): make lint:helm run
Unrelated to the egress work, but broken in a way worth a one-line fix while the
chart is already in the diff.
`lint:helm` pointed at `helm/sim/test/values-lint.yaml`, which has never existed
in this repository — the script has been dead since the chart landed in #813.
Nobody hit it because CI lints the chart directly rather than through the script.
The reason it was never noticed is the other half: `.gitignore` ignored
`helm/sim/test`, so whoever wrote the script had that file locally and it worked
only on their machine. That entry is removed too. It was also a trap, sitting one
letter away from `helm/sim/tests`, the real committed helm-unittest directory —
anyone who created the singular path would have had it silently ignored.
The script now runs exactly what the workflow runs, so a developer checking
locally gets the same answer as the gate. `--strict` is dropped for the same
reason: a local check stricter than CI reports failures the gate will not.1 parent 606ea07 commit 1be2336
2 files changed
Lines changed: 1 addition & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
84 | 84 | | |
85 | 85 | | |
86 | 86 | | |
87 | | - | |
88 | | - | |
89 | | - | |
90 | 87 | | |
91 | 88 | | |
92 | 89 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
27 | 27 | | |
28 | 28 | | |
29 | 29 | | |
30 | | - | |
| 30 | + | |
31 | 31 | | |
32 | 32 | | |
33 | 33 | | |
| |||
0 commit comments