Commit 13259cb
committed
fix(ee): case-fold the stored integration allowlist
ee/access-control re-implemented the allowlist intersection instead of calling
intersectIntegrationAllowlists, and lost the case-folding: normalization only
happened on the envAllowlist !== null branch, so with ALLOWED_INTEGRATIONS
unset a stored config went through untouched. Callers compare against
blockType.toLowerCase(), so a stored 'Slack' failed to match 'slack' and the
block was denied.
The access-control UI writes block.type directly and block types are lowercase,
so this is not reachable from the UI — but allowedIntegrations is a bare
z.array(z.string()) on the wire, so any API client can store mixed case.
Replaces the fork with the shared helper. Adds two tests; the first fails
against the old code.1 parent 87ed366 commit 13259cb
2 files changed
Lines changed: 26 additions & 18 deletions
Lines changed: 14 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
446 | 446 | | |
447 | 447 | | |
448 | 448 | | |
| 449 | + | |
| 450 | + | |
| 451 | + | |
| 452 | + | |
| 453 | + | |
| 454 | + | |
| 455 | + | |
| 456 | + | |
| 457 | + | |
| 458 | + | |
| 459 | + | |
| 460 | + | |
| 461 | + | |
| 462 | + | |
449 | 463 | | |
450 | 464 | | |
451 | 465 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
12 | 12 | | |
13 | 13 | | |
14 | 14 | | |
| 15 | + | |
15 | 16 | | |
16 | 17 | | |
17 | 18 | | |
| |||
108 | 109 | | |
109 | 110 | | |
110 | 111 | | |
111 | | - | |
112 | | - | |
113 | | - | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
114 | 118 | | |
115 | 119 | | |
116 | 120 | | |
| 121 | + | |
117 | 122 | | |
118 | | - | |
119 | | - | |
120 | | - | |
121 | | - | |
122 | | - | |
123 | | - | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
124 | 127 | | |
125 | | - | |
126 | | - | |
127 | | - | |
128 | | - | |
129 | | - | |
130 | | - | |
131 | | - | |
132 | | - | |
133 | | - | |
134 | 128 | | |
135 | 129 | | |
136 | 130 | | |
| |||
0 commit comments