acked PR comments

Author: waleedlatif1

apps/sim/lib/execution/isolated-vm-worker.cjs

@@ -143,7 +143,13 @@ async function executeCode(request) {
           }
         }, FETCH_TIMEOUT_MS)
         pendingFetches.set(fetchId, { resolve, timeout })
-        process.send({ type: 'fetch', fetchId, requestId, url, optionsJson })
+        if (process.send && process.connected) {
+          process.send({ type: 'fetch', fetchId, requestId, url, optionsJson })
+        } else {
+          clearTimeout(timeout)
+          pendingFetches.delete(fetchId)
+          resolve(JSON.stringify({ error: 'Parent process disconnected' }))
+        }
       })
     })
     await jail.set('__fetchRef', fetchCallback)
@@ -314,17 +320,38 @@ async function executeCode(request) {
 }
 
 process.on('message', async (msg) => {
-  if (msg.type === 'execute') {
-    const result = await executeCode(msg.request)
-    process.send({ type: 'result', executionId: msg.executionId, result })
-  } else if (msg.type === 'fetchResponse') {
-    const pending = pendingFetches.get(msg.fetchId)
-    if (pending) {
-      clearTimeout(pending.timeout)
-      pendingFetches.delete(msg.fetchId)
-      pending.resolve(msg.response)
+  try {
+    if (msg.type === 'execute') {
+      const result = await executeCode(msg.request)
+      if (process.send && process.connected) {
+        process.send({ type: 'result', executionId: msg.executionId, result })
+      }
+    } else if (msg.type === 'fetchResponse') {
+      const pending = pendingFetches.get(msg.fetchId)
+      if (pending) {
+        clearTimeout(pending.timeout)
+        pendingFetches.delete(msg.fetchId)
+        pending.resolve(msg.response)
+      }
+    }
+  } catch (err) {
+    if (msg.type === 'execute' && process.send && process.connected) {
+      process.send({
+        type: 'result',
+        executionId: msg.executionId,
+        result: {
+          result: null,
+          stdout: '',
+          error: {
+            message: err instanceof Error ? err.message : 'Worker error',
+            name: 'WorkerError',
+          },
+        },
+      })
     }
   }
 })
 
-process.send({ type: 'ready' })
+if (process.send) {
+  process.send({ type: 'ready' })
+}

apps/sim/lib/execution/isolated-vm.ts

@@ -1,6 +1,7 @@
 import { type ChildProcess, spawn } from 'node:child_process'
 import fs from 'node:fs'
 import path from 'node:path'
+import { fileURLToPath } from 'node:url'
 import { validateProxyUrl } from '@/lib/core/security/input-validation'
 import { createLogger } from '@/lib/logs/console/logger'
 
@@ -140,14 +141,24 @@ function handleWorkerMessage(message: unknown) {
     }
     secureFetch(requestId, url, options)
       .then((response) => {
-        worker?.send({ type: 'fetchResponse', fetchId, response })
+        try {
+          worker?.send({ type: 'fetchResponse', fetchId, response })
+        } catch (err) {
+          logger.error('Failed to send fetch response to worker', { err, fetchId })
+        }
       })
       .catch((err) => {
-        worker?.send({
-          type: 'fetchResponse',
-          fetchId,
-          response: JSON.stringify({ error: err instanceof Error ? err.message : 'Fetch failed' }),
-        })
+        try {
+          worker?.send({
+            type: 'fetchResponse',
+            fetchId,
+            response: JSON.stringify({
+              error: err instanceof Error ? err.message : 'Fetch failed',
+            }),
+          })
+        } catch (sendErr) {
+          logger.error('Failed to send fetch error to worker', { sendErr, fetchId })
+        }
       })
   }
 }
@@ -160,21 +171,11 @@ async function ensureWorker(): Promise<void> {
   if (workerReadyPromise) return workerReadyPromise
 
   workerReadyPromise = new Promise<void>((resolve, reject) => {
-    const workerPath = path.resolve(
-      process.cwd(),
-      'apps',
-      'sim',
-      'lib',
-      'execution',
-      'isolated-vm-worker.cjs'
-    )
+    const currentDir = path.dirname(fileURLToPath(import.meta.url))
+    const workerPath = path.join(currentDir, 'isolated-vm-worker.cjs')
 
     if (!fs.existsSync(workerPath)) {
-      reject(
-        new Error(
-          `Worker file not found at ${workerPath}. Ensure the file exists and process.cwd() (${process.cwd()}) is correct.`
-        )
-      )
+      reject(new Error(`Worker file not found at ${workerPath}`))
       return
     }