test(analytics): make posthog client tests order-independent

Readiness is module-level and settles once, so the capture and exception
cases silently depended on an earlier case having settled the gate and
failed when run in isolation. Walk the lifecycle in one case instead.

Moves the disabled-analytics case to its own file, where vitest's per-file
isolation supplies an unsettled gate — dropping the vi.resetModules() and
dynamic import the repo's testing conventions rule out. Replaces the
hand-rolled setTimeout flush with vi.waitFor.

Author: icecrasher321

apps/sim/lib/posthog/client-disabled.test.ts

@@ -0,0 +1,27 @@
+/**
+ * @vitest-environment node
+ */
+import { describe, expect, it } from 'vitest'
+import {
+  captureClientEvent,
+  captureClientException,
+  settlePostHogClient,
+} from '@/lib/posthog/client'
+
+/**
+ * Lives in its own file because readiness is module-level and settles once.
+ * Vitest isolates the module registry per file, so this gets an unsettled gate
+ * to settle with `null` without `vi.resetModules()` and a dynamic import.
+ */
+describe('client capture when analytics is disabled', () => {
+  it('drops events instead of sending them, without throwing', async () => {
+    settlePostHogClient(null)
+
+    expect(() => captureClientEvent('login_page_viewed', {})).not.toThrow()
+    expect(() => captureClientException(new Error('boom'))).not.toThrow()
+
+    // Lets the gate's continuations run; a missing catch would surface here as
+    // an unhandled rejection and fail the test.
+    await Promise.resolve()
+  })
+})

apps/sim/lib/posthog/client.test.ts

@@ -2,7 +2,7 @@
  * @vitest-environment node
  */
 import type { PostHog } from 'posthog-js'
-import { beforeEach, describe, expect, it, vi } from 'vitest'
+import { describe, expect, it, vi } from 'vitest'
 import {
   captureClientEvent,
   captureClientException,
@@ -21,56 +21,33 @@ function createFakePostHog() {
   } as unknown as PostHog
 }
 
-/** Lets the readiness promise and its continuations settle. */
-const flush = () => new Promise<void>((resolve) => setTimeout(resolve, 0))
+describe('client capture', () => {
+  /**
+   * Readiness is module-level and settles exactly once, so the whole lifecycle
+   * runs as a single case. Split across separate cases, each one after the
+   * first would silently depend on an earlier case having settled the gate, and
+   * would fail when run in isolation or reordered.
+   */
+  it('holds events until PostHog initializes, then sends them and everything after', async () => {
+    const posthog = createFakePostHog()
 
-describe('captureClientEvent', () => {
-  const posthog = createFakePostHog()
-
-  beforeEach(() => {
-    vi.clearAllMocks()
-  })
-
-  it('holds an event captured before PostHog initializes, then sends it', async () => {
     captureClientEvent('login_page_viewed', {})
-    await flush()
+    await Promise.resolve()
 
     expect(posthog.capture).not.toHaveBeenCalled()
 
     settlePostHogClient(posthog)
-    await flush()
+    await vi.waitFor(() => expect(posthog.capture).toHaveBeenCalledWith('login_page_viewed', {}))
 
-    expect(posthog.capture).toHaveBeenCalledWith('login_page_viewed', {})
-  })
-
-  it('sends events captured after initialization', async () => {
     captureClientEvent('signup_page_viewed', {})
-    await flush()
-
-    expect(posthog.capture).toHaveBeenCalledWith('signup_page_viewed', {})
-  })
+    await vi.waitFor(() => expect(posthog.capture).toHaveBeenCalledWith('signup_page_viewed', {}))
 
-  it('reports a caught error through captureException so error tracking sees it', async () => {
     const error = new Error('canvas exploded')
-
     captureClientException(error, { error_boundary: 'workflow_canvas' })
-    await flush()
-
-    expect(posthog.captureException).toHaveBeenCalledWith(error, {
-      error_boundary: 'workflow_canvas',
-    })
-  })
-})
-
-describe('captureClientEvent when analytics is disabled', () => {
-  it('drops events without throwing once the provider settles with null', async () => {
-    vi.resetModules()
-    const client = await import('@/lib/posthog/client')
-
-    client.captureClientEvent('login_page_viewed', {})
-    client.captureClientException(new Error('boom'))
-    client.settlePostHogClient(null)
-
-    await expect(flush()).resolves.toBeUndefined()
+    await vi.waitFor(() =>
+      expect(posthog.captureException).toHaveBeenCalledWith(error, {
+        error_boundary: 'workflow_canvas',
+      })
+    )
   })
 })