fix(lambda): stop rejecting values AWS documents as valid

A comprehensive validation pass against the API reference found the previous
commit's blanket "no empty optional strings" rule was wrong. Several Lambda
parameters document an empty string as meaningful, and their patterns say so:
KMSKeyArn, SourceKMSKeyArn, and DeadLetterConfig.TargetArn all carry
`(arn:...)|()`, whose trailing alternative matches the empty string, and the
on-success/on-failure destinations document `Minimum length of 0` with a
pattern beginning `$|`. For each, empty is how the setting is cleared.

The rule is now opt-in rather than opt-out: only the five fields feeding a
truthiness-based cross-field check reject an empty value. That removes 47
constraints and leaves the ones that were actually reported.

Also from the same pass:

- Supplying an image URI no longer demands an explicit `packageType`. That
  subBlock is advanced with no default, so requiring it produced a 400 naming
  a control the user cannot see; the operation derives Image from the code
  source instead, and only an explicit Zip alongside an image is rejected.
- `fileSystemConfigs` was the one projection without a null guard, so an
  omitted field vanished from the block output rather than reading null.
- An absent function URL now maps to null instead of an empty string a
  workflow could build a request against.
- GetFunction reports `tagsError`, so a partial tag-read failure is
  distinguishable from a function with no tags, and marks `configuration`
  nullable to match what the operation returns.
- Event source mappings report `selfManagedKafkaBootstrapServers`, which
  could be set but never read back.
- TagResource rejects an empty tag map instead of reporting "0 tags applied".

Author: waleedlatif1

apps/docs/content/docs/en/integrations/lambda.mdx

@@ -115,6 +115,7 @@ Get a function's configuration, code location, tags, and reserved concurrency
 | Parameter | Type | Description |
 | --------- | ---- | ----------- |
 | `configuration` | json | The function's configuration \(ARN, runtime, handler, memory, state, layers, VPC, and logging settings\) |
+| `tagsError` | json | Why the tags could not be read, when a partial tag-read failure occurred |
 | `code` | json | Presigned download URL for the deployment package, or the container image URI |
 | `tags` | json | The function's tags |
 | `reservedConcurrentExecutions` | number | Concurrency reserved for this function, if any |

apps/sim/lib/api/contracts/tools/aws/lambda-add-permission.ts

@@ -29,17 +29,17 @@ const AddPermissionSchema = z.object({
       'action must be a Lambda action such as lambda:InvokeFunction'
     ),
   principal: z.string().min(1, 'principal is required'),
-  sourceArn: z.string().min(1, 'sourceArn cannot be empty').optional(),
-  sourceAccount: z.string().min(1, 'sourceAccount cannot be empty').optional(),
-  principalOrgId: z.string().min(1, 'principalOrgId cannot be empty').optional(),
-  eventSourceToken: z.string().min(1, 'eventSourceToken cannot be empty').optional(),
+  sourceArn: z.string().optional(),
+  sourceAccount: z.string().optional(),
+  principalOrgId: z.string().optional(),
+  eventSourceToken: z.string().optional(),
   functionUrlAuthType: z.enum(['NONE', 'AWS_IAM']).optional(),
   qualifier: z
     .string()
     .min(1, 'qualifier cannot be empty')
     .max(128, 'qualifier cannot exceed 128 characters')
     .optional(),
-  revisionId: z.string().min(1, 'revisionId cannot be empty').optional(),
+  revisionId: z.string().optional(),
 })
 
 const AddPermissionResponseSchema = z.object({

apps/sim/lib/api/contracts/tools/aws/lambda-create-event-source-mapping.ts

@@ -36,9 +36,9 @@ const CreateEventSourceMappingSchema = z
     queues: z.array(z.string()).optional(),
     functionResponseTypes: z.array(z.enum(['ReportBatchItemFailures'])).optional(),
     filterPatterns: z.array(z.string()).optional(),
-    onSuccessDestination: z.string().min(1, 'onSuccessDestination cannot be empty').optional(),
-    onFailureDestination: z.string().min(1, 'onFailureDestination cannot be empty').optional(),
-    kmsKeyArn: z.string().min(1, 'kmsKeyArn cannot be empty').optional(),
+    onSuccessDestination: z.string().optional(),
+    onFailureDestination: z.string().optional(),
+    kmsKeyArn: z.string().optional(),
     tags: z.record(z.string(), z.string()).optional(),
     sourceAccessConfigurations: z
       .array(
@@ -49,20 +49,11 @@ const CreateEventSourceMappingSchema = z
       )
       .max(22, 'sourceAccessConfigurations accepts at most 22 entries')
       .optional(),
-    documentDbDatabaseName: z.string().min(1, 'documentDbDatabaseName cannot be empty').optional(),
-    documentDbCollectionName: z
-      .string()
-      .min(1, 'documentDbCollectionName cannot be empty')
-      .optional(),
+    documentDbDatabaseName: z.string().optional(),
+    documentDbCollectionName: z.string().optional(),
     documentDbFullDocument: z.enum(['UpdateLookup', 'Default']).optional(),
-    amazonManagedKafkaConsumerGroupId: z
-      .string()
-      .min(1, 'amazonManagedKafkaConsumerGroupId cannot be empty')
-      .optional(),
-    selfManagedKafkaConsumerGroupId: z
-      .string()
-      .min(1, 'selfManagedKafkaConsumerGroupId cannot be empty')
-      .optional(),
+    amazonManagedKafkaConsumerGroupId: z.string().optional(),
+    selfManagedKafkaConsumerGroupId: z.string().optional(),
     selfManagedKafkaBootstrapServers: z
       .array(z.string().min(1, 'a bootstrap server cannot be empty'))
       .optional(),

apps/sim/lib/api/contracts/tools/aws/lambda-create-function.ts

@@ -18,14 +18,14 @@ const CreateFunctionSchema = z
       .min(1, 'functionName is required')
       .max(256, 'functionName cannot exceed 256 characters'),
     role: z.string().min(1, 'role is required'),
-    runtime: z.string().min(1, 'runtime cannot be empty').optional(),
-    handler: z.string().min(1, 'handler cannot be empty').optional(),
+    runtime: z.string().optional(),
+    handler: z.string().optional(),
     packageType: z.enum(['Zip', 'Image']).optional(),
     s3Bucket: z.string().min(1, 's3Bucket cannot be empty').optional(),
     s3Key: z.string().min(1, 's3Key cannot be empty').optional(),
     s3ObjectVersion: z.string().min(1, 's3ObjectVersion cannot be empty').optional(),
     imageUri: z.string().min(1, 'imageUri cannot be empty').optional(),
-    sourceKmsKeyArn: z.string().min(1, 'sourceKmsKeyArn cannot be empty').optional(),
+    sourceKmsKeyArn: z.string().optional(),
     description: z.string().max(256, 'description cannot exceed 256 characters').optional(),
     functionTimeout: z.number().int().min(1).max(900).optional(),
     memorySize: z.number().int().min(128).max(32768).optional(),
@@ -41,11 +41,11 @@ const CreateFunctionSchema = z
     vpcSubnetIds: z.array(z.string()).optional(),
     vpcSecurityGroupIds: z.array(z.string()).optional(),
     tracingMode: z.enum(['Active', 'PassThrough']).optional(),
-    deadLetterTargetArn: z.string().min(1, 'deadLetterTargetArn cannot be empty').optional(),
-    kmsKeyArn: z.string().min(1, 'kmsKeyArn cannot be empty').optional(),
+    deadLetterTargetArn: z.string().optional(),
+    kmsKeyArn: z.string().optional(),
     snapStartApplyOn: z.enum(['PublishedVersions', 'None']).optional(),
     logFormat: z.enum(['JSON', 'Text']).optional(),
-    logGroup: z.string().min(1, 'logGroup cannot be empty').optional(),
+    logGroup: z.string().optional(),
   })
   .superRefine((value, ctx) => {
     const hasAnyZipField = Boolean(
@@ -71,11 +71,11 @@ const CreateFunctionSchema = z
       })
       return
     }
-    if (value.imageUri && value.packageType !== 'Image') {
+    if (value.imageUri && value.packageType === 'Zip') {
       ctx.addIssue({
         code: 'custom',
         path: ['packageType'],
-        message: 'packageType must be Image when imageUri is set',
+        message: 'packageType Zip requires an S3 package, not imageUri',
       })
     }
     if (hasS3 && value.packageType === 'Image') {

apps/sim/lib/api/contracts/tools/aws/lambda-get-function.ts

@@ -27,6 +27,9 @@ const GetFunctionResponseSchema = z.object({
   success: z.literal(true),
   output: z.object({
     configuration: lambdaFunctionConfigurationSchema.nullable(),
+    tagsError: z
+      .object({ errorCode: z.string().nullable(), message: z.string().nullable() })
+      .nullable(),
     code: z
       .object({
         repositoryType: z.string().nullable(),

apps/sim/lib/api/contracts/tools/aws/lambda-invoke.ts

@@ -18,7 +18,6 @@ const InvokeSchema = z.object({
   logType: z.enum(['None', 'Tail']).optional(),
   clientContext: z
     .string()
-    .min(1, 'clientContext cannot be empty')
     .max(3583, 'clientContext cannot exceed 3583 bytes of base64 data')
     .optional(),
   qualifier: z

apps/sim/lib/api/contracts/tools/aws/lambda-list-aliases.ts

@@ -18,7 +18,7 @@ const ListAliasesSchema = z.object({
     .string()
     .min(1, 'functionName is required')
     .max(256, 'functionName cannot exceed 256 characters'),
-  aliasFunctionVersion: z.string().min(1, 'aliasFunctionVersion cannot be empty').optional(),
+  aliasFunctionVersion: z.string().optional(),
 })
 
 const ListAliasesResponseSchema = z.object({

apps/sim/lib/api/contracts/tools/aws/lambda-list-functions.ts

@@ -16,7 +16,7 @@ const ListFunctionsSchema = z
     ...lambdaConnectionFields,
     ...lambdaPaginationFields,
     functionVersion: z.literal('ALL').optional(),
-    masterRegion: z.string().min(1, 'masterRegion cannot be empty').optional(),
+    masterRegion: z.string().optional(),
   })
   .superRefine((value, ctx) => {
     if (value.masterRegion && value.functionVersion !== 'ALL') {

apps/sim/lib/api/contracts/tools/aws/lambda-list-layer-versions.ts

@@ -22,7 +22,7 @@ const ListLayerVersionsSchema = z.object({
       /^(arn:[a-zA-Z0-9-]+:lambda:[a-zA-Z0-9-]+:\d{12}:layer:[a-zA-Z0-9-_]+)$|^[a-zA-Z0-9-_]+$/,
       'layerName must be a layer name or a layer ARN'
     ),
-  compatibleRuntime: z.string().min(1, 'compatibleRuntime cannot be empty').optional(),
+  compatibleRuntime: z.string().optional(),
   compatibleArchitecture: z.enum(['x86_64', 'arm64']).optional(),
 })
 

apps/sim/lib/api/contracts/tools/aws/lambda-list-layers.ts

@@ -14,7 +14,7 @@ import { defineRouteContract } from '@/lib/api/contracts/types'
 const ListLayersSchema = z.object({
   ...lambdaConnectionFields,
   ...lambdaSmallPaginationFields,
-  compatibleRuntime: z.string().min(1, 'compatibleRuntime cannot be empty').optional(),
+  compatibleRuntime: z.string().optional(),
   compatibleArchitecture: z.enum(['x86_64', 'arm64']).optional(),
 })