chore(files): tidy archive extraction cleanup

Author: waleedlatif1

apps/sim/lib/uploads/archive.test.ts

@@ -11,27 +11,22 @@ import { beforeEach, describe, expect, it, vi } from 'vitest'
  * and the folder/file layers, not in the extractor's own arithmetic. The fake
  * therefore enforces the real rules:
  *
- * - folder paths are validated with the production {@link parseFolderPath} family,
- *   so a non-canonical path (no leading slash, unencoded segment) throws exactly
- *   as `requireNonRootFolderPath` does in `workspace-file-folder-manager`;
- * - `createWorkspaceFileFolderOperation` creates ONE leaf and rejects an existing
- *   path or a missing parent, mirroring `createWorkspaceFileFolderAtPath`;
+ * - folder keys are built with the production {@link buildFolderPath}, so a segment
+ *   that needs encoding is rejected or encoded exactly as the folder layer would;
  * - `exactName: true` throws `FileConflictError` on a duplicate leaf name, while
  *   `exactName: false` auto-suffixes, mirroring `uploadWorkspaceFile`.
  */
-const { store, mockUpload, mockDelete, mockCreateFolder, mockEnsureFolder } = vi.hoisted(() => ({
+const { store, mockUpload, mockDelete, mockEnsureFolder } = vi.hoisted(() => ({
   store: {
     folderIdByPath: new Map<string, string>(),
     fileKeys: new Set<string>(),
     sequence: 0,
   },
   mockUpload: vi.fn(),
   mockDelete: vi.fn(),
-  mockCreateFolder: vi.fn(),
   mockEnsureFolder: vi.fn(),
 }))
 vi.mock('@/lib/workspace-files/application/workspace-file-folders', () => ({
-  createWorkspaceFileFolderOperation: { execute: mockCreateFolder },
   ensureWorkspaceFileFolderPathOperation: { execute: mockEnsureFolder },
 }))
 vi.mock('@/lib/workspace-files/application/create-workspace-file', () => ({
@@ -45,7 +40,7 @@ vi.mock('@/lib/workspace-files/application/delete-workspace-file', () => ({
   },
 }))
 
-import { buildFolderPath, requireNonRootFolderPath } from '@/lib/folders/paths'
+import { buildFolderPath } from '@/lib/folders/paths'
 import {
   decompressArchiveBufferToWorkspaceFiles,
   MAX_ARCHIVE_CENTRAL_DIR_EXTRA_BYTES,
@@ -125,20 +120,6 @@ beforeEach(() => {
   store.fileKeys.clear()
   store.sequence = 0
 
-  mockCreateFolder.mockImplementation(async ({ input }: { input: { path: string } }) => {
-    const segments = requireNonRootFolderPath(input.path)
-    if (store.folderIdByPath.has(input.path)) {
-      throw new Error(`A folder named "${segments[segments.length - 1]}" already exists`)
-    }
-    const parentPath = buildFolderPath(segments.slice(0, -1))
-    if (parentPath !== '/' && !store.folderIdByPath.has(parentPath)) {
-      throw new Error('Parent folder not found')
-    }
-    const id = `folder_${++store.sequence}`
-    store.folderIdByPath.set(input.path, id)
-    return { folder: { id, path: input.path } }
-  })
-
   mockEnsureFolder.mockImplementation(async ({ input }: { input: { pathSegments: string[] } }) => {
     let folderId: string | null = null
     const walked: string[] = []

apps/sim/lib/workspace-files/application/workspace-file-folders.ts

@@ -272,8 +272,8 @@ export const createWorkspaceFileFolderOperation = defineAuthorizedWorkspaceFileU
  * Idempotently materializes a whole folder chain, reusing every folder that already
  * exists and creating only the missing ones. Unlike {@link createWorkspaceFileFolderOperation}
  * — which creates exactly one leaf and fails on an existing path or a missing parent —
- * this is the primitive for writers that materialize a tree (archive extraction, workspace
- * import), where intermediate folders and repeat runs are expected rather than exceptional.
+ * this is the primitive for writers that materialize a tree (archive extraction), where
+ * intermediate folders and repeat runs are expected rather than exceptional.
  */
 export const ensureWorkspaceFileFolderPathOperation = defineAuthorizedWorkspaceFileUseCase({
   operation: fileOperations.createFolder,