From ad8187aefd0bd0830814e88706d2e80152240092 Mon Sep 17 00:00:00 2001 From: shinyobjectz Date: Fri, 13 Nov 2026 13:12:11 -0800 Subject: [PATCH] Release: the Windows nasm step checks its version without /dev/stderr rc5's Windows job stopped in the nasm step: Git Bash on the runner has no /dev/stderr, so the tee that printed nasm -v failed. The output is now captured, printed, and matched against the pinned version. --- .github/workflows/release.yml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 0e0f97b0..02700014 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -254,7 +254,10 @@ jobs: v=2.16.03 curl -fsSL --retry 3 -o "$RUNNER_TEMP/nasm.zip" "https://www.nasm.us/pub/nasm/releasebuilds/$v/win64/nasm-$v-win64.zip" unzip -q "$RUNNER_TEMP/nasm.zip" -d "$RUNNER_TEMP" - "$RUNNER_TEMP/nasm-$v/nasm.exe" -v | tee /dev/stderr | grep -q "version $v" + # Git Bash on Windows has no /dev/stderr (rc5 stopped here): capture, print, then match + out=$("$RUNNER_TEMP/nasm-$v/nasm.exe" -v) + echo "$out" + case $out in *"version $v"*) ;; *) echo "::error::expected NASM $v, got: $out"; exit 1 ;; esac echo "$RUNNER_TEMP/nasm-$v" >> "$GITHUB_PATH" # jq for Windows ends -r lines with CRLF, so tools/bevy-plugins.sh read "ahoy\r" and lost its Bevy 0.20 block # (feature `ahoy` not found, 11-04); -b writes LF