Repository navigation
Commit eeea139
committed
Bevy's deferred_raymarch, exact: a GBufferPass, drawn in the camera's viewport; cameras and lights placed by their own rotation
shader_advanced/deferred_raymarch (docs/control.feature FC2d) ports with a <GBufferPass> on the camera
(systems/phase gbuffer.rs): a shader file's fullscreen fragment writes Bevy's deferred G-buffer, the
lighting pass id and depth after the late deferred prepass, and its shadow entry writes every shadow view
the camera's lights draw, so Bevy's deferred lighting lights it and it casts shadows. It matches Bevy to
the pixel (SSIM 1.000000, 0 px off at frames 5, 10 and 30); the whole suite (147 ports) passes on pixels.
Three gaps closed on the way, each found by probing the shader's inputs on both sides:
- The pass sets the camera's viewport, as Bevy's own passes do. raea's target is w x (h + 1) (its tag
row), so a fullscreen triangle drawn without it stretched its uv over 721 rows: rays a pixel low at the
bottom.
- Camera3d sends its rotation, and the engine places the camera by it (rot_qx..qw, exact). It used to send
a look-at point the engine turned back into a rotation in f32, about a millionth of a radian off. Bevy's
lights do the same (their direction was also rounded to 1e-6).
- Transform.lookingAt computes in f32 as glam does (Dir3::new, cross, try_normalize,
Quat::from_rotation_axes), the same quaternion to the bit; glam.test.ts holds it to glam's own bits.
The port sets Bevy's shadow defaults in a <Shadows> (2048 texels, cascades to 150 m, the first to 10 m,
overlap 0.2), as the other shadowed ports do. Mutants (no shadow entry, the first cascade at 8 m, 7000 lux,
the cube moved 5 cm, the camera's target 1 cm up) are each thousands of pixels off.1 parent ce63b7a commit eeea139
20 files changed
Lines changed: 396 additions & 62 deletions
File tree
- bench/bevy-parity
- docs
- bevy-parity
- runtime
- look
- src
- tests
- scene3d/src
- scene/src
- sdk
- raea
- bench/bevy-parity/shader_advanced
- conformance
- render/src
- 3d
- bevy3d
- systems/phase/src
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
145 | 145 | | |
146 | 146 | | |
147 | 147 | | |
| 148 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
144 | 144 | | |
145 | 145 | | |
146 | 146 | | |
| 147 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
7 | | - | |
| 7 | + | |
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
| |||
236 | 236 | | |
237 | 237 | | |
238 | 238 | | |
| 239 | + | |
| 240 | + | |
| 241 | + | |
239 | 242 | | |
240 | 243 | | |
241 | 244 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
223 | 223 | | |
224 | 224 | | |
225 | 225 | | |
| 226 | + | |
| 227 | + | |
| 228 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
65 | 65 | | |
66 | 66 | | |
67 | 67 | | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
68 | 73 | | |
69 | 74 | | |
70 | 75 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
34 | 34 | | |
35 | 35 | | |
36 | 36 | | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
117 | 117 | | |
118 | 118 | | |
119 | 119 | | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
120 | 125 | | |
121 | 126 | | |
122 | 127 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
55 | 55 | | |
56 | 56 | | |
57 | 57 | | |
58 | | - | |
| 58 | + | |
59 | 59 | | |
60 | 60 | | |
61 | 61 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
68 | 68 | | |
69 | 69 | | |
70 | 70 | | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
71 | 78 | | |
72 | 79 | | |
73 | 80 | | |
| |||
386 | 393 | | |
387 | 394 | | |
388 | 395 | | |
| 396 | + | |
| 397 | + | |
| 398 | + | |
| 399 | + | |
| 400 | + | |
| 401 | + | |
| 402 | + | |
| 403 | + | |
| 404 | + | |
| 405 | + | |
| 406 | + | |
| 407 | + | |
| 408 | + | |
| 409 | + | |
| 410 | + | |
| 411 | + | |
| 412 | + | |
| 413 | + | |
| 414 | + | |
| 415 | + | |
| 416 | + | |
| 417 | + | |
| 418 | + | |
| 419 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
199 | 199 | | |
200 | 200 | | |
201 | 201 | | |
202 | | - | |
| 202 | + | |
203 | 203 | | |
204 | 204 | | |
205 | 205 | | |
206 | 206 | | |
207 | 207 | | |
208 | | - | |
209 | | - | |
210 | | - | |
| 208 | + | |
| 209 | + | |
| 210 | + | |
| 211 | + | |
| 212 | + | |
| 213 | + | |
| 214 | + | |
| 215 | + | |
| 216 | + | |
211 | 217 | | |
212 | 218 | | |
213 | 219 | | |
| |||
308 | 314 | | |
309 | 315 | | |
310 | 316 | | |
| 317 | + | |
| 318 | + | |
311 | 319 | | |
312 | 320 | | |
| 321 | + | |
| 322 | + | |
313 | 323 | | |
314 | 324 | | |
315 | 325 | | |
| |||
458 | 468 | | |
459 | 469 | | |
460 | 470 | | |
| 471 | + | |
| 472 | + | |
| 473 | + | |
| 474 | + | |
| 475 | + | |
| 476 | + | |
| 477 | + | |
0 commit comments