Skip to content

Feature: DOMAIN_CONTROLLERS string match for non-English Active Directory #8

@fkxdr

Description

@fkxdr

I know it is tagged as TODO, but in config.ml:

set DOMAIN_CONTROLLERS = "DOMAIN CONTROLLERS@" # TODO: check languages

On non-English Active Directory installations, the Domain Controllers group name is localized: "DOMÄNENCONTROLLER@" on German systems or "CONTRÔLEURS DE DOMAINE@" on French systems. The string match might silently fail, missing paths via SeBackupPrivilege on OUs containing Domain Controllers.

The most robust fix (I believe?) would be to match against the well-known SID S-1-5-9 instead of the group name, which is language-independent.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions