Skip to content

cometspy.comets overrides user defined output filenames #64

Description

@surh

It seems like initializing a cometspy.comets object always overrides the values passed via a parameters object.

I think the defaults are fine, but if a user has specified some values for these output files, then those values should be kept.

cometspy/cometspy/comets.py

Lines 159 to 171 in 8a9e179

# dealing with output files
self.parameters.set_param("useLogNameTimeStamp", False)
self.parameters.set_param("TotalBiomassLogName",
"totalbiomasslog" + '_' + hex(id(self)))
self.parameters.set_param("BiomassLogName",
"biomasslog" + '_' + hex(id(self)))
self.parameters.set_param("FluxLogName",
"fluxlog" + '_' + hex(id(self)))
self.parameters.set_param("MediaLogName",
"medialog" + '_' + hex(id(self)))
self.parameters.set_param("velocityMultiConvLogName",
"velocitymulticonvlog" + '_' + hex(id(self)))

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Fields

    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions