fix(newfile): await local storage promise to prevent data corruption#74
Open
vibhutomer wants to merge 1 commit into
Open
fix(newfile): await local storage promise to prevent data corruption#74vibhutomer wants to merge 1 commit into
vibhutomer wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: Prevent Metadata Corruption on Auto-Save
Related Issue
Description of Changes
NewFile.tsx, thenewFile()handler was executing a synchronous read on an asynchronous Local Storage API.newFile()to anasyncfunction.awaitkeyword toprops.store._getFile(props.file)to properly resolve the file metadata before constructing the updatedFileobject.Impact
createdtimestamp from being overwritten withundefinedwhen the user opens a new workspace.