fix(auth): improve Ionic input handling and add form validation#64
Open
yashisrani wants to merge 1 commit into
Open
fix(auth): improve Ionic input handling and add form validation#64yashisrani wants to merge 1 commit into
yashisrani wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves the login form implementation by fixing Ionic input handling issues, adding proper validation, and improving TypeScript typings.
Changes Made
onIonChangewithonIonInputfor proper real-time input updatese.target.valueusage toe.detail.value(Ionic v7 compatible)type="email"type="password"MouseEventHandlerimportFunction(email: string, password: string) => voidScreenshots
Why
The previous implementation had issues with value capturing in Ionic v7 and lacked proper validation/type safety. These changes improve reliability, user experience, and code quality.