Augment path search#238
Draft
steiler wants to merge 10 commits into
Draft
Conversation
…ented`** → augment-only nodes may never hit Badger while `memstore` can resolve them. addSchemaElem now walks Augmented (persiststore.go) Choice/case: after recursing e.Dir, it also recurses e.Augmented (same as Schema.Walk). Normal nodes: after persisting children from e.Dir, it does the same for e.Augmented, so augment-only nodes get Badger keys and protos like the rest of the tree.
- Recurse yang.Entry.Augmented in persiststore.addSchemaElem (including choice/case) so Badger seeding matches getChildren/Walk; add augment regression test and testdata. - Add entryChildByName and use it in buildPath for list/container and augment-aware choice/case branches; extend findChoiceCase for implicit children and cases under choice.Augmented. - Add bpcc-base/bpcc-aug YANG and TestSchema_BuildPath_AugmentedUnderCase plus native leaf-a control path.
ToStrings(..., prefix=false) omits origin, but origin drives the module hint for unprefixed paths, so identical path strings could cache the wrong SchemaElem. Add Origin to cacheKey and a regression test with the TTL cache enabled.
Apply Path.origin as a first-element module hint in memstore, accept module-name prefixes at the root in FindPossibleModules, and add parsePathElems plus memstore/persiststore GetSchema parity tests (with separate compiled schemas so persiststore AddSchema Reset does not invalidate memstore).
BuildPath used only e.Dir[pe[0]] after module resolution; align with buildPath/getEntry by using entryChildByName and pathElemLocalName. Adds a regression test for an augmented-only direct child under a module.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.