fix(tree): RemainsToExist respects orphan delete-only-intended#437
Merged
Conversation
RemainsToExist ignored DeleteOnlyIntended, so mandatory validation treated orphan-deleted leaves as removed and rejected transactions. Match CanDelete/ShouldDelete and add regression tests. Co-authored-by: Cursor <cursoragent@cursor.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LeafVariants.RemainsToExist()only treated non-delete variants as "still present", whileCanDelete/ShouldDeletealready treatDeleteOnlyIntended(orphan delete) as leaving the device value unchanged. Mandatory validation short-circuits onRemainsToExist(), so orphan deletes could incorrectly fail with errors such as mandatory child missing even though the device still holds the data.DeleteOnlyIntendedset as remaining, matching the delete semantics used elsewhere, and add table tests for orphan delete with and without a running variant.