Suppress delete branch not existing error#432
Open
steiler wants to merge 1 commit into
Open
Conversation
steiler
requested review from
alexandernorth,
faebr,
henderiw and
severindellsperger
alexandernorth
approved these changes
May 19, 2026
severindellsperger
approved these changes
May 20, 2026
Collaborator
Author
|
@copilot resolve the merge conflicts in this pull request |
Copilot stopped work on behalf of
steiler due to an error
May 21, 2026 08:57
Fixes **idempotent delete** when the target path is **already absent** from the internal config tree: `writeBackSyncTree` → `DeleteBranch` no longer fails on `NavigateSdcpbPath` “path not found”, so **TransactionSet** can complete successfully instead of surfacing a hard RPC error that **config-server** treated as unrecoverable. **Domain:** `ops.ErrNavigateSdcpbPathNotFound` stays in **data-server**; `DeleteBranch` treats it as **no-op** (aligned with existing `ApplyToRunning` / `sync` behavior). **No** extra gRPC mapping or **sdc-protos** wire helpers. **Relation to [config-server#439](sdcio/config-server#439) / [#433](sdcio/config-server#433 addresses the **root cause** so string-matching or importing **data-server** errors in config-server for this case should be **unnecessary** once this server version is in use.
steiler
force-pushed
the
deleteBranchErrorSuppress
branch
from
bb63288 to
32cf890
Compare
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Fixes idempotent delete when the target path is already absent from the internal config tree:
writeBackSyncTree→DeleteBranchno longer fails onNavigateSdcpbPath“path not found”, so TransactionSet can complete successfully instead of surfacing a hard RPC error that config-server treated as unrecoverable.Domain:
ops.ErrNavigateSdcpbPathNotFoundstays in data-server;DeleteBranchtreats it as no-op (aligned with existingApplyToRunning/syncbehavior). No extra gRPC mapping or sdc-protos wire helpers.Relation to config-server#439 / #433: addresses the root cause so string-matching or importing data-server errors in config-server for this case should be unnecessary once this server version is in use.