Skip to content

fix DeviationName for get#450

Merged
steiler merged 1 commit into
mainfrom
deviationNameIssue
May 22, 2026
Merged

fix DeviationName for get#450
steiler merged 1 commit into
mainfrom
deviationNameIssue

Conversation

@henderiw
Copy link
Copy Markdown
Contributor

Currently in main we get an issue with deviation reapply. The DeviationName for the get was not correct for retrieving the resource. The prefix was not applied correctly

{"time":"2026-05-21T13:50:44.24043299Z","level":"WARN","message":"config transaction failed","logger":"sdc-controller-logger","data":{"controller":"TargetConfigController","req":{"Namespace":"default","Name":"sr1"},"retry":true,"error":{"message":"Internal error occurred: Internal error occurred: AlreadyExists","stack":["/home/runner/go/pkg/mod/github.com/henderiw/logger@v0.0.0-20230911123436-8655829b1abe/log/handler.go:34 (github.com/henderiw/logger/log.(*Handler).Handle)","/home/runner/work/config-server/config-server/pkg/reconcilers/targetconfig/reconciler.go:210 (github.com/sdcio/config-server/pkg/reconcilers/targetconfig.(*reconciler).Reconcile)","/home/runner/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.23.1/pkg/internal/controller/controller.go:222 (sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller[...]).Reconcile)","/home/runner/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.23.1/pkg/internal/controller/controller.go:479 (sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller[...]).reconcileHandler)","/home/runner/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.23.1/pkg/internal/controller/controller.go:438 (sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller[...]).processNextWorkItem)","/home/runner/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.23.1/pkg/internal/controller/controller.go:313 (sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller[...]).Start.func1.1)","/opt/hostedtoolcache/go/1.25.0/x64/src/runtime/asm_amd64.s:1693 (runtime.goexit)"]}}}
{"time":"2026-05-21T13:50:44.24076407Z","level":"WARN","message":"config transaction failed","logger":"sdc-controller-logger","data":{"controller":"TargetConfigController","req":{"Namespace":"default","Name":"sr1"},"message":""" err "Internal error occurred: Internal error occurred: AlreadyExists"","error":{"message":"Internal error occurred: Internal error occurred: AlreadyExists","stack":["/home/runner/go/pkg/mod/github.com/henderiw/logger@v0.0.0-20230911123436-8655829b1abe/log/handler.go:34 (github.com/henderiw/logger/log.(*Handler).Handle)","/home/runner/work/config-server/config-server/pkg/reconcilers/targetconfig/reconciler.go:270 (github.com/sdcio/config-server/pkg/reconcilers/targetconfig.(*reconciler).handleError)","/home/runner/work/config-server/config-server/pkg/reconcilers/targetconfig/reconciler.go:223 (github.com/sdcio/config-server/pkg/reconcilers/targetconfig.(*reconciler).Reconcile)","/home/runner/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.23.1/pkg/internal/controller/controller.go:222 (sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller[...]).Reconcile)","/home/runner/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.23.1/pkg/internal/controller/controller.go:479 (sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller[...]).reconcileHandler)","/home/runner/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.23.1/pkg/internal/controller/controller.go:438 (sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller[...]).processNextWorkItem)","/home/runner/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.23.1/pkg/internal/controller/controller.go:313 (sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller[...]).Start.func1.1)","/opt/hostedtoolcache/go/1.25.0/x64/src/runtime/asm_amd64.s:1693 (runtime.goexit)"]}}}
{"time":"2026-05-21T13:50:44.296218578Z","level":"INFO","message":"config transaction success","logger":"sdc-controller-logger","data":{"controller":"TargetConfigController","req":{"Namespace":"default","Name":"sr2"},"retry":false}}
{"time":"2026-05-21T13:50:44.303805302Z","level":"INFO","message":"reconcile","logger":"sdc-controller-logger","data":{"controller":"TargetConfigController","req":{"Namespace":"default","Name":"sr2"}}}

@henderiw henderiw requested a review from a team as a code owner May 22, 2026 07:36
@alexandernorth alexandernorth added the safe to test Apply this label for PRs to kick off CI integration testing label May 22, 2026
Copy link
Copy Markdown
Contributor

@severindellsperger severindellsperger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix.

Copy link
Copy Markdown
Contributor

@alexandernorth alexandernorth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@steiler steiler merged commit 6d1ffa0 into main May 22, 2026
12 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

safe to test Apply this label for PRs to kick off CI integration testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants