Skip to content

Count proto-review author as self-review#438

Merged
jupblb merged 1 commit into
mainfrom
michal/rev-fix
Jun 5, 2026
Merged

Count proto-review author as self-review#438
jupblb merged 1 commit into
mainfrom
michal/rev-fix

Conversation

@jupblb

@jupblb jupblb commented Jun 5, 2026

Copy link
Copy Markdown
Member

The SCIP CSC requirement listed every reviewer in an all-of, including the PR author—who can't approve their own PR—so Required review was stuck pending. Wrapping each member in is-author-or-reviewer lets the author's slot count as self-reviewed while the others must still approve.

@jupblb jupblb requested review from emidoots, eseliger and trly June 5, 2026 08:10
@jupblb jupblb enabled auto-merge (squash) June 5, 2026 08:10
@jupblb jupblb merged commit 06c66e5 into main Jun 5, 2026
13 checks passed
@jupblb jupblb deleted the michal/rev-fix branch June 5, 2026 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants