Skip to content

Commit 5813d17

Browse files
committed
Grab inherited methods/fields
1 parent d6cbdf1 commit 5813d17

2 files changed

Lines changed: 12 additions & 2 deletions

File tree

‎src/main/java/org/scijava/plugins/scripting/jython/DotAutocompletions.java‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -92,10 +92,10 @@ static public void staticFieldsAndStaticMethodsInto(final Class<?> c, final List
9292
* @param ac
9393
*/
9494
static public void fieldsAndMethodsInto(final Class<?> c, final List<CompletionText> ac) {
95-
for (final Field f: c.getDeclaredFields())
95+
for (final Field f: c.getFields())
9696
if (!Modifier.isStatic(f.getModifiers()))
9797
ac.add(new CompletionText(f.getName(), c, f));
98-
for (final Method m: c.getDeclaredMethods())
98+
for (final Method m: c.getMethods())
9999
if (!Modifier.isStatic(m.getModifiers()))
100100
ac.add(new CompletionText(m.getName() + "()", c, m));
101101
}

‎src/test/java/org/scijava/plugins/scripting/jython/JythonCompletionTest.java‎

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -159,6 +159,16 @@ public void testAssignmentShadowsScriptParameter() {
159159
"name.ensureCapacity"));
160160
}
161161

162+
@Test
163+
public void testInheritedMembers() {
164+
final List<String> texts = complete(
165+
"from java.util import ArrayList\nlist = ArrayList()\nlist.");
166+
// members come from superinterfaces
167+
assertTrue(texts.contains("list.add"));
168+
// members come from superclasses
169+
assertTrue(texts.contains("list.toString"));
170+
}
171+
162172
@Test
163173
public void testInterpreterBindings() throws Exception {
164174
final Context ctx = new Context();

0 commit comments

Comments
 (0)