diff --git a/.jules/sentinel.md b/.jules/sentinel.md new file mode 100644 index 00000000..c8db18a4 --- /dev/null +++ b/.jules/sentinel.md @@ -0,0 +1,4 @@ +## 2025-02-14 - Fix Timing Attack in Authentication +**Vulnerability:** Fast-path short-circuiting in token validation using buffer length comparisons before calling `crypto.timingSafeEqual` introduces a timing attack vulnerability. +**Learning:** Evaluating the lengths of tokens before performing a constant-time comparison leaks the length of the secret auth token. +**Prevention:** Always hash both the expected and provided secrets to a fixed length (e.g., using `crypto.createHash('sha256')`) before comparison to ensure true constant-time evaluation regardless of input length. diff --git a/src/cli/commands/serve.ts b/src/cli/commands/serve.ts index 2c37293e..09448b63 100644 --- a/src/cli/commands/serve.ts +++ b/src/cli/commands/serve.ts @@ -349,10 +349,9 @@ export async function handleServeCommand(_options: unknown, command: Command) { const tokenBuffer = Buffer.from(token); for (const authToken of authTokens) { const authTokenBuffer = Buffer.from(authToken); - if ( - tokenBuffer.length === authTokenBuffer.length && - crypto.timingSafeEqual(tokenBuffer, authTokenBuffer) - ) { + const tokenHash = crypto.createHash('sha256').update(tokenBuffer).digest(); + const expectedHash = crypto.createHash('sha256').update(authTokenBuffer).digest(); + if (crypto.timingSafeEqual(tokenHash, expectedHash)) { isAuthenticated = true; break; } diff --git a/tests/integration/prompt_templates.test.ts b/tests/integration/prompt_templates.test.ts index 21905259..f1360d78 100644 --- a/tests/integration/prompt_templates.test.ts +++ b/tests/integration/prompt_templates.test.ts @@ -36,7 +36,9 @@ describe('Prompt templates', () => { expect(planSystem).toContain('You are SalmonLoop.'); expect(patchSystem).toContain('You are PATCH, a phase-native diff compiler.'); - expect(autopilotSystem).toContain('You are a senior software engineer running in "autopilot" mode.'); + expect(autopilotSystem).toContain( + 'You are a senior software engineer running in "autopilot" mode.', + ); expect(answerSystem).toContain('You are a coding assistant in "answer" mode.'); expect(researchSystem).toContain('You are a research assistant.'); });