From 7437470ece72ad4caae8b6516d954369340e70bd Mon Sep 17 00:00:00 2001 From: Chris Pinkenburg Date: Fri, 26 Jun 2026 19:07:11 -0400 Subject: [PATCH 1/2] clear fitter cache to get rid of possible leaks --- offline/packages/mbd/MbdSig.cc | 4 ++++ offline/packages/mbd/MbdSig.h | 5 ++++- 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/offline/packages/mbd/MbdSig.cc b/offline/packages/mbd/MbdSig.cc index 65de1006fc..8c65012756 100644 --- a/offline/packages/mbd/MbdSig.cc +++ b/offline/packages/mbd/MbdSig.cc @@ -7,12 +7,14 @@ #include #include #include +#include #include #include #include #include #include #include +#include #include #include @@ -140,6 +142,8 @@ MbdSig::~MbdSig() { _pileupfile->close(); } + // ROOT keeps the current fitter as a process-wide cache after Fit(). + TVirtualFitter::SetFitter(nullptr, 0); delete hRawPulse; delete hSubPulse; delete gRawPulse; diff --git a/offline/packages/mbd/MbdSig.h b/offline/packages/mbd/MbdSig.h index 69d5ca7bfd..a00607ba03 100644 --- a/offline/packages/mbd/MbdSig.h +++ b/offline/packages/mbd/MbdSig.h @@ -3,13 +3,16 @@ #include "MbdRunningStats.h" -#include +#include #include +#include #include class TTree; +class TF1; class TGraphErrors; +class TH1; class TH2; class MbdCalib; From dcde38478d4bf977cd43cea963b961e5dcb28396 Mon Sep 17 00:00:00 2001 From: Chris Pinkenburg Date: Fri, 26 Jun 2026 19:07:45 -0400 Subject: [PATCH 2/2] fix memory leak in CaloTowerBuilder --- offline/packages/CaloReco/CaloTowerBuilder.cc | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/offline/packages/CaloReco/CaloTowerBuilder.cc b/offline/packages/CaloReco/CaloTowerBuilder.cc index 2d0f31a017..9d439e4c24 100644 --- a/offline/packages/CaloReco/CaloTowerBuilder.cc +++ b/offline/packages/CaloReco/CaloTowerBuilder.cc @@ -13,9 +13,12 @@ #include #include +#include // for CDBTTree + +#include + #include #include // for SubsysReco -#include #include #include // for PHIODataNode @@ -23,10 +26,7 @@ #include // for PHNodeIterator #include // for PHObject #include - -#include // for CDBTTree - -#include +#include #include #include @@ -58,6 +58,7 @@ CaloTowerBuilder::~CaloTowerBuilder() { delete cdbttree; delete cdbttree_tbt_zs; + delete cdbttree_sepd_map; delete WaveformProcessing; }