Lint for redundant package alias in Cargo.toml

[notpeter]

What it does

Cargo will happily accept the following:

[dependencies]
foo = { package = "foo", version = "1.0" }

Where package declaration is redundant as crate name foo in package and the new alias foo are the same.

The lint would just suggesting removing package = "foo" key.
Similar to how rust fmt will convert use foo as foo; to use foo;

Advantage

• Remove a no-op directive

I encountered this in the wild here. This crashes renovate (their bug, not Cargo's problem).

Drawbacks

None? I can't imagine a situation where this wasn't a no-op.

Example

[dependencies]
foo = { package = "foo", version = "1.0" }

[dependencies.bar]
version = "1.0"
package = "bar"

Could be written as:

[dependencies]
foo = { version = "1.0" }
foo = "1.0"

[dependencies.bar]
version = "1.0"

[epage]

Drawbacks

None?

As we are still new to having a linting system, something I've been unsure about is dealing with

• maintenance load
• build time and runtime performance

Is there a time that a lint is too trivial in how it helps that it isn't worth it?

That said, this may not be the case here. The use of package sends a false signal to the reader that there is something more to look into that may be worth resolving.

[epage]

I marked this as S-needs-design as we need to work through the naming (again, we're all new at this).