From 92b513d9ecca9d30f277e7dae4fdc99837fc4794 Mon Sep 17 00:00:00 2001 From: Claude Date: Sat, 25 Jul 2026 14:16:48 +0000 Subject: [PATCH 1/3] ci: upgrade GitHub Actions to current majors GitHub now warns that actions/checkout@v4 and actions/setup-dotnet@v4 target Node 20 and are being force-run on Node 24. This moves every action to its current major, all of which declare the node24 runtime. actions/checkout v4 -> v7 (5 uses) actions/setup-dotnet v4 -> v6 (2 uses) actions/setup-node v4 -> v7 (2 uses) actions/cache v4 -> v6 (1 use) actions/upload-artifact v4 -> v7 (1 use) These are multi-major jumps, so the release notes were checked for breaking changes rather than bumping blind. Four are relevant, none of them bite here: - checkout v5+ refuses to check out fork PR code by default, needing `allow-unsafe-pr-checkout: true` to restore the old behaviour. The guard fires only on `pull_request_target` and `workflow_run`. This repo triggers on push, pull_request, workflow_dispatch and issue_comment, so nothing changes -- notably the /preview job's PR-head checkout is unaffected. (That job's own trust boundary is unchanged by this upgrade: it still runs owner-only.) - setup-dotnet v5+ dropped support for older .NET versions. This repo pins 9.0.x and targets net8.0/net9.0, so it is unaffected. - setup-node v5+ enables automatic caching when package.json has a `packageManager` field, narrowed to npm in v6. No package.json in this repo sets that field, so no caching behaviour changes and no lockfile is required. - cache/upload-artifact v5+ require Actions Runner 2.327.1+. Only GitHub-hosted runners are used, which are well past that. Verified: fetched action.yml at each new major and confirmed every input this repo passes still exists (11 steps cross-checked programmatically), that cache@v6 still exposes the `cache-hit` output the export action reads, and that upload-artifact@v7 still accepts `if-no-files-found`. All three YAML files parse. Coverage note: only test.yml runs on a pull request, so these checks exercise checkout@v7 and setup-dotnet@v6 alone. The setup-node, cache and upload-artifact bumps live in web-export.yml, which runs only on merge to main or an explicit /preview -- they are validated by schema, not by execution. Worth a /preview before merging if you want them exercised first. Co-Authored-By: Claude Opus 5 Claude-Session: https://claude.ai/code/session_01NwhKDz2xEVEtYECxT7q5F3 --- .github/actions/export-web/action.yml | 6 +++--- .github/workflows/test.yml | 4 ++-- .github/workflows/web-export.yml | 12 ++++++------ 3 files changed, 11 insertions(+), 11 deletions(-) diff --git a/.github/actions/export-web/action.yml b/.github/actions/export-web/action.yml index af113a9..aa420cb 100644 --- a/.github/actions/export-web/action.yml +++ b/.github/actions/export-web/action.yml @@ -45,7 +45,7 @@ runs: Write-Host "Version check OK: Godot.NET.Sdk $sdkMM matches template $env:TEMPLATE_VERSION" - name: Set up .NET 9 SDK - uses: actions/setup-dotnet@v4 + uses: actions/setup-dotnet@v6 with: dotnet-version: "9.0.x" @@ -55,7 +55,7 @@ runs: - name: Cache patched editor download id: editorcache - uses: actions/cache@v4 + uses: actions/cache@v6 with: path: ${{ runner.temp }}/godot-zip key: godot-editor-${{ inputs.godot_fork_tag }} @@ -162,7 +162,7 @@ runs: - name: Upload web export artifact if: always() - uses: actions/upload-artifact@v4 + uses: actions/upload-artifact@v7 with: name: maze-web-export-${{ github.run_id }}-${{ github.run_attempt }} path: | diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 34c5d78..aa19929 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -20,10 +20,10 @@ jobs: runs-on: ubuntu-latest steps: - name: Checkout - uses: actions/checkout@v4 + uses: actions/checkout@v7 - name: Set up .NET 9 SDK - uses: actions/setup-dotnet@v4 + uses: actions/setup-dotnet@v6 with: dotnet-version: "9.0.x" diff --git a/.github/workflows/web-export.yml b/.github/workflows/web-export.yml index 929dfe4..709327b 100644 --- a/.github/workflows/web-export.yml +++ b/.github/workflows/web-export.yml @@ -58,7 +58,7 @@ jobs: VERCEL_PROJECT_ID: ${{ secrets.VERCEL_PROJECT_ID }} steps: - name: Checkout - uses: actions/checkout@v4 + uses: actions/checkout@v7 - name: Export web (WASM) uses: ./.github/actions/export-web @@ -96,9 +96,9 @@ jobs: runs-on: ubuntu-latest steps: - name: Checkout - uses: actions/checkout@v4 + uses: actions/checkout@v7 - name: Set up Node - uses: actions/setup-node@v4 + uses: actions/setup-node@v7 with: node-version: "20" - name: Install Playwright (chromium) @@ -141,7 +141,7 @@ jobs: "sha=$sha" >> $env:GITHUB_OUTPUT - name: Checkout PR head - uses: actions/checkout@v4 + uses: actions/checkout@v7 with: ref: ${{ steps.pr.outputs.sha }} @@ -184,9 +184,9 @@ jobs: GH_TOKEN: ${{ github.token }} steps: - name: Checkout - uses: actions/checkout@v4 + uses: actions/checkout@v7 - name: Set up Node - uses: actions/setup-node@v4 + uses: actions/setup-node@v7 with: node-version: "20" - name: Install Playwright (chromium) From 5372ac3a07cf9eb8514e4360e103b37b16c6a6db Mon Sep 17 00:00:00 2001 From: Claude Date: Sat, 25 Jul 2026 15:18:24 +0000 Subject: [PATCH 2/3] ci: pin actions to commit SHAs with version comments Adopts the pinning convention already used across the other repos in this account -- `uses: @<40-char commit sha> # v` -- which this repo was the only one not following (0 of 13 pinned, against 100% in blog, github-actions, platform, rights-application, sentric-frontends, workspace and data-platform, and the large majority in the-vault-system and shared-utilities). A moving major tag can be repointed at new code by whoever controls the action, so the tag alone is not a supply-chain control. This repo already checksum-pins the third-party Godot editor binary for exactly that reason; the actions were the remaining gap. actions/checkout @3d3c42e5 # v7.0.1 (5 uses) actions/setup-dotnet @a98b5685 # v6.0.0 (2 uses) actions/setup-node @82076278 # v7.0.0 (2 uses) actions/cache @55cc8345 # v6.1.0 (1 use) actions/upload-artifact @043fb46d # v7.0.1 (1 use) Full semver in the comment, matching the dominant form in the other repos (platform, github-actions, the-vault-system) rather than the bare-major form in blog, since the exact patch is the thing a reader wants to check. Verification -- the failure mode of this convention is a comment that drifts from its SHA, so both directions were checked: - Resolved every SHA from upstream tags, then confirmed the method by resolving four pins that already exist in the other repos (checkout v7.0.0, setup-node v7.0.0, cache v6.1.0, setup-dotnet v5.2.0) and matching them byte for byte. - Re-derived each committed pin from its own comment: 5 distinct pins, 0 mismatched. - Two SHAs are byte-identical to pins already in platform (setup-node v7.0.0, cache v6.1.0), so those are corroborated by a second source. - All three YAML files parse; no unpinned third-party actions remain. Where this differs from the other repos: checkout and upload-artifact go to v7.0.1 rather than the v7.0.0 pinned elsewhere, and setup-dotnet to v6.0.0 rather than v5.2.0 -- these are the current latest, and a fresh pin may as well start there. Say the word to align them downward instead. No Dependabot config added: no repo in this account has one, so these pins are maintained by hand and this change does not alter that. Co-Authored-By: Claude Opus 5 Claude-Session: https://claude.ai/code/session_01NwhKDz2xEVEtYECxT7q5F3 --- .github/actions/export-web/action.yml | 6 +++--- .github/workflows/test.yml | 4 ++-- .github/workflows/web-export.yml | 12 ++++++------ 3 files changed, 11 insertions(+), 11 deletions(-) diff --git a/.github/actions/export-web/action.yml b/.github/actions/export-web/action.yml index aa420cb..9e7656d 100644 --- a/.github/actions/export-web/action.yml +++ b/.github/actions/export-web/action.yml @@ -45,7 +45,7 @@ runs: Write-Host "Version check OK: Godot.NET.Sdk $sdkMM matches template $env:TEMPLATE_VERSION" - name: Set up .NET 9 SDK - uses: actions/setup-dotnet@v6 + uses: actions/setup-dotnet@a98b56852c35b8e3190ac28c8c2271da59106c68 # v6.0.0 with: dotnet-version: "9.0.x" @@ -55,7 +55,7 @@ runs: - name: Cache patched editor download id: editorcache - uses: actions/cache@v6 + uses: actions/cache@55cc8345863c7cc4c66a329aec7e433d2d1c52a9 # v6.1.0 with: path: ${{ runner.temp }}/godot-zip key: godot-editor-${{ inputs.godot_fork_tag }} @@ -162,7 +162,7 @@ runs: - name: Upload web export artifact if: always() - uses: actions/upload-artifact@v7 + uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7.0.1 with: name: maze-web-export-${{ github.run_id }}-${{ github.run_attempt }} path: | diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index aa19929..6b4100a 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -20,10 +20,10 @@ jobs: runs-on: ubuntu-latest steps: - name: Checkout - uses: actions/checkout@v7 + uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1 - name: Set up .NET 9 SDK - uses: actions/setup-dotnet@v6 + uses: actions/setup-dotnet@a98b56852c35b8e3190ac28c8c2271da59106c68 # v6.0.0 with: dotnet-version: "9.0.x" diff --git a/.github/workflows/web-export.yml b/.github/workflows/web-export.yml index 709327b..d3ad1c3 100644 --- a/.github/workflows/web-export.yml +++ b/.github/workflows/web-export.yml @@ -58,7 +58,7 @@ jobs: VERCEL_PROJECT_ID: ${{ secrets.VERCEL_PROJECT_ID }} steps: - name: Checkout - uses: actions/checkout@v7 + uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1 - name: Export web (WASM) uses: ./.github/actions/export-web @@ -96,9 +96,9 @@ jobs: runs-on: ubuntu-latest steps: - name: Checkout - uses: actions/checkout@v7 + uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1 - name: Set up Node - uses: actions/setup-node@v7 + uses: actions/setup-node@820762786026740c76f36085b0efc47a31fe5020 # v7.0.0 with: node-version: "20" - name: Install Playwright (chromium) @@ -141,7 +141,7 @@ jobs: "sha=$sha" >> $env:GITHUB_OUTPUT - name: Checkout PR head - uses: actions/checkout@v7 + uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1 with: ref: ${{ steps.pr.outputs.sha }} @@ -184,9 +184,9 @@ jobs: GH_TOKEN: ${{ github.token }} steps: - name: Checkout - uses: actions/checkout@v7 + uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1 - name: Set up Node - uses: actions/setup-node@v7 + uses: actions/setup-node@820762786026740c76f36085b0efc47a31fe5020 # v7.0.0 with: node-version: "20" - name: Install Playwright (chromium) From baf4ca94cd272d4203a32df0373e8b2eb2e50301 Mon Sep 17 00:00:00 2001 From: Claude Date: Sun, 26 Jul 2026 08:23:17 +0000 Subject: [PATCH 3/3] chore: gitignore node_modules and Playwright run output MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This branch committed 170 files / 17.7 MiB of tests/visual/node_modules, plus a Playwright test-results/.last-run.json, because neither this branch nor `main` had any Node or Playwright ignore rules. The blobs are removed from this branch's history rather than deleted in a follow-up commit, so they never reach `main` at all — a later deletion would leave 17.7 MiB permanently in the repository. Identical to the block added on the #8 stack, so whichever merges to main first, the other merges without conflict. Baseline screenshots under *-snapshots/ stay tracked. --- .gitignore | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/.gitignore b/.gitignore index 2e1a838..b77522c 100644 --- a/.gitignore +++ b/.gitignore @@ -35,3 +35,13 @@ Thumbs.db # Godot UID files (regenerated by Godot) *.uid + +# Node.js dependencies (the Playwright suite under tests/visual/) +node_modules/ + +# Playwright run output — regenerated on every run. +# Baseline screenshots live in *-snapshots/ and ARE tracked; do not add them here. +test-results/ +playwright-report/ +blob-report/ +playwright/.cache/