fix(cli): preserve check file scope in fix hint

Author: chenjiahan

packages/rstack/src/cli/commands.ts

@@ -141,6 +141,16 @@ async function runRspressCLI(args: string[]): Promise<void> {
 
 const RSLINT_CONFIG_PATH = join(import.meta.dirname, 'rslintConfig.js');
 
+const SHELL_SAFE_ARGUMENT_REGEXP = /^[\w@%+=:,./-]+$/u;
+
+const quoteShellArgument = (argument: string): string =>
+  SHELL_SAFE_ARGUMENT_REGEXP.test(argument)
+    ? argument
+    : `'${argument.replaceAll("'", "'\"'\"'")}'`;
+
+const formatCommand = (args: readonly string[]): string =>
+  args.map(quoteShellArgument).join(' ');
+
 async function runRslintCLI(args: string[]): Promise<void> {
   if (hasHelpFlag(args)) {
     return printCommandHelp('lint');
@@ -192,7 +202,7 @@ async function runCheckCLI(args: string[]): Promise<void> {
     '../fmt/cli.ts'
   );
   await runFmtCLI(['--check', ...fileArgs], {
-    fixCommand: 'rs fmt',
+    fixCommand: formatCommand(['rs', 'fmt', ...fileArgs]),
     loadedConfig,
   });
 }

packages/rstack/tests/cli/check.test.ts

@@ -63,16 +63,28 @@ test('passes file arguments to lint and the formatting check', () => {
   expect(result.stderr).toBe('');
 });
 
+test('preserves file arguments in the formatting fix command', () => {
+  writeLintConfig();
+  writeProjectFile("src/selected file's.ts", 'const selected=true');
+
+  const result = runCheck(["src/selected file's.ts"]);
+
+  expect(result.status).toBe(1);
+  expect(result.stderr).toContain(
+    `Run rs fmt -- 'src/selected file'"'"'s.ts' to fix.`,
+  );
+});
+
 test('supports file arguments after the option terminator', () => {
   writeLintConfig();
-  writeProjectFile('--selected.ts', 'const selected = true;\n');
+  writeProjectFile('--selected.ts', 'const selected=true');
 
   const result = runCheck(['--', '--selected.ts']);
 
-  expect(result.status).toBe(0);
-  expect(result.stdout).toContain('Format check passed in');
-  expect(result.stdout).toContain('(1 file)');
-  expect(result.stderr).toBe('');
+  expect(result.status).toBe(1);
+  expect(result.stderr).toContain(
+    'Formatting issues found in 1 file. Run rs fmt -- --selected.ts to fix.',
+  );
 });
 
 test('enables type checking only with --type-check', () => {