From b325bf7bcd853bdc1dab8ed238652c0c8ac02b39 Mon Sep 17 00:00:00 2001 From: flakronademi Date: Wed, 18 Nov 2026 16:00:44 +0100 Subject: [PATCH 1/2] fix: rename Terminal to Console and Shell to Terminal --- src/renderer/components/terminal/index.tsx | 2 +- src/renderer/components/terminal/panels/ShellPanel.tsx | 2 +- src/renderer/components/terminal/panels/TerminalPanel.tsx | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/renderer/components/terminal/index.tsx b/src/renderer/components/terminal/index.tsx index b2414d3e..5bca055d 100644 --- a/src/renderer/components/terminal/index.tsx +++ b/src/renderer/components/terminal/index.tsx @@ -292,7 +292,7 @@ export const TerminalLayout: React.FC = ({ children, project }) => { - Terminal + Console {isRunning && ( diff --git a/src/renderer/components/terminal/panels/ShellPanel.tsx b/src/renderer/components/terminal/panels/ShellPanel.tsx index c34f920c..974783ff 100644 --- a/src/renderer/components/terminal/panels/ShellPanel.tsx +++ b/src/renderer/components/terminal/panels/ShellPanel.tsx @@ -388,7 +388,7 @@ const ShellHeaderActions: React.FC = ({ project }) => { export const shellPanel: TerminalPanelDefinition = { id: 'shell', - label: 'SHELL', + label: 'TERMINAL', // Never asks for focus on its own; the terminals live outside React, so // the body can unmount while another tab is shown without losing them. useState: () => ({ visible: true }), diff --git a/src/renderer/components/terminal/panels/TerminalPanel.tsx b/src/renderer/components/terminal/panels/TerminalPanel.tsx index 573cfb39..21ad96bd 100644 --- a/src/renderer/components/terminal/panels/TerminalPanel.tsx +++ b/src/renderer/components/terminal/panels/TerminalPanel.tsx @@ -9,7 +9,7 @@ const TerminalPanelBody: React.FC = ({ project }) => ( export const terminalPanel: TerminalPanelDefinition = { id: 'terminal', - label: 'TERMINAL', + label: 'CONSOLE', keepMounted: true, useState: () => { // Any CLI command (dbt, rosetta, python run…) surfaces the terminal. From 4779f4ceeb2d08b2f7fc1f6efd575b64d032563e Mon Sep 17 00:00:00 2001 From: flakronademi Date: Thu, 19 Nov 2026 11:06:48 +0100 Subject: [PATCH 2/2] fixed coderabbit issues --- e2e/tests/terminal/shell-terminal.spec.ts | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/e2e/tests/terminal/shell-terminal.spec.ts b/e2e/tests/terminal/shell-terminal.spec.ts index fead0c5a..13cbcc3a 100644 --- a/e2e/tests/terminal/shell-terminal.spec.ts +++ b/e2e/tests/terminal/shell-terminal.spec.ts @@ -1,8 +1,8 @@ /** * OS Shell Terminal Tests * - * The SHELL tab of the bottom panel: real shells running in the project - * folder, next to the built-in command terminal (TERMINAL tab). + * The TERMINAL tab of the bottom panel: real shells running in the project + * folder, next to the built-in command console (CONSOLE tab). */ import { Page } from '@playwright/test'; @@ -12,7 +12,7 @@ import { openProject } from '../../helpers/window.helper'; const PROJECT = 'test_project'; const shellTab = (window: Page) => - window.getByRole('button', { name: 'SHELL', exact: true }); + window.getByRole('button', { name: 'TERMINAL', exact: true }); const terminal = (window: Page) => window.getByTestId('shell-terminal'); const sessionList = (window: Page) => window.getByRole('listbox', { name: 'Open terminals' }); @@ -32,9 +32,9 @@ test.describe('Shell terminal', () => { }) => { const window = await openProject(electronApp, PROJECT); - // The built-in command terminal is still the default tab. + // The built-in command console is still the default tab. await expect( - window.getByRole('button', { name: 'TERMINAL', exact: true }), + window.getByRole('button', { name: 'CONSOLE', exact: true }), ).toBeVisible(); await expect( window.getByPlaceholder('Type a rosetta or dbt command...'), @@ -116,7 +116,7 @@ test.describe('Shell terminal', () => { await newTerminal(window).click(); await expect(sessionList(window).getByRole('option')).toHaveCount(2); - await window.getByRole('button', { name: 'TERMINAL', exact: true }).click(); + await window.getByRole('button', { name: 'CONSOLE', exact: true }).click(); await expect(terminal(window)).toHaveCount(0); // Coming back shows the same terminals instead of starting a new one.