From dbced725c0d07773918aad2d861a41a37d886f4a Mon Sep 17 00:00:00 2001 From: Nemo <306250675@qq.com> Date: Sun, 20 Apr 2025 11:35:11 +0800 Subject: [PATCH 1/5] Modify the Remove function for segment --- segment.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/segment.go b/segment.go index c3fde85..aa42a1c 100644 --- a/segment.go +++ b/segment.go @@ -154,10 +154,10 @@ func (seg *segment) Sync() error { // Remove removes the segment file. func (seg *segment) Remove() error { if !seg.closed { - seg.closed = true if err := seg.fd.Close(); err != nil { return err } + seg.closed = true } return os.Remove(seg.fd.Name()) From 917e88609130ec2bf7b58289ccf583849f8884d6 Mon Sep 17 00:00:00 2001 From: Nemo <306250675@qq.com> Date: Sun, 20 Apr 2025 11:35:54 +0800 Subject: [PATCH 2/5] formalised uniformity --- options.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/options.go b/options.go index da5393f..0cc4050 100644 --- a/options.go +++ b/options.go @@ -47,7 +47,7 @@ const ( var DefaultOptions = Options{ DirPath: os.TempDir(), - SegmentSize: GB, + SegmentSize: 1 * GB, SegmentFileExt: ".SEG", Sync: false, BytesPerSync: 0, From e39e66c4f1a0e8deb18fec6360ec9df0497fb6c5 Mon Sep 17 00:00:00 2001 From: Nemo <306250675@qq.com> Date: Sun, 20 Apr 2025 14:51:49 +0800 Subject: [PATCH 3/5] modify Close function for segment --- segment.go | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/segment.go b/segment.go index aa42a1c..a478e2b 100644 --- a/segment.go +++ b/segment.go @@ -168,9 +168,11 @@ func (seg *segment) Close() error { if seg.closed { return nil } - + if err := seg.fd.Close(); err != nil { + return err + } seg.closed = true - return seg.fd.Close() + return nil } // Size returns the size of the segment file. From 7eee3b84ec224c07e4ed38390ed16593e81ab19e Mon Sep 17 00:00:00 2001 From: Nemo <306250675@qq.com> Date: Sat, 26 Apr 2025 23:14:58 +0800 Subject: [PATCH 4/5] Modify the description of the openSegmentFile function --- segment.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/segment.go b/segment.go index a478e2b..3f212dc 100644 --- a/segment.go +++ b/segment.go @@ -100,7 +100,7 @@ func putBuffer(buf []byte) { blockPool.Put(buf) } -// openSegmentFile a new segment file. +// openSegmentFile a segment file. func openSegmentFile(dirPath, extName string, id uint32) (*segment, error) { fd, err := os.OpenFile( SegmentFileName(dirPath, extName, id), From 1d7ad7e1c2ddcce387a9b6f853a5b16afd47a31e Mon Sep 17 00:00:00 2001 From: Nemo <306250675@qq.com> Date: Sat, 26 Apr 2025 23:26:40 +0800 Subject: [PATCH 5/5] Modify the description of the openSegmentFile function --- segment.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/segment.go b/segment.go index 3f212dc..18e271c 100644 --- a/segment.go +++ b/segment.go @@ -100,7 +100,7 @@ func putBuffer(buf []byte) { blockPool.Put(buf) } -// openSegmentFile a segment file. +// openSegmentFile open a segment file. func openSegmentFile(dirPath, extName string, id uint32) (*segment, error) { fd, err := os.OpenFile( SegmentFileName(dirPath, extName, id),