From 93e2fa44a6af513b0692797de793b11b1e10bcd1 Mon Sep 17 00:00:00 2001 From: mpadge Date: Mon, 30 Jun 2025 09:22:00 +0200 Subject: [PATCH 1/8] update editor offboarding instructions --- softwarereview_editor_management.Rmd | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/softwarereview_editor_management.Rmd b/softwarereview_editor_management.Rmd index d88ae8091..c8feff26d 100644 --- a/softwarereview_editor_management.Rmd +++ b/softwarereview_editor_management.Rmd @@ -86,21 +86,21 @@ Best, - Thank them for their work! +- Inform rOpenSci community manager or other staff emembers. + - Remove them from the editors-only channel and the editors Slack team. - Remove them from [https://github.com/orgs/ropensci/teams/editors/members](https://github.com/orgs/ropensci/teams/editors/members) and sub-team. -- Inform rOpenSci community manager or some other staff emember so that they might be moved to alumni team members on the website. +- Update ["team.json" on website](https://github.com/ropensci/roweb3/blob/main/data/team/team.json) by replacing "roles" with "past_roles", and adding new field, `alumnus: "true"`. - Remove their access to the Airtable workspace. -- Remove them from - - - [dev\_guide chapter introducing software review](https://github.com/ropensci/dev_guide/blob/main/softwarereview_intro.Rmd) (at two locations in this file, as editors and a bit below to remove them from the reviewers list) - - [software-review README](https://github.com/ropensci/software-review/blob/main/README.Rmd) (in two places in this file as well) - -Both the dev\_guide and software-review README are automatically knit via continuous integration. +- \[---@maelle to detail removal from Airtable editors table---\] +- The (past-)editors lists in both the [dev\_guide chapter introducing software review](https://github.com/ropensci/dev_guide/blob/main/softwarereview_intro.Rmd) and the [software-review README](https://github.com/ropensci/software-review/blob/main/README.Rmd) are automatically populated from the AirTable data. + Updates are run daily, so check a day after AirTable updates to ensure both have been updated. + ## Putting the system on pause {#vacation} If you want to put the system on a break for instance over the holidays, before leaving: From a8fa3f1cda5a9fc9df4401bb54885de356a7cd1a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ma=C3=ABlle=20Salmon?= Date: Wed, 9 Jul 2025 16:41:06 +0200 Subject: [PATCH 2/8] fix author metadata --- _quarto.yml | 4 ++-- softwarereview_editor_management.Rmd | 11 ++--------- 2 files changed, 4 insertions(+), 11 deletions(-) diff --git a/_quarto.yml b/_quarto.yml index bd38ec23f..4963d7aea 100644 --- a/_quarto.yml +++ b/_quarto.yml @@ -3,7 +3,7 @@ project: title-es: "Paquetes de rOpenSci: Desarrollo, mantenimiento y revisión por pares" -author-es: "Equipo editorial para la revisión de software de rOpenSci (actuales y pasados): Brooke Anderson, Scott Chamberlain, Laura DeCicco, Julia Gustavsen, Jeff Hollister, Anna Krystalli, Mauro Lepore, Lincoln Mullen, Mark Padgham, Karthik Ram, Emily Riederer, Noam Ross, Maëlle Salmon, Adam Sparks, Melina Vidoni" +author-es: "Equipo editorial para la revisión de software de rOpenSci (actuales y pasados)" description-es: | Guía para autoras/es de paquetes, encargadas/os, revisoras/es y editoras/es en el sistema de revisión por pares de rOpenSci. @@ -21,7 +21,7 @@ description-es: | book: favicon: images/apple-touch-icon.png title: "rOpenSci Packages: Development, Maintenance, and Peer Review" - author: "rOpenSci software review editorial team (current and alumni): Brooke Anderson, Scott Chamberlain, Laura DeCicco, Julia Gustavsen, Jeff Hollister, Anna Krystalli, Mauro Lepore, Lincoln Mullen, Mark Padgham, Karthik Ram, Emily Riederer, Noam Ross, Maëlle Salmon, Adam Sparks, Melina Vidoni" + author: "rOpenSci software review editorial team (current and alumni)" description: | Guide for package authors, maintainers, reviewers and editors in rOpenSci software peer-review system. diff --git a/softwarereview_editor_management.Rmd b/softwarereview_editor_management.Rmd index a2af9b38a..0c040a50a 100644 --- a/softwarereview_editor_management.Rmd +++ b/softwarereview_editor_management.Rmd @@ -75,10 +75,8 @@ Best, - We add editors' names to - - [dev\_guide authors list](https://github.com/ropensci/dev_guide/blob/main/index.Rmd) - - [dev\_guide chapter introducing software review](https://github.com/ropensci/dev_guide/blob/main/softwarereview_intro.Rmd) (at two locations in this file, as editors and a bit below to remove them from the reviewers list) - - [software-review README](https://github.com/ropensci/software-review/blob/main/README.Rmd) (in two places in this file as well) - Both the dev\_guide and software-review README are automatically knit via continuous integration. + - [dev\_guide's Zenodo file](https://github.com/ropensci/dev_guide/blob/main/.zenodo.json) + - Airtable. - Add editors to [https://github.com/orgs/ropensci/teams/editors/members](https://github.com/orgs/ropensci/teams/editors/members) @@ -94,11 +92,6 @@ Best, - Remove their access to the Airtable workspace. -- Remove them from - - - [dev\_guide chapter introducing software review](https://github.com/ropensci/dev_guide/blob/main/softwarereview_intro.Rmd) (at two locations in this file, as editors and a bit below to remove them from the reviewers list) - - [software-review README](https://github.com/ropensci/software-review/blob/main/README.Rmd) (in two places in this file as well) - Both the dev\_guide and software-review README are automatically knit via continuous integration. ## Putting the system on pause {#vacation} From cbbb2c013eb967f3899d1648b0f9cdf5935e467d Mon Sep 17 00:00:00 2001 From: mpadge Date: Tue, 10 Feb 2026 12:53:37 +0100 Subject: [PATCH 3/8] resinstate some former changes --- softwarereview_editor_management.Rmd | 24 +++++++++++------------- 1 file changed, 11 insertions(+), 13 deletions(-) diff --git a/softwarereview_editor_management.Rmd b/softwarereview_editor_management.Rmd index 70f368a63..7e99ebe3d 100644 --- a/softwarereview_editor_management.Rmd +++ b/softwarereview_editor_management.Rmd @@ -53,30 +53,28 @@ Best, ## Onboarding a new editor {#onboarding-a-new-editor} -- Inform rOpenSci community manager so that - - - The new editor is added to the [rOpenSci website](https://github.com/ropensci/roweb3/#team-member). - - An introductory blog post can be put together. +- Add to ["team.json" file of website](https://github.com/ropensci/roweb3/blob/main/data/team/team.json) with `"editor": true`, and also `"stats": true` for stats editors. + That will automatically add new editors to the editorial team shown on the [rOpenSci website](https://ropensci.org/software-review/). + +- Inform rOpenSci community manager so that an introductory blog post can be put together. - If they haven't already done so as guest editors, request that the new editor turn on [two-factor authentication (2FA) for GitHub](https://docs.github.com/en/authentication/securing-your-account-with-two-factor-authentication-2fa). - Invite them to the rOpenSci GitHub organization as member, as a member of the [`editors` team](https://github.com/orgs/ropensci/teams/editors) and the [`data-pkg-editors`](https://github.com/orgs/ropensci/teams/data-pkg-editors) or [`stats-board`](https://github.com/orgs/ropensci/teams/stats-board) sub-team, as appropriate. This will give them appropriate permissions and allow them to get team-specific notifications. -- Editors need access to the AirTable database of software review (linked in the description of the editors-only channel on Slack). +- Invite them to the AirTable database of software review (linked in the description of the editors-only channel on Slack). -- Editors need access to the private editors channel in rOpenSci Slack workspace (and to the Slack workspace in general if they didn't previously, in that case ask rOpenSci community manager). +- Invite them to the private "editors-only" channel in rOpenSci's Slack workspace (and to the Slack workspace in general if they're not yet there). -- Post a welcome message in the channel, pinging all editors. - -- In the Slack workspace they need to be added to the editors team so that `@editors` will ping them too. +- Once they're in the "editors-only" channel, post a welcome message pinging all editors. - We add editors' names to - - [dev\_guide's Zenodo file](https://github.com/ropensci/dev_guide/blob/main/.zenodo.json) - - Airtable. - -- Add editors to [https://github.com/orgs/ropensci/teams/editors/members](https://github.com/orgs/ropensci/teams/editors/members) + - [dev\_guide authors list](https://github.com/ropensci/dev_guide/blob/main/index.Rmd) + - [dev\_guide chapter introducing software review](https://github.com/ropensci/dev_guide/blob/main/softwarereview_intro.Rmd) (at two locations in this file, as editors and a bit below to remove them from the reviewers list) + - [software-review README](https://github.com/ropensci/software-review/blob/main/README.Rmd) (in two places in this file as well) + Both the dev\_guide and software-review README are automatically knit via continuous integration. ## Offboarding an editor {#offboarding-an-editor} From 91d7e908198c05adff94f1d06e11a1d9066a3ddd Mon Sep 17 00:00:00 2001 From: mpadge Date: Tue, 10 Feb 2026 13:10:00 +0100 Subject: [PATCH 4/8] rm obsolete ed onboarding stuff for #982 --- softwarereview_editor_management.Rmd | 11 ++--------- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/softwarereview_editor_management.Rmd b/softwarereview_editor_management.Rmd index 7e99ebe3d..265408b02 100644 --- a/softwarereview_editor_management.Rmd +++ b/softwarereview_editor_management.Rmd @@ -60,8 +60,8 @@ Best, - If they haven't already done so as guest editors, request that the new editor turn on [two-factor authentication (2FA) for GitHub](https://docs.github.com/en/authentication/securing-your-account-with-two-factor-authentication-2fa). -- Invite them to the rOpenSci GitHub organization as member, as a member of the [`editors` team](https://github.com/orgs/ropensci/teams/editors) and the [`data-pkg-editors`](https://github.com/orgs/ropensci/teams/data-pkg-editors) or [`stats-board`](https://github.com/orgs/ropensci/teams/stats-board) sub-team, as appropriate. - This will give them appropriate permissions and allow them to get team-specific notifications. +- Invite them to the rOpenSci GitHub organization as member, as a member of the [`editors` team](https://github.com/orgs/ropensci/teams/editors), and also [`stats-editors`](https://github.com/orgs/ropensci/teams/stats-editors) team for stats editors. + This will give them appropriate permissions, and ensure that they appear in [the editors dashboard](https://dashboard.ropensci.org/editors). - Invite them to the AirTable database of software review (linked in the description of the editors-only channel on Slack). @@ -69,13 +69,6 @@ Best, - Once they're in the "editors-only" channel, post a welcome message pinging all editors. -- We add editors' names to - - - [dev\_guide authors list](https://github.com/ropensci/dev_guide/blob/main/index.Rmd) - - [dev\_guide chapter introducing software review](https://github.com/ropensci/dev_guide/blob/main/softwarereview_intro.Rmd) (at two locations in this file, as editors and a bit below to remove them from the reviewers list) - - [software-review README](https://github.com/ropensci/software-review/blob/main/README.Rmd) (in two places in this file as well) - Both the dev\_guide and software-review README are automatically knit via continuous integration. - ## Offboarding an editor {#offboarding-an-editor} - Thank them for their work! From bdb5ae465ceb7244b2a95e41e5b2fae6da10f582 Mon Sep 17 00:00:00 2001 From: mpadge Date: Tue, 10 Feb 2026 13:19:57 +0100 Subject: [PATCH 5/8] add details on airtable editor offboarding to close #982 --- softwarereview_editor_management.Rmd | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/softwarereview_editor_management.Rmd b/softwarereview_editor_management.Rmd index 265408b02..2610bf2f3 100644 --- a/softwarereview_editor_management.Rmd +++ b/softwarereview_editor_management.Rmd @@ -82,8 +82,9 @@ Best, - Update ["team.json" on website](https://github.com/ropensci/roweb3/blob/main/data/team/team.json) by replacing "roles" with "past_roles", and adding new field, `alumnus: "true"`. - Remove their access to the Airtable workspace. - -- \[---@maelle to detail removal from Airtable editors table---\] + - From the "interface" view, pull down main menu at top-left and enter "View Data" + - Click "Share" button on top right, and then "People with access" + - Click checkbox on left on editor to be removed, and "Remove 1 collaborator". - The (past-)editors lists in both the [dev\_guide chapter introducing software review](https://github.com/ropensci/dev_guide/blob/main/softwarereview_intro.Rmd) and the [software-review README](https://github.com/ropensci/software-review/blob/main/README.Rmd) are automatically populated from the AirTable data. Updates are run daily, so check a day after AirTable updates to ensure both have been updated. From 1419b9aa77462ab7089f275e38e3ac3af8bd17d0 Mon Sep 17 00:00:00 2001 From: mark padgham Date: Tue, 10 Feb 2026 13:41:27 +0000 Subject: [PATCH 6/8] Update softwarereview_editor_management.Rmd MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-authored-by: Maëlle Salmon --- softwarereview_editor_management.Rmd | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/softwarereview_editor_management.Rmd b/softwarereview_editor_management.Rmd index 2610bf2f3..f3115ac01 100644 --- a/softwarereview_editor_management.Rmd +++ b/softwarereview_editor_management.Rmd @@ -73,7 +73,7 @@ Best, - Thank them for their work! -- Inform rOpenSci community manager or other staff emembers. +- Inform rOpenSci community manager or other staff members. - Remove them from the editors-only channel and the editors Slack team. From c9c2d7ab108fa5344a49b3ec2c8aeae035368f2a Mon Sep 17 00:00:00 2001 From: mark padgham Date: Tue, 10 Feb 2026 13:42:31 +0000 Subject: [PATCH 7/8] Update softwarereview_editor_management.Rmd MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-authored-by: Maëlle Salmon --- softwarereview_editor_management.Rmd | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/softwarereview_editor_management.Rmd b/softwarereview_editor_management.Rmd index f3115ac01..0fc2c067c 100644 --- a/softwarereview_editor_management.Rmd +++ b/softwarereview_editor_management.Rmd @@ -75,7 +75,7 @@ Best, - Inform rOpenSci community manager or other staff members. -- Remove them from the editors-only channel and the editors Slack team. +- Remove them from the "editors-only" channel and the editors Slack team. - Remove them from [https://github.com/orgs/ropensci/teams/editors/members](https://github.com/orgs/ropensci/teams/editors/members) and sub-team. From d78132d8f3743cc0bfec026fb639138aad3b277a Mon Sep 17 00:00:00 2001 From: mpadge Date: Tue, 10 Feb 2026 14:46:00 +0100 Subject: [PATCH 8/8] editors slack read only for #982 --- softwarereview_editor_management.Rmd | 1 + 1 file changed, 1 insertion(+) diff --git a/softwarereview_editor_management.Rmd b/softwarereview_editor_management.Rmd index 0fc2c067c..4d2101281 100644 --- a/softwarereview_editor_management.Rmd +++ b/softwarereview_editor_management.Rmd @@ -64,6 +64,7 @@ Best, This will give them appropriate permissions, and ensure that they appear in [the editors dashboard](https://dashboard.ropensci.org/editors). - Invite them to the AirTable database of software review (linked in the description of the editors-only channel on Slack). + Ensure invitation is "Read only". - Invite them to the private "editors-only" channel in rOpenSci's Slack workspace (and to the Slack workspace in general if they're not yet there).