-
Notifications
You must be signed in to change notification settings - Fork 0
Open
Description
Problem
resolve_run_arg (used by cmd_diff) resolves tags via load_tagged_run, which only loads the consolidated JSON Run struct — it never checks for NDJSON data. This means piano diff <tag_a> <tag_b> produces output from diff_runs using JSON-only data.
Currently this is not a visible problem because diff_runs only uses Run-level aggregates (calls, total, self). But if diff_runs ever gains NDJSON-aware columns (percentiles, allocation deltas), the diff output for tagged runs would silently show degraded data.
Location
src/main.rs—resolve_run_argat line 533- The same
resolve_tag+find_ndjson_by_run_idpattern from PR Fix tagged report dropping percentile and allocation columns #91 could be applied here
Suggested approach
Apply the same pattern used in cmd_report: resolve the tag to a run_id, check for NDJSON, and load frame data when available. This would future-proof cmd_diff for NDJSON-aware diff formatting.
Context
Discovered during code review of PR #91.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels