-
Notifications
You must be signed in to change notification settings - Fork 0
Open
Labels
enhancementNew feature or requestNew feature or request
Milestone
Description
Current Behavior
Three minor code quality issues identified during v0.4.0 pre-release review:
tempfileis listed in[dependencies]but only used in#[cfg(test)]modules- Provably-safe
.unwrap()calls lackexpect("reason")documentation of their invariants notifycrate only enablesmacos_fseventfeature -- file watching silently degrades to no-op on Linux/Windows
Expected Behavior
tempfileshould be in[dev-dependencies]to avoid shipping it in production builds- Invariant-dependent
.unwrap()calls should useexpect()so violated assumptions produce clear messages - Cross-platform file watching behavior should be documented or addressed with platform-specific features
Context
Identified during v0.4.0 pre-release code review. None are correctness issues -- the code handles all three gracefully. These are maintainability and packaging improvements.
Technical Details
Relevant Code
Cargo.toml:35
tempfile = "3" # only used in #[cfg(test)] blocksCargo.toml:38
notify = { version = "7", default-features = false, features = ["macos_fsevent"] }Bare .unwrap() instances in production code: cache.rs:193-198, session.rs:204,236,451, walker.rs:122,142, query.rs:571, main.rs:484, repl.rs:692,730
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or request