Docker image

[IanTrudel]

The Docker image hasn't been updated in two years. See https://hub.docker.com/r/redhogorg/glass/tags.

• Add a GitHub action to push the docker image onto the registry. (@redhog)
• Restructure Docker images
  • Use docker-compose.
  • Create a dockerfiles directory to hold all the dockerfiles.

Links

• Publishing Docker images

[redhog]

Yep, it needs rebuilding w latest version!

[redhog]

I don't use it myself, so it doesn't get properly tested :S

[IanTrudel]

I also attempted to build the image using Docker and Podman. No luck either. Something seems wrong because it doesn't contain the proper files (the script directory and dependencies.txt are missing, for example). Running with Podman, a Docker replacement, will require an extra parameter (--security-opt label=type:container_runtime_t). See https://major.io/2021/10/17/run-xorg-applications-with-podman/

To be noted, Docker is sort-of deprecated by Kubernetes in favour of OCI compliant tools, such as Podman and Buildah.

[IanTrudel]

#89 (comment)

I have bugfixed run in docker! Pull the newest version, make sure to delete any old docker image and container and try run it!

The good news is that it is finally built properly on podman with all the required files. Unfortunately, Xephyr fails to connect to the display. DISPLAY is set to :0 by default in scripts/run-in-docker.sh but should be set to $DISPLAY (or simply -e DISPLAY). For example, mine is :1.

xauth should also use $DISPLAY, see here.

I also added xhost + at line 4 see here, otherwise resulting in Authorization required, but no authorization protocol specified. InfiniteGlass should not run as root though. The Linux community is slowly moving away from such practices, and more, e.g. you cannot log in locally on a GNOME session if you are also connected through VNC. Lots of nonsense going on.

Xephyr opens, and InfiniteGlass is engaging. Now getting a whole new set of issues that I hadn't encountered before.

Take note that I am running podman instead of docker. The packages are incompatibles and testing on both is troublesome. I gave a few rounds to docker but had no success. Both Arch and Rocky Linux favours podman over docker.

_XSERVTransmkdir: Owner of /tmp/.X11-unix should be set to root
xinit: XFree86_VT property unexpectedly has 0 items instead of 1
Copying 1
Traceback (most recent call last):
  File "/InfiniteGlass/build/env/bin/glass-config-init", line 11, in <module>
    load_entry_point('glass-config-init', 'console_scripts', 'glass-config-init')()
  File "/InfiniteGlass/glass-config-init/glass_config_init/__init__.py", line 29, in main
    copy_dir(
  File "/InfiniteGlass/glass-config-init/glass_config_init/__init__.py", line 24, in copy_dir
    with open(dstpath, "wb") as outf:
PermissionError: [Errno 13] Permission denied: '/home/glass/.config/glass/ghosts.yml'
Xlib.xauth: warning, failed to parse part of xauthority file /tmp/.docker.xauth, aborting all further parsing
Xlib.xauth: warning, no xauthority details available
Ghost manager systemic failure, restarting: [Errno 2] No such file or directory: '/home/glass/.config/glass/ghosts.yml'
Traceback (most recent call last):
  File "/InfiniteGlass/glass-ghosts/glass_ghosts/main.py", line 47, in main
    InfiniteGlass.DEBUG("init", "Session manager listening to %s\n" % manager.session.listen_address())
  File "/InfiniteGlass/glass-lib/InfiniteGlass/display.py", line 114, in display_exit
    raise exc
  File "/InfiniteGlass/glass-ghosts/glass_ghosts/main.py", line 44, in main
    manager = glass_ghosts.manager.GhostManager(display)
  File "/InfiniteGlass/glass-ghosts/glass_ghosts/manager.py", line 22, in __init__
    with open(configpath) as f:
FileNotFoundError: [Errno 2] No such file or directory: '/home/glass/.config/glass/ghosts.yml'
Xlib.xauth: warning, failed to parse part of xauthority file /tmp/.docker.xauth, aborting all further parsing
Xlib.xauth: warning, no xauthority details available
Ghost manager systemic failure, restarting: [Errno 2] No such file or directory: '/home/glass/.config/glass/ghosts.yml'
Traceback (most recent call last):
  File "/InfiniteGlass/glass-ghosts/glass_ghosts/main.py", line 47, in main
    InfiniteGlass.DEBUG("init", "Session manager listening to %s\n" % manager.session.listen_address())
  File "/InfiniteGlass/glass-lib/InfiniteGlass/display.py", line 114, in display_exit
    raise exc
  File "/InfiniteGlass/glass-ghosts/glass_ghosts/main.py", line 44, in main
    manager = glass_ghosts.manager.GhostManager(display)
  File "/InfiniteGlass/glass-ghosts/glass_ghosts/manager.py", line 22, in __init__
    with open(configpath) as f:
FileNotFoundError: [Errno 2] No such file or directory: '/home/glass/.config/glass/ghosts.yml'
Xlib.xauth: warning, failed to parse part of xauthority file /tmp/.docker.xauth, aborting all further parsing
Xlib.xauth: warning, no xauthority details available
Ghost manager systemic failure, restarting: [Errno 2] No such file or directory: '/home/glass/.config/glass/ghosts.yml'
Traceback (most recent call last):
  File "/InfiniteGlass/glass-ghosts/glass_ghosts/main.py", line 47, in main
    InfiniteGlass.DEBUG("init", "Session manager listening to %s\n" % manager.session.listen_address())
  File "/InfiniteGlass/glass-lib/InfiniteGlass/display.py", line 114, in display_exit
    raise exc
  File "/InfiniteGlass/glass-ghosts/glass_ghosts/main.py", line 44, in main
    manager = glass_ghosts.manager.GhostManager(display)
  File "/InfiniteGlass/glass-ghosts/glass_ghosts/manager.py", line 22, in __init__
    with open(configpath) as f:
FileNotFoundError: [Errno 2] No such file or directory: '/home/glass/.config/glass/ghosts.yml'
Xlib.xauth: warning, failed to parse part of xauthority file /tmp/.docker.xauth, aborting all further parsing
Xlib.xauth: warning, no xauthority details available
Ghost manager systemic failure, restarting: [Errno 2] No such file or directory: '/home/glass/.config/glass/ghosts.yml'
Traceback (most recent call last):
  File "/InfiniteGlass/glass-ghosts/glass_ghosts/main.py", line 47, in main
    InfiniteGlass.DEBUG("init", "Session manager listening to %s\n" % manager.session.listen_address())
  File "/InfiniteGlass/glass-lib/InfiniteGlass/display.py", line 114, in display_exit
    raise exc
  File "/InfiniteGlass/glass-ghosts/glass_ghosts/main.py", line 44, in main
    manager = glass_ghosts.manager.GhostManager(display)
  File "/InfiniteGlass/glass-ghosts/glass_ghosts/manager.py", line 22, in __init__
    with open(configpath) as f:
FileNotFoundError: [Errno 2] No such file or directory: '/home/glass/.config/glass/ghosts.yml'
^R
Xlib.xauth: warning, failed to parse part of xauthority file /tmp/.docker.xauth, aborting all further parsing
Xlib.xauth: warning, no xauthority details available

[redhog]

$DISPLAY handling correction pushed

[redhog]

PermissionError: [Errno 13] Permission denied: '/home/glass/.config/glass/ghosts.yml'

is really curious to me. This is inside the container, in a path on the container disk, not a mount, so this must be Podmans' doing, as it works under docker for me...

As for xhost + you should not need that, if the Xauthority actually parses. I think this is just a follow up error to the assumption that DISPLAY is :0. Try it w my new fix and see if that solves this.

IG does not run as root, see the su to user glass here: https://github.com/redhog/InfiniteGlass/blob/master/scripts/docker-runner.sh#L5 Only the shellscript runs as root at first, to be able to get the ip number of the machine and update /etc/hosts

[IanTrudel]

PermissionError: [Errno 13] Permission denied: '/home/glass/.config/glass/ghosts.yml'

is really curious to me. This is inside the container, in a path on the container disk, not a mount, so this must be Podmans' doing, as it works under docker for me...

Curious, indeed! I even attempted to set the volume as rw (and also Z) to make sure. I will do some tests with a simple container and see if anything interesting comes out.

As for xhost + you should not need that, if the Xauthority actually parses. I think this is just a follow up error to the assumption that DISPLAY is :0. Try it w my new fix and see if that solves this.

An improvement for sure. You were correct about xhost + and Xephyr opens up as expected.

IG does not run as root, see the su to user glass here: https://github.com/redhog/InfiniteGlass/blob/master/scripts/docker-runner.sh#L5 Only the shellscript runs as root at first, to be able to get the ip number of the machine and update /etc/hosts

This might be so but there are a few conflicting things, such as docker is run with --user id -u root and Python packages are installed as root, for which pip complains about. Those would be small things but it seems that more and more Linux software implements security features, for the best or for the worst.

My apologies for giving you such a stress test for InfiniteGlass. I am however willing to test whatever you ask me to. You should perhaps also consider giving a try to Arch Linux on a virtual machine and see if you can get InfiniteGlass working.

[IanTrudel]

The files in /home/glass/.config/, notice that glass is not owned by glass:users!

drwxr-xr-x 1 glass users  6 Aug  1 22:45 dconf
drwxr-xr-x 2 root  root  26 Aug  1 23:23 glass
drwxr-xr-x 1 glass users  6 Aug  1 22:45 session-state

[redhog]

Wait, /home isn't volume / mount?

Could you try to run this with docker using the makefile? As in make run-in-docker and compare?

I could pip install in a virtualenv, but this then does not simulate installing globally, as in, how it would have to work if it was your real desktop, and I like the docker image to test this functionality too...

[redhog]

It is awesome that you test stuff properly. I can try a VM with Arch :)

I'd just like for you to run things with docker the exact same way as me once and get that working so we have a baseline to compare to. Then we can see what differs from that...

[redhog]

Re not as root:

Docker does not set the real ip of the container as the ip for the hostname in /etc/hosts but we need that for X to work correctly.

So I do: echo "$(ip -4 addr show docker0 | grep -Po 'inet \K[\d.]+') $(hostname)" >> /etc/hosts

Which requires root. How can you get around that?

[IanTrudel]

Which requires root. How can you get around that?

We should consider using sudo for now. I have been reading the security and networking in rootless containers for podman but it's a long read. Alternatively, the value could be passed on docker run as environment variables.

Could you try to run this with docker using the makefile? As in make run-in-docker and compare?

I am using make run-in-docker!

I could pip install in a virtualenv, but this then does not simulate installing globally, as in, how it would have to work if it was your real desktop, and I like the docker image to test this functionality too...

This is an important question as to what kind of behaviour InfiniteGlass should have on a system installation. We should perhaps consider creating a shell-less (InfiniteGlass) glass user that would host the WM and add every user who has access to it to its group, thus allowing them to start InfiniteGlass in their session. Not anything unheard of, right?

Some interesting notes here: Do not run pip as root and pip safe.

[redhog]

Regarding the installation first: IG should install the same way other desktops or window managers install, that is, so that it is runnable by any user of the system. It should not run with other privileges than that user (having programs running as different users in the same X session is unsafe, and should really only be done if one of the two users is root). The python packages could still be installed in a virtualenv rather than globally, but for a package that itself is installed globally, this is wierd. However, this might be necessary, as not all python deps might exist as debian/rpm/whatever packages (this needs investigating when this is properly packaged). But regardless, they need to be installed so that any user can get to them. That means running pip as root, or changing the owner of the virtualenv after the fact to root.