Skip to content

Commit f85a777

Browse files
christophpurrermeta-codesync[bot]
authored andcommitted
Fix UBSan float-cast-overflow in BridgingTest.numberTest (#56693)
Summary: Pull Request resolved: #56693 Changelog: [Internal] - Remove UB-relying assertion from BridgingTest.numberTest Reviewed By: shwanton Differential Revision: D103954447 fbshipit-source-id: d97205a7646f7c7b1306f22b368573423c38494d
1 parent 7ae9b66 commit f85a777

1 file changed

Lines changed: 0 additions & 5 deletions

File tree

packages/react-native/ReactCommon/react/bridging/tests/BridgingTest.cpp

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -69,11 +69,6 @@ TEST_F(BridgingTest, numberTest) {
6969
-42,
7070
static_cast<uint32_t>(
7171
bridging::toJs(rt, static_cast<uint32_t>(-42)).asNumber()));
72-
73-
EXPECT_FALSE(
74-
-42 ==
75-
static_cast<int32_t>(
76-
bridging::toJs(rt, static_cast<uint32_t>(-42)).asNumber()));
7772
}
7873

7974
TEST_F(BridgingTest, stringTest) {

0 commit comments

Comments
 (0)