Skip to content

Commit f596bb3

Browse files
marcoww6meta-codesync[bot]
authored andcommitted
transformTypeParamBound codemod 8/9 (#55949)
Summary: Pull Request resolved: #55949 js1 flow-runner codemod flow/transformTypeParamBound --format-files=false xplat/js Changelog: [Internal] Reviewed By: SamChou19815 Differential Revision: D95429359 fbshipit-source-id: fc5bfa68cd5267ec5e74358592eace97c9a6f662
1 parent d8820a4 commit f596bb3

63 files changed

Lines changed: 263 additions & 222 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

packages/dev-middleware/src/__tests__/FetchUtils.js

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,9 @@ export async function requestLocal(
4848
};
4949
}
5050

51-
export async function fetchJson<T: JSONSerializable>(url: string): Promise<T> {
51+
export async function fetchJson<T extends JSONSerializable>(
52+
url: string,
53+
): Promise<T> {
5254
const response = await requestLocal(url);
5355
if (response.statusCode !== 200) {
5456
throw new Error(`HTTP ${response.statusCode}`);

packages/dev-middleware/src/__tests__/InspectorDeviceUtils.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -142,7 +142,7 @@ export class DeviceMock extends DeviceAgent {
142142
}
143143
}
144144

145-
#sendPayloadIfNonNull<Event: MessageFromDevice['event']>(
145+
#sendPayloadIfNonNull<Event extends MessageFromDevice['event']>(
146146
event: Event,
147147
maybePayload:
148148
| MessageFromDevice['payload']

packages/dev-middleware/src/__tests__/InspectorProtocolUtils.js

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,9 @@ export type CdpMessageToTarget = Readonly<{
4242
* Send a CDP message from from the target with the given pageId to the debugger.
4343
* Returns the message as received by the debugger.
4444
*/
45-
export async function sendFromTargetToDebugger<Message: CdpMessageFromTarget>(
45+
export async function sendFromTargetToDebugger<
46+
Message extends CdpMessageFromTarget,
47+
>(
4648
device: DeviceMock,
4749
debugger_: DebuggerMock,
4850
pageId: string,
@@ -76,7 +78,9 @@ export async function sendFromTargetToDebugger<Message: CdpMessageFromTarget>(
7678
* Send a CDP message from the debugger to the target with the given pageId.
7779
* Returns the message as received by the target.
7880
*/
79-
export async function sendFromDebuggerToTarget<Message: CdpMessageToTarget>(
81+
export async function sendFromDebuggerToTarget<
82+
Message extends CdpMessageToTarget,
83+
>(
8084
debugger_: DebuggerMock,
8185
device: DeviceMock,
8286
pageId: string,

packages/dev-middleware/src/inspector-proxy/cdp-types/messages.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,18 +12,18 @@ import type {JSONSerializable} from '../types';
1212
import type {Commands, Events} from './protocol';
1313

1414
// Note: A CDP event is a JSON-RPC notification with no `id` member.
15-
export type CDPEvent<TEvent: keyof Events = 'unknown'> = {
15+
export type CDPEvent<TEvent extends keyof Events = 'unknown'> = {
1616
method: TEvent,
1717
params: Events[TEvent],
1818
};
1919

20-
export type CDPRequest<TCommand: keyof Commands = 'unknown'> = {
20+
export type CDPRequest<TCommand extends keyof Commands = 'unknown'> = {
2121
method: TCommand,
2222
params: Commands[TCommand]['paramsType'],
2323
id: number,
2424
};
2525

26-
export type CDPResponse<TCommand: keyof Commands = 'unknown'> =
26+
export type CDPResponse<TCommand extends keyof Commands = 'unknown'> =
2727
| {
2828
result: Commands[TCommand]['resultType'],
2929
id: number,

packages/dev-middleware/src/types/EventReporter.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,18 +10,18 @@
1010

1111
import type {DebuggerShellPreparationResult} from './DevToolLauncher';
1212

13-
type SuccessResult<Props: {...} | void = {}> = {
13+
type SuccessResult<Props extends {...} | void = {}> = {
1414
status: 'success',
1515
...Props,
1616
};
1717

18-
type ErrorResult<ErrorT = unknown, Props: {...} | void = {}> = {
18+
type ErrorResult<ErrorT = unknown, Props extends {...} | void = {}> = {
1919
status: 'error',
2020
error: ErrorT,
2121
...Props,
2222
};
2323

24-
type CodedErrorResult<ErrorCode: string> = {
24+
type CodedErrorResult<ErrorCode extends string> = {
2525
status: 'coded_error',
2626
errorCode: ErrorCode,
2727
errorDetails?: string,

packages/jest-preset/jest/mock.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
* If `factoryRef` is provided, it is expected to reference a module that
1717
* exports the same type signature as the module referenced by `moduleRef`.
1818
*/
19-
export default function mock<TModuleRef: $Flow$ModuleRef<unknown>>(
19+
export default function mock<TModuleRef extends $Flow$ModuleRef<unknown>>(
2020
moduleRef: TModuleRef,
2121
factoryRef?: NoInfer<TModuleRef>,
2222
): void {

packages/jest-preset/jest/mockComponent.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,8 @@ type TComponentType = React.ComponentType<{...}>;
2121
* a major footgun. Be careful when using this function!
2222
*/
2323
export default function mockComponent<
24-
TComponentModule: Modulish<TComponentType>,
25-
TIsESModule: boolean,
24+
TComponentModule extends Modulish<TComponentType>,
25+
TIsESModule extends boolean,
2626
>(
2727
moduleName: string,
2828
instanceMethods: ?interface {},

packages/jest-preset/jest/mockNativeComponent.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,12 +15,12 @@ import {createElement} from 'react';
1515

1616
let nativeTag = 1;
1717

18-
type MockNativeComponent<TProps: {...}> = component(
18+
type MockNativeComponent<TProps extends {...}> = component(
1919
ref?: ?React.RefSetter<HostInstance>,
2020
...props: TProps
2121
);
2222

23-
export default function mockNativeComponent<TProps: {...}>(
23+
export default function mockNativeComponent<TProps extends {...}>(
2424
viewName: string,
2525
): MockNativeComponent<TProps> {
2626
const Component = class extends React.Component<TProps> {

packages/jest-preset/jest/mocks/requireNativeComponent.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ const mockNativeComponent = jest.requireActual<TmockNativeComponent>(
1515
'../mockNativeComponent',
1616
).default;
1717

18-
export default function requireNativeComponent<T: {...}>(
18+
export default function requireNativeComponent<T extends {...}>(
1919
uiViewClassName: string,
2020
): HostComponent<T> {
2121
return mockNativeComponent<T>(uiViewClassName);

packages/polyfills/error-guard.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ const ErrorUtils = {
5252
* Condition roll out. See https://fburl.com/workplace/1v97vimq. */
5353
_globalHandler && _globalHandler(error, true);
5454
},
55-
applyWithGuard<TArgs: ReadonlyArray<unknown>, TOut>(
55+
applyWithGuard<TArgs extends ReadonlyArray<unknown>, TOut>(
5656
fun: Fn<TArgs, TOut>,
5757
context?: ?unknown,
5858
args?: ?TArgs,
@@ -75,7 +75,7 @@ const ErrorUtils = {
7575
}
7676
return null;
7777
},
78-
applyWithGuardIfNeeded<TArgs: ReadonlyArray<unknown>, TOut>(
78+
applyWithGuardIfNeeded<TArgs extends ReadonlyArray<unknown>, TOut>(
7979
fun: Fn<TArgs, TOut>,
8080
context?: ?unknown,
8181
args?: ?TArgs,
@@ -94,7 +94,7 @@ const ErrorUtils = {
9494
inGuard(): boolean {
9595
return !!_inGuard;
9696
},
97-
guard<TArgs: ReadonlyArray<unknown>, TOut>(
97+
guard<TArgs extends ReadonlyArray<unknown>, TOut>(
9898
fun: Fn<TArgs, TOut>,
9999
name?: ?string,
100100
context?: ?unknown,

0 commit comments

Comments
 (0)