Fix Activity Result launcher compilation (#58688)

Summary:
Pull Request resolved: #58688

Different AndroidX artifacts expose `ActivityResultLauncher.contract` as either a Kotlin property or a Java `getContract()` method. A Kotlin subclass cannot override both source representations even though they have the same JVM signature.

Route the contract accessor through a package-private Java superclass so both representations resolve to the same JVM method. Use the bridge in production and test launchers, verify that the registered contract is preserved, and allowlist this required Java compatibility source.

Changelog:
[Android][Fixed] - Fix Activity Result launcher compilation across AndroidX source variants

Reviewed By: fkgozali

Differential Revision: D121845437

fbshipit-source-id: 3d4e2c5726a8b39e5bb3863211fb7c88dd16e43a

Author: Abbondanzo

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/activityresult/ActivityResultLauncherCompat.java

@@ -0,0 +1,24 @@
+/*
+ * Copyright (c) Meta Platforms, Inc. and affiliates.
+ *
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
+ */
+
+package com.facebook.react.activityresult;
+
+import androidx.activity.result.ActivityResultLauncher;
+import androidx.activity.result.contract.ActivityResultContract;
+
+abstract class ActivityResultLauncherCompat<I> extends ActivityResultLauncher<I> {
+  private final ActivityResultContract<I, ?> contract;
+
+  ActivityResultLauncherCompat(ActivityResultContract<I, ?> contract) {
+    this.contract = contract;
+  }
+
+  @Override
+  public ActivityResultContract<I, ?> getContract() {
+    return contract;
+  }
+}

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/activityresult/DeferredActivityResultLauncher.kt

@@ -26,10 +26,10 @@ import com.facebook.react.common.ReactConstants
  */
 internal class DeferredActivityResultLauncher<I>(
     private val key: String,
-    override val contract: ActivityResultContract<I, *>,
+    contract: ActivityResultContract<I, *>,
     private val onUnregister: () -> Unit,
     private val onLaunchFailure: (RuntimeException) -> Unit = {},
-) : ActivityResultLauncher<I>() {
+) : ActivityResultLauncherCompat<I>(contract) {
 
   private class PendingLaunch<I>(val input: I, val options: ActivityOptionsCompat?)
 

packages/react-native/ReactAndroid/src/test/java/com/facebook/react/activityresult/ReactActivityResultCallerImplTest.kt

@@ -81,6 +81,14 @@ class ReactActivityResultCallerImplTest {
     caller = ReactActivityResultCallerImpl(reactContext)
   }
 
+  @Test
+  fun launcherExposesRegisteredContract() {
+    val contract = GetContent()
+    val launcher = caller.registerForActivityResult(moduleA, contract) {}
+
+    assertThat(launcher.contract).isSameAs(contract)
+  }
+
   @Test
   fun twoOwnersMayRegisterTheSameStockContract() {
     caller.registerForActivityResult(moduleA, GetContent()) {}

packages/react-native/ReactAndroid/src/test/java/com/facebook/react/activityresult/ReactActivityResultCallerThreadingTest.kt

@@ -11,7 +11,6 @@ import android.app.Activity
 import android.content.ActivityNotFoundException
 import android.os.Bundle
 import android.os.Looper
-import androidx.activity.result.ActivityResultLauncher
 import androidx.activity.result.ActivityResultRegistry
 import androidx.activity.result.ActivityResultRegistryOwner
 import androidx.activity.result.contract.ActivityResultContract
@@ -65,8 +64,7 @@ class ReactActivityResultCallerThreadingTest {
               .orEmpty()
   }
 
-  private class ThrowingLauncher : ActivityResultLauncher<String>() {
-    override val contract: ActivityResultContract<String, *> = GetContent()
+  private class ThrowingLauncher : ActivityResultLauncherCompat<String>(GetContent()) {
     var launchCount = 0
 
     override fun launch(input: String, options: ActivityOptionsCompat?) {