Skip to content

Commit cf28e6b

Browse files
cortinicometa-codesync[bot]
authored andcommitted
Remove legacy architecture stub UIImplementation (#56939)
Summary: Pull Request resolved: #56939 This class was fully stubbed out as part of the Legacy Architecture removal. All public methods had empty bodies or returned null/0, meaning any OSS library still referencing it was already silently broken at runtime. Also removes the dead `getUIImplementation()` method from `UIManagerModule`, removes `enqueueLayoutUpdateFinished` from `UIViewOperationQueue`, and cleans up stale Javadoc references in `JSTouchDispatcher`, `ReactViewGroup`, and `ReactInterceptingViewGroup`. `UIBlock`, `NativeViewHierarchyManager`, `UIViewOperationQueue`, and the `addUIBlock`/`prependUIBlock` methods on `UIManagerModule` are retained and will be deprecated in a follow-up diff. Changelog: [Android][Removed] - Remove legacy architecture stub `UIImplementation`. This class was already non-functional (all methods were empty stubs). Reviewed By: javache Differential Revision: D106086358 fbshipit-source-id: e240b536b11377b7fede4563a09bca1d71f44198
1 parent 5f080c5 commit cf28e6b

7 files changed

Lines changed: 9 additions & 429 deletions

File tree

packages/react-native/ReactAndroid/api/ReactAndroid.api

Lines changed: 0 additions & 59 deletions
Original file line numberDiff line numberDiff line change
@@ -4207,63 +4207,6 @@ public abstract interface class com/facebook/react/uimanager/UIBlock {
42074207
public abstract fun execute (Lcom/facebook/react/uimanager/NativeViewHierarchyManager;)V
42084208
}
42094209

4210-
public class com/facebook/react/uimanager/UIImplementation {
4211-
protected fun <init> (Lcom/facebook/react/bridge/ReactApplicationContext;Lcom/facebook/react/uimanager/ViewManagerRegistry;Lcom/facebook/react/uimanager/UIViewOperationQueue;Lcom/facebook/react/uimanager/events/EventDispatcher;)V
4212-
public fun addUIBlock (Lcom/facebook/react/uimanager/UIBlock;)V
4213-
protected fun calculateRootLayout (Lcom/facebook/react/uimanager/ReactShadowNode;)V
4214-
public fun clearJSResponder ()V
4215-
public fun configureNextLayoutAnimation (Lcom/facebook/react/bridge/ReadableMap;Lcom/facebook/react/bridge/Callback;)V
4216-
protected fun createRootShadowNode ()Lcom/facebook/react/uimanager/ReactShadowNode;
4217-
protected fun createShadowNode (Ljava/lang/String;)Lcom/facebook/react/uimanager/ReactShadowNode;
4218-
public fun createView (ILjava/lang/String;ILcom/facebook/react/bridge/ReadableMap;)V
4219-
public fun dispatchViewManagerCommand (IILcom/facebook/react/bridge/ReadableArray;)V
4220-
public fun dispatchViewManagerCommand (ILjava/lang/String;Lcom/facebook/react/bridge/ReadableArray;)V
4221-
public fun dispatchViewUpdates (I)V
4222-
public fun findSubviewIn (IFFLcom/facebook/react/bridge/Callback;)V
4223-
public fun getProfiledBatchPerfCounters ()Ljava/util/Map;
4224-
public fun getRootViewNum ()I
4225-
protected fun handleCreateView (Lcom/facebook/react/uimanager/ReactShadowNode;ILcom/facebook/react/uimanager/ReactStylesDiffMap;)V
4226-
protected fun handleUpdateView (Lcom/facebook/react/uimanager/ReactShadowNode;Ljava/lang/String;Lcom/facebook/react/uimanager/ReactStylesDiffMap;)V
4227-
public fun manageChildren (ILcom/facebook/react/bridge/ReadableArray;Lcom/facebook/react/bridge/ReadableArray;Lcom/facebook/react/bridge/ReadableArray;Lcom/facebook/react/bridge/ReadableArray;Lcom/facebook/react/bridge/ReadableArray;)V
4228-
public fun measure (ILcom/facebook/react/bridge/Callback;)V
4229-
public fun measureInWindow (ILcom/facebook/react/bridge/Callback;)V
4230-
public fun measureLayout (IILcom/facebook/react/bridge/Callback;Lcom/facebook/react/bridge/Callback;)V
4231-
public fun measureLayoutRelativeToParent (ILcom/facebook/react/bridge/Callback;Lcom/facebook/react/bridge/Callback;)V
4232-
public fun onCatalystInstanceDestroyed ()V
4233-
public fun onHostDestroy ()V
4234-
public fun onHostPause ()V
4235-
public fun onHostResume ()V
4236-
public fun prependUIBlock (Lcom/facebook/react/uimanager/UIBlock;)V
4237-
public fun profileNextBatch ()V
4238-
public fun registerRootView (Landroid/view/View;ILcom/facebook/react/uimanager/ThemedReactContext;)V
4239-
public fun removeLayoutUpdateListener ()V
4240-
public fun removeRootShadowNode (I)V
4241-
public fun removeRootView (I)V
4242-
protected final fun removeShadowNode (Lcom/facebook/react/uimanager/ReactShadowNode;)V
4243-
public fun replaceExistingNonRootView (II)V
4244-
public fun resolveRootTagFromReactTag (I)I
4245-
public final fun resolveShadowNode (I)Lcom/facebook/react/uimanager/ReactShadowNode;
4246-
protected final fun resolveViewManager (Ljava/lang/String;)Lcom/facebook/react/uimanager/ViewManager;
4247-
public fun sendAccessibilityEvent (II)V
4248-
public fun setChildren (ILcom/facebook/react/bridge/ReadableArray;)V
4249-
public fun setJSResponder (IZ)V
4250-
public fun setLayoutAnimationEnabledExperimental (Z)V
4251-
public fun setLayoutUpdateListener (Lcom/facebook/react/uimanager/UIImplementation$LayoutUpdateListener;)V
4252-
public fun setViewLocalData (ILjava/lang/Object;)V
4253-
public fun synchronouslyUpdateViewOnUIThread (ILcom/facebook/react/uimanager/ReactStylesDiffMap;)V
4254-
public fun updateInsetsPadding (IIIII)V
4255-
public fun updateNodeSize (III)V
4256-
public fun updateRootView (III)V
4257-
public fun updateRootView (Lcom/facebook/react/uimanager/ReactShadowNode;II)V
4258-
public fun updateView (ILjava/lang/String;Lcom/facebook/react/bridge/ReadableMap;)V
4259-
protected fun updateViewHierarchy ()V
4260-
public fun viewIsDescendantOf (IILcom/facebook/react/bridge/Callback;)V
4261-
}
4262-
4263-
public abstract interface class com/facebook/react/uimanager/UIImplementation$LayoutUpdateListener {
4264-
public abstract fun onLayoutUpdated (Lcom/facebook/react/uimanager/ReactShadowNode;)V
4265-
}
4266-
42674210
public final class com/facebook/react/uimanager/UIManagerHelper {
42684211
public static final field INSTANCE Lcom/facebook/react/uimanager/UIManagerHelper;
42694212
public static final field PADDING_BOTTOM_INDEX I
@@ -4306,7 +4249,6 @@ public class com/facebook/react/uimanager/UIManagerModule : com/facebook/react/b
43064249
public fun getEventDispatcher ()Lcom/facebook/react/uimanager/events/EventDispatcher;
43074250
public fun getName ()Ljava/lang/String;
43084251
public fun getPerformanceCounters ()Ljava/util/Map;
4309-
public fun getUIImplementation ()Lcom/facebook/react/uimanager/UIImplementation;
43104252
public fun getViewManagerRegistry_DO_NOT_USE ()Lcom/facebook/react/uimanager/ViewManagerRegistry;
43114253
public fun initialize ()V
43124254
public fun invalidate ()V
@@ -4359,7 +4301,6 @@ public class com/facebook/react/uimanager/UIViewOperationQueue {
43594301
public fun enqueueDispatchCommand (IILcom/facebook/react/bridge/ReadableArray;)V
43604302
public fun enqueueDispatchCommand (ILjava/lang/String;Lcom/facebook/react/bridge/ReadableArray;)V
43614303
public fun enqueueFindTargetForTouch (IFFLcom/facebook/react/bridge/Callback;)V
4362-
public fun enqueueLayoutUpdateFinished (Lcom/facebook/react/uimanager/ReactShadowNode;Lcom/facebook/react/uimanager/UIImplementation$LayoutUpdateListener;)V
43634304
public fun enqueueManageChildren (I[I[Lcom/facebook/react/uimanager/ViewAtIndex;[I)V
43644305
public fun enqueueMeasure (ILcom/facebook/react/bridge/Callback;)V
43654306
public fun enqueueMeasureInWindow (ILcom/facebook/react/bridge/Callback;)V

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/touch/ReactInterceptingViewGroup.kt

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -10,10 +10,10 @@ package com.facebook.react.touch
1010
import android.view.ViewGroup
1111

1212
/**
13-
* This interface should be implemented by all [ViewGroup] subviews that can be instantiating by
14-
* [com.facebook.react.uimanager.NativeViewHierarchyManager]. It is used to configure
15-
* onInterceptTouch event listener which then is used to control touch event flow in cases in which
16-
* they requested to be intercepted by some parent view based on a JS gesture detector.
13+
* This interface should be implemented by all [ViewGroup] subviews managed by React Native. It is
14+
* used to configure onInterceptTouch event listener which then is used to control touch event flow
15+
* in cases in which they requested to be intercepted by some parent view based on a JS gesture
16+
* detector.
1717
*/
1818
internal interface ReactInterceptingViewGroup {
1919

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/JSTouchDispatcher.kt

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -98,10 +98,8 @@ public class JSTouchDispatcher(private val viewGroup: ViewGroup) {
9898
FLog.e(ReactConstants.TAG, "Got DOWN touch before receiving UP or CANCEL from last gesture")
9999
}
100100

101-
// First event for this gesture. We expect tag to be set to -1, and we use helper method
102-
// [com.facebook.react.uimanager.NativeViewHierarchyManager.findTargetTagForTouch] to find
103-
// react view ID that will be responsible for handling
104-
// this gesture
101+
// First event for this gesture. We expect tag to be set to -1, and we use
102+
// findTargetTagAndSetCoordinates to find the react view ID that will handle this gesture
105103
childIsHandlingNativeGesture = false
106104
gestureStartTime = ev.eventTime
107105
targetTag = findTargetTagAndSetCoordinates(ev)

0 commit comments

Comments
 (0)