Commit b05ab2f
Update stale 'Hermes V1' comments (#56757)
Summary:
Pull Request resolved: #56757
Update comments that still say 'Hermes V1' as if it is an opt-in feature.
Since Hermes (formerly called Hermes V1) is now the only supported engine:
- hermes-engine.podspec: drop 'when using Hermes V1' from hermesc note
- PathUtils.kt: rewrite the hermesc path comment to drop the 'opted in to Hermes V1' phrasing
- hermes-engine/build.gradle.kts: 'Hermes V1 by default...' -> 'Hermes by default...'
## Changelog:
[Internal] -
Reviewed By: cortinico
Differential Revision: D104649634
fbshipit-source-id: 9b0a05ed013c7ba908c7abe467d5e3c1c3c2f26c1 parent ca4aaff commit b05ab2f
2 files changed
Lines changed: 4 additions & 6 deletions
File tree
- packages
- gradle-plugin/react-native-gradle-plugin/src/main/kotlin/com/facebook/react/utils
- react-native/sdks/hermes-engine
Lines changed: 3 additions & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
123 | 123 | | |
124 | 124 | | |
125 | 125 | | |
126 | | - | |
127 | | - | |
128 | | - | |
129 | | - | |
130 | | - | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
131 | 129 | | |
132 | 130 | | |
133 | 131 | | |
| |||
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
65 | 65 | | |
66 | 66 | | |
67 | 67 | | |
68 | | - | |
| 68 | + | |
69 | 69 | | |
70 | 70 | | |
71 | 71 | | |
| |||
0 commit comments