Commit b03e255
committed
Add useTraitHiddenOnIOS feature flag
## Summary:
Mirrors useTraitHiddenOnAndroid from #54112. Lets iOS apps opt out of
the `Trait::Hidden` slice-skip; Android can already opt in. Default is
`true`, preserving today's iOS behavior.
What the optimization does
D22134220 (2020, "Fabric: display: none nodes do not create views
anymore") added `Trait::Hidden` and a slice-skip in
`sliceChildShadowNodeViewPairs` that filters out subtrees whose Yoga
display is None. On iOS the diff then issues REMOVE + DELETE for the
entire subtree — invisible content stops costing anything.
For most UIs this is a clean win.
Where it bites
The optimization assumes that `display: none` transitions are rare.
That breaks for a specific pattern: **a custom host component mounted
under `<Suspense>`**.
Each suspend → resume cycle, Suspense flips display between `flex` and
`none`. With the optimization on, every cycle:
- tears down the entire subtree of UIViews,
- drops per-instance native state — measurement caches, scroll
position, animation drivers, anything internal to the host
component,
- re-runs `init`/`dealloc` and rebuilds the subtree on resume.
Suspend/resume ends up heavier than a fresh mount, and any state the
component held disappears between renders.
What the flag does
**It re-activates an existing code path. Nothing in the mounting
layer is new.**
The hide-via-`UIView.hidden` wiring shipped in D8460108 (June 2018,
"Fabric: Default support of displayType and layoutDirection
layout...") and has lived in `UIView+ComponentViewProtocol
updateLayoutMetrics:` ever since — a few lines below the slice
consumer in the same file. For two years it was the only iOS path;
the 2020 slice-skip didn't replace it, it just made it unreachable
in the common case.
Setting the flag to `false` lets Hidden shadow nodes pass through
the slice. The differ emits an `UPDATE_LAYOUT_METRICS` mutation
with `displayType == None`, and the 2018 wiring picks it up:
`self.hidden = YES` on the underlying UIView. Same view, hidden in
place.
Defaults
- `useTraitHiddenOnIOS = true` — keeps the iOS behavior introduced
in 2020.
- `useTraitHiddenOnAndroid = false` — keeps the Android behavior,
which never adopted the slice-skip.
Both flags share the same semantic ("use the optimization"); the
defaults encode each platform's pre-flag behavior. Flipping either
default is out of scope.
## Changelog:
[IOS] [ADDED] - useTraitHiddenOnIOS feature flag to opt out of the `display: none` slice-skip optimization
## Test Plan:
No new tests. `StackingContextTest` exercises the slice-skip path and
passes unchanged with the flag at its default `true`. Manually
flipping the flag to `false` produces the existing Android branch's
expected view tree (8 views, Hidden subtrees preserved with
`self.hidden = YES`).1 parent f9f7133 commit b03e255
21 files changed
Lines changed: 146 additions & 25 deletions
File tree
- packages/react-native
- ReactAndroid/src/main
- java/com/facebook/react/internal/featureflags
- jni/react/featureflags
- ReactCommon/react
- featureflags
- nativemodule/featureflags
- renderer/mounting/internal
- scripts/featureflags
- src/private/featureflags
- specs
Lines changed: 7 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
7 | | - | |
| 7 | + | |
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
| |||
396 | 396 | | |
397 | 397 | | |
398 | 398 | | |
| 399 | + | |
| 400 | + | |
| 401 | + | |
| 402 | + | |
| 403 | + | |
| 404 | + | |
399 | 405 | | |
400 | 406 | | |
401 | 407 | | |
| |||
Lines changed: 11 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
7 | | - | |
| 7 | + | |
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
| |||
81 | 81 | | |
82 | 82 | | |
83 | 83 | | |
| 84 | + | |
84 | 85 | | |
85 | 86 | | |
86 | 87 | | |
| |||
635 | 636 | | |
636 | 637 | | |
637 | 638 | | |
| 639 | + | |
| 640 | + | |
| 641 | + | |
| 642 | + | |
| 643 | + | |
| 644 | + | |
| 645 | + | |
| 646 | + | |
| 647 | + | |
638 | 648 | | |
639 | 649 | | |
640 | 650 | | |
| |||
Lines changed: 3 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
7 | | - | |
| 7 | + | |
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
| |||
150 | 150 | | |
151 | 151 | | |
152 | 152 | | |
| 153 | + | |
| 154 | + | |
153 | 155 | | |
154 | 156 | | |
155 | 157 | | |
| |||
Lines changed: 3 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
7 | | - | |
| 7 | + | |
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
| |||
145 | 145 | | |
146 | 146 | | |
147 | 147 | | |
| 148 | + | |
| 149 | + | |
148 | 150 | | |
149 | 151 | | |
150 | 152 | | |
| |||
Lines changed: 12 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
7 | | - | |
| 7 | + | |
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
| |||
85 | 85 | | |
86 | 86 | | |
87 | 87 | | |
| 88 | + | |
88 | 89 | | |
89 | 90 | | |
90 | 91 | | |
| |||
700 | 701 | | |
701 | 702 | | |
702 | 703 | | |
| 704 | + | |
| 705 | + | |
| 706 | + | |
| 707 | + | |
| 708 | + | |
| 709 | + | |
| 710 | + | |
| 711 | + | |
| 712 | + | |
| 713 | + | |
703 | 714 | | |
704 | 715 | | |
705 | 716 | | |
| |||
Lines changed: 3 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
7 | | - | |
| 7 | + | |
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
| |||
145 | 145 | | |
146 | 146 | | |
147 | 147 | | |
| 148 | + | |
| 149 | + | |
148 | 150 | | |
149 | 151 | | |
150 | 152 | | |
| |||
Lines changed: 15 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
7 | | - | |
| 7 | + | |
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
| |||
405 | 405 | | |
406 | 406 | | |
407 | 407 | | |
| 408 | + | |
| 409 | + | |
| 410 | + | |
| 411 | + | |
| 412 | + | |
| 413 | + | |
408 | 414 | | |
409 | 415 | | |
410 | 416 | | |
| |||
738 | 744 | | |
739 | 745 | | |
740 | 746 | | |
| 747 | + | |
| 748 | + | |
| 749 | + | |
| 750 | + | |
| 751 | + | |
741 | 752 | | |
742 | 753 | | |
743 | 754 | | |
| |||
972 | 983 | | |
973 | 984 | | |
974 | 985 | | |
| 986 | + | |
| 987 | + | |
| 988 | + | |
975 | 989 | | |
976 | 990 | | |
977 | 991 | | |
| |||
Lines changed: 4 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
7 | | - | |
| 7 | + | |
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
| |||
213 | 213 | | |
214 | 214 | | |
215 | 215 | | |
| 216 | + | |
| 217 | + | |
| 218 | + | |
216 | 219 | | |
217 | 220 | | |
218 | 221 | | |
| |||
Lines changed: 5 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
7 | | - | |
| 7 | + | |
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
| |||
270 | 270 | | |
271 | 271 | | |
272 | 272 | | |
| 273 | + | |
| 274 | + | |
| 275 | + | |
| 276 | + | |
273 | 277 | | |
274 | 278 | | |
275 | 279 | | |
| |||
Lines changed: 6 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
7 | | - | |
| 7 | + | |
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
| |||
344 | 344 | | |
345 | 345 | | |
346 | 346 | | |
| 347 | + | |
| 348 | + | |
| 349 | + | |
| 350 | + | |
| 351 | + | |
347 | 352 | | |
348 | 353 | | |
349 | 354 | | |
| |||
0 commit comments