Make StackTraceParser.h private in jserrorhandler

Summary:
`StackTraceParser` is an implementation detail of `JsErrorHandler`: it is only used by `JsErrorHandler.cpp` and its own unit test, and `JsErrorHandler.h` does not include it. Mark it as a private header instead of a for-frameworks one.

- Swap `FrameworksGuard.h` for `PrivateGuard.h` in `StackTraceParser.h`.
- Include `JsErrorHandler.h` via its namespaced path so the header resolves when it is not exported alongside it.
- Stop shipping `StackTraceParser.h` as a header for prebuilt `React-jserrorhandler` pods.

Changelog: [Internal]

Differential Revision: D122770464

Author: coado

packages/react-native/ReactCommon/jserrorhandler/React-jserrorhandler.podspec

@@ -34,7 +34,7 @@ Pod::Spec.new do |s|
   s.platforms              = min_supported_versions
   s.source                 = source
   s.header_dir             = "jserrorhandler"
-  s.source_files           = podspec_sources(["ErrorUtils.{cpp,h}", "JsErrorHandler.{cpp,h}", "StackTraceParser.{cpp,h}"], ["ErrorUtils.h", "JsErrorHandler.h", "StackTraceParser.h"])
+  s.source_files           = podspec_sources(["ErrorUtils.{cpp,h}", "JsErrorHandler.{cpp,h}", "StackTraceParser.{cpp,h}"], ["ErrorUtils.h", "JsErrorHandler.h"])
   s.pod_target_xcconfig = {
     "HEADER_SEARCH_PATHS" => header_search_paths.join(' '),
     "USE_HEADERMAP" => "YES",

packages/react-native/ReactCommon/jserrorhandler/StackTraceParser.h

@@ -7,11 +7,11 @@
 
 #pragma once
 
-#include <react/cxxstableapi/FrameworksGuard.h>
+#include <react/cxxstableapi/PrivateGuard.h>
 
+#include <jserrorhandler/JsErrorHandler.h>
 #include <string>
 #include <vector>
-#include "JsErrorHandler.h"
 
 namespace facebook::react {