Use pinned Hermes version when version.properties is not 1000.0.0

The use-hermes-nightly flag was computed from the branch name, which
evaluates incorrectly for PR branches targeting stable. Instead, read
the actual HERMES_VERSION_NAME from version.properties and only use
nightly when it is the 1000.0.0 development placeholder.

Author: cipolleschi

.github/actions/test-ios-helloworld/action.yml

@@ -33,7 +33,10 @@ runs:
       if: ${{ inputs.use-hermes-nightly == 'true' }}
       shell: bash
       run: |
-        node ./scripts/releases/use-hermes-nightly.js
+        HERMES_VERSION=$(sed -n 's/^HERMES_VERSION_NAME=//p' packages/react-native/sdks/hermes-engine/version.properties)
+        if [ "$HERMES_VERSION" == "1000.0.0" ]; then
+          node ./scripts/releases/use-hermes-nightly.js
+        fi
     - name: Run yarn install again, with the correct hermes version
       if: ${{ inputs.use-hermes-nightly == 'true' }}
       uses: ./.github/actions/yarn-install

.github/actions/test-ios-rntester/action.yml

@@ -41,7 +41,10 @@ runs:
       if: ${{ inputs.use-hermes-nightly == 'true' }}
       shell: bash
       run: |
-        node ./scripts/releases/use-hermes-nightly.js
+        HERMES_VERSION=$(sed -n 's/^HERMES_VERSION_NAME=//p' packages/react-native/sdks/hermes-engine/version.properties)
+        if [ "$HERMES_VERSION" == "1000.0.0" ]; then
+          node ./scripts/releases/use-hermes-nightly.js
+        fi
     - name: Run yarn install again, with the correct hermes version
       if: ${{ inputs.use-hermes-nightly == 'true' }}
       uses: ./.github/actions/yarn-install

.github/workflows/prebuild-ios-core.yml

@@ -49,10 +49,9 @@ jobs:
       - name: Set Hermes version
         shell: bash
         run: |
-          if [ "${{ inputs.use-hermes-nightly }}" == "true" ]; then
+          HERMES_VERSION=$(sed -n 's/^HERMES_VERSION_NAME=//p' packages/react-native/sdks/hermes-engine/version.properties)
+          if [ "$HERMES_VERSION" == "1000.0.0" ]; then
             HERMES_VERSION="nightly"
-          else
-            HERMES_VERSION=$(sed -n 's/^HERMES_VERSION_NAME=//p' packages/react-native/sdks/hermes-engine/version.properties)
           fi
           echo "Using Hermes version: $HERMES_VERSION"
           echo "HERMES_VERSION=$HERMES_VERSION" >> $GITHUB_ENV