Skip to content

Commit 560ac23

Browse files
chrfalchfacebook-github-bot
authored andcommitted
Added missing define to target .reactRuntime (#52082)
Summary: The target needs the HERMES_ENABLE_DEBUGGER flag in debug just like .reactHermes does. This commit fixes this by adding the define to the reactRuntime target. ## Changelog: [IOS] [FIXED] - Added HERMES_ENABLE_DEBUGGER to debug configuration for the reactRuntime target. Pull Request resolved: #52082 Test Plan: Prebuild React Core Reviewed By: robhogan Differential Revision: D76813200 Pulled By: cipolleschi fbshipit-source-id: cb81a40fb9c5a91ca40c3a27ae4ccdf043186bac
1 parent 87cd1c0 commit 560ac23

1 file changed

Lines changed: 4 additions & 1 deletion

File tree

packages/react-native/Package.swift

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -336,7 +336,10 @@ let reactRuntime = RNTarget(
336336
name: .reactRuntime,
337337
path: "ReactCommon/react/runtime",
338338
excludedPaths: ["tests", "iostests", "platform"],
339-
dependencies: [.reactNativeDependencies, .jsi, .reactJsiExecutor, .reactCxxReact, .reactJsErrorHandler, .reactPerformanceTimeline, .reactUtils, .reactFeatureFlags, .reactJsInspector, .reactJsiTooling, .reactHermes, .reactRuntimeScheduler, .hermesPrebuilt]
339+
dependencies: [.reactNativeDependencies, .jsi, .reactJsiExecutor, .reactCxxReact, .reactJsErrorHandler, .reactPerformanceTimeline, .reactUtils, .reactFeatureFlags, .reactJsInspector, .reactJsiTooling, .reactHermes, .reactRuntimeScheduler, .hermesPrebuilt],
340+
defines: [
341+
CXXSetting.define("HERMES_ENABLE_DEBUGGER", to: "1", .when(configuration: BuildConfiguration.debug))
342+
]
340343
)
341344

342345
/// React-runtimeApple.podspec

0 commit comments

Comments
 (0)