add header search paths for transitive dep for React-Fabric

Author: coado

packages/react-native/scripts/cocoapods/__tests__/utils-test.rb

@@ -981,6 +981,31 @@ def test_setStableUmbrellaSearchPaths_addsOwningFrameworkPathToDependentTarget
         end
     end
 
+    def test_setStableUmbrellaSearchPaths_addsOwningFrameworkPathToTransitivelyDependentTarget
+        dependency = Struct.new(:name, :target)
+        fabric_target = prepare_target("React-Fabric")
+        intermediate_target = prepare_target(
+            "Intermediate",
+            nil,
+            [dependency.new("React-Fabric", fabric_target)]
+        )
+        consumer_target = prepare_target(
+            "Consumer",
+            nil,
+            [dependency.new("Intermediate", intermediate_target)]
+        )
+        target_installation_result = TargetInstallationResultMock.new(consumer_target, consumer_target)
+
+        ReactNativePodsUtils.set_stable_umbrella_search_paths(target_installation_result)
+
+        consumer_target.build_configurations.each do |config|
+            assert_equal(
+                '$(inherited) "${PODS_CONFIGURATION_BUILD_DIR}/React-Fabric/React_Fabric.framework/Headers"',
+                config.build_settings["HEADER_SEARCH_PATHS"]
+            )
+        end
+    end
+
     def test_setStableUmbrellaSearchPaths_doesNotAddOwningFrameworkPathToUnrelatedTarget
         target = prepare_target("React-Fabric")
         target_installation_result = TargetInstallationResultMock.new(target, target)

packages/react-native/scripts/cocoapods/utils.rb

@@ -670,10 +670,29 @@ def self.add_search_path_if_not_included(current_search_paths, new_search_path)
         current_search_paths
     end
 
-    def self.update_header_paths_if_depends_on(target_installation_result, dependency_name, header_paths)
-        depends_on_framework = target_installation_result.native_target.dependencies.any? { |d| d.name == dependency_name }
+    def self.target_depends_on?(target, dependency_name, visited_targets = {})
+        return false if target == nil
+
+        target_identifier = target.respond_to?(:uuid) ? target.uuid : target.object_id
+        target_identifier ||= target.object_id
+        return false if visited_targets[target_identifier]
+
+        visited_targets[target_identifier] = true
+        target.dependencies.any? do |dependency|
+            dependency.name == dependency_name ||
+                (dependency.respond_to?(:target) && self.target_depends_on?(dependency.target, dependency_name, visited_targets))
+        end
+    end
+
+    def self.update_header_paths_if_depends_on(target_installation_result, dependency_name, header_paths, include_transitive_dependencies: false)
+        native_target = target_installation_result.native_target
+        depends_on_framework = if include_transitive_dependencies
+            self.target_depends_on?(native_target, dependency_name)
+        else
+            native_target.dependencies.any? { |d| d.name == dependency_name }
+        end
         if depends_on_framework
-            target_installation_result.native_target.build_configurations.each do |config|
+            native_target.build_configurations.each do |config|
                 header_search_path = config.build_settings["HEADER_SEARCH_PATHS"] != nil ? config.build_settings["HEADER_SEARCH_PATHS"] : "$(inherited)"
                 header_paths.each { |header| header_search_path = ReactNativePodsUtils.add_search_path_if_not_included(header_search_path, header) }
                 config.build_settings["HEADER_SEARCH_PATHS"] = header_search_path
@@ -691,7 +710,12 @@ def self.set_stable_umbrella_search_paths(target_installation_result)
                 framework_name,
                 []
             ).map { |search_path| "\"#{search_path}\"" }
-            ReactNativePodsUtils.update_header_paths_if_depends_on(target_installation_result, pod_name, header_search_paths)
+            ReactNativePodsUtils.update_header_paths_if_depends_on(
+                target_installation_result,
+                pod_name,
+                header_search_paths,
+                include_transitive_dependencies: true
+            )
         end
     end