Skip to content

Commit 3d96302

Browse files
committed
Remove dual Hermes version outputs from CI workflows
Simplify publish-release, create-draft-release, and prebuild-ios-core workflows to use a single HERMES_VERSION. Remove the Hermes V1 dSYM section from release notes. Delete unused prepare-hermes-v1-app action, hermes-v1.patch, and selectLatestHermesV1Version.js.
1 parent 2bcc535 commit 3d96302

8 files changed

Lines changed: 7 additions & 143 deletions

File tree

.github/actions/prepare-hermes-v1-app/action.yml

Lines changed: 0 additions & 41 deletions
This file was deleted.

.github/workflow-scripts/__tests__/createDraftRelease-test.js

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -144,10 +144,6 @@ Hermes dSYMS:
144144
- [Debug](https://repo1.maven.org/maven2/com/facebook/hermes/hermes-ios/${version}/hermes-ios-${version}-hermes-framework-dSYM-debug.tar.gz)
145145
- [Release](https://repo1.maven.org/maven2/com/facebook/hermes/hermes-ios/${version}/hermes-ios-${version}-hermes-framework-dSYM-release.tar.gz)
146146
147-
Hermes V1 dSYMS:
148-
- [Debug](https://repo1.maven.org/maven2/com/facebook/hermes/hermes-ios/${version}/hermes-ios-${version}-hermes-framework-dSYM-debug.tar.gz)
149-
- [Release](https://repo1.maven.org/maven2/com/facebook/hermes/hermes-ios/${version}/hermes-ios-${version}-hermes-framework-dSYM-release.tar.gz)
150-
151147
ReactNativeDependencies dSYMs:
152148
- [Debug](https://repo1.maven.org/maven2/com/facebook/react/react-native-artifacts/${version}/react-native-artifacts-${version}-reactnative-dependencies-dSYM-debug.tar.gz)
153149
- [Release](https://repo1.maven.org/maven2/com/facebook/react/react-native-artifacts/${version}/react-native-artifacts-${version}-reactnative-dependencies-dSYM-release.tar.gz)
@@ -172,7 +168,6 @@ View the whole changelog in the [CHANGELOG.md file](https://github.com/facebook/
172168
it('computes body for release when hermes versions are passed', async () => {
173169
const version = '0.77.1';
174170
const hermesVersion = '0.15.0';
175-
const hermesV1Version = '250829098.0.2';
176171
const changelog = `## v${version}
177172
### Breaking Changes
178173
- [PR #9012](https://github.com/facebook/react-native/pull/9012) - Some other change
@@ -188,7 +183,6 @@ View the whole changelog in the [CHANGELOG.md file](https://github.com/facebook/
188183
changelog,
189184
version,
190185
hermesVersion,
191-
hermesV1Version,
192186
);
193187

194188
expect(body).toEqual(`${changelog}
@@ -199,10 +193,6 @@ Hermes dSYMS:
199193
- [Debug](https://repo1.maven.org/maven2/com/facebook/hermes/hermes-ios/${hermesVersion}/hermes-ios-${hermesVersion}-hermes-framework-dSYM-debug.tar.gz)
200194
- [Release](https://repo1.maven.org/maven2/com/facebook/hermes/hermes-ios/${hermesVersion}/hermes-ios-${hermesVersion}-hermes-framework-dSYM-release.tar.gz)
201195
202-
Hermes V1 dSYMS:
203-
- [Debug](https://repo1.maven.org/maven2/com/facebook/hermes/hermes-ios/${hermesV1Version}/hermes-ios-${hermesV1Version}-hermes-framework-dSYM-debug.tar.gz)
204-
- [Release](https://repo1.maven.org/maven2/com/facebook/hermes/hermes-ios/${hermesV1Version}/hermes-ios-${hermesV1Version}-hermes-framework-dSYM-release.tar.gz)
205-
206196
ReactNativeDependencies dSYMs:
207197
- [Debug](https://repo1.maven.org/maven2/com/facebook/react/react-native-artifacts/${version}/react-native-artifacts-${version}-reactnative-dependencies-dSYM-debug.tar.gz)
208198
- [Release](https://repo1.maven.org/maven2/com/facebook/react/react-native-artifacts/${version}/react-native-artifacts-${version}-reactnative-dependencies-dSYM-release.tar.gz)

.github/workflow-scripts/createDraftRelease.js

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -40,9 +40,8 @@ function _extractChangelog(version) {
4040
return changelog.slice(changelogStarts, changelogEnds).join('\n').trim();
4141
}
4242

43-
function _computeBody(changelog, version, hermesVersion, hermesV1Version) {
43+
function _computeBody(changelog, version, hermesVersion) {
4444
hermesVersion = hermesVersion ?? version;
45-
hermesV1Version = hermesV1Version ?? version;
4645
return `${changelog}
4746
4847
---
@@ -51,10 +50,6 @@ Hermes dSYMS:
5150
- [Debug](https://repo1.maven.org/maven2/com/facebook/hermes/hermes-ios/${hermesVersion}/hermes-ios-${hermesVersion}-hermes-framework-dSYM-debug.tar.gz)
5251
- [Release](https://repo1.maven.org/maven2/com/facebook/hermes/hermes-ios/${hermesVersion}/hermes-ios-${hermesVersion}-hermes-framework-dSYM-release.tar.gz)
5352
54-
Hermes V1 dSYMS:
55-
- [Debug](https://repo1.maven.org/maven2/com/facebook/hermes/hermes-ios/${hermesV1Version}/hermes-ios-${hermesV1Version}-hermes-framework-dSYM-debug.tar.gz)
56-
- [Release](https://repo1.maven.org/maven2/com/facebook/hermes/hermes-ios/${hermesV1Version}/hermes-ios-${hermesV1Version}-hermes-framework-dSYM-release.tar.gz)
57-
5853
ReactNativeDependencies dSYMs:
5954
- [Debug](https://repo1.maven.org/maven2/com/facebook/react/react-native-artifacts/${version}/react-native-artifacts-${version}-reactnative-dependencies-dSYM-debug.tar.gz)
6055
- [Release](https://repo1.maven.org/maven2/com/facebook/react/react-native-artifacts/${version}/react-native-artifacts-${version}-reactnative-dependencies-dSYM-release.tar.gz)
@@ -128,7 +123,6 @@ async function createDraftRelease(
128123
latest,
129124
token,
130125
hermesVersion,
131-
hermesV1Version,
132126
) {
133127
if (version.startsWith('v')) {
134128
version = version.substring(1);
@@ -137,7 +131,7 @@ async function createDraftRelease(
137131
_verifyTagExists(version);
138132
moveToChangelogBranch(version);
139133
const changelog = _extractChangelog(version);
140-
const body = _computeBody(changelog, version, hermesVersion, hermesV1Version);
134+
const body = _computeBody(changelog, version, hermesVersion);
141135
const release = await _createDraftReleaseOnGitHub(
142136
version,
143137
body,

.github/workflow-scripts/hermes-v1.patch

Lines changed: 0 additions & 30 deletions
This file was deleted.

.github/workflow-scripts/selectLatestHermesV1Version.js

Lines changed: 0 additions & 38 deletions
This file was deleted.

.github/workflows/create-draft-release.yml

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -6,11 +6,7 @@ on:
66
hermesVersion:
77
required: false
88
type: string
9-
description: The version of Hermes to use for this release (eg. 0.15.0). If not specified, it will use React Native Version
10-
hermesV1Version:
11-
required: false
12-
type: string
13-
description: The version of Hermes V1 to use for this release (eg. 250829098.0.2). If not specified, it will use React Native Version
9+
description: The version of Hermes to use for this release (eg. 250829098.0.2). If not specified, it will use React Native Version
1410

1511
jobs:
1612
create-draft-release:
@@ -37,7 +33,7 @@ jobs:
3733
const {createDraftRelease} = require('./.github/workflow-scripts/createDraftRelease.js');
3834
const version = '${{ github.ref_name }}';
3935
const {isLatest} = require('./.github/workflow-scripts/publishTemplate.js');
40-
return (await createDraftRelease(version, isLatest(), '${{secrets.REACT_NATIVE_BOT_GITHUB_TOKEN}}', '${{ inputs.hermesVersion }}', '${{ inputs.hermesV1Version }}')).id;
36+
return (await createDraftRelease(version, isLatest(), '${{secrets.REACT_NATIVE_BOT_GITHUB_TOKEN}}', '${{ inputs.hermesVersion }}')).id;
4137
result-encoding: string
4238
- name: Upload release assets for DotSlash
4339
uses: actions/github-script@v8

.github/workflows/prebuild-ios-core.yml

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -48,11 +48,9 @@ jobs:
4848
shell: bash
4949
run: |
5050
if [ "${{ inputs.use-hermes-nightly }}" == "true" ]; then
51-
# We are not publishing nightly versions of Hermes V1 yet.
52-
# For now, we can use the latest version of Hermes V1 published on maven and npm.
5351
HERMES_VERSION="latest-v1"
5452
else
55-
HERMES_VERSION=$(sed -n 's/^HERMES_V1_VERSION_NAME=//p' packages/react-native/sdks/hermes-engine/version.properties)
53+
HERMES_VERSION=$(sed -n 's/^HERMES_VERSION_NAME=//p' packages/react-native/sdks/hermes-engine/version.properties)
5654
fi
5755
echo "Using Hermes version: $HERMES_VERSION"
5856
echo "HERMES_VERSION=$HERMES_VERSION" >> $GITHUB_ENV

.github/workflows/publish-release.yml

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -24,22 +24,18 @@ jobs:
2424
if: github.repository == 'facebook/react-native'
2525
outputs:
2626
HERMES_VERSION: ${{ steps.set_hermes_versions.outputs.HERMES_VERSION }}
27-
HERMES_V1_VERSION: ${{ steps.set_hermes_versions.outputs.HERMES_V1_VERSION }}
2827
steps:
2928
- name: Checkout
3029
uses: actions/checkout@v6
3130
- id: set_hermes_versions
3231
run: |
33-
echo "Setting hermes versions to latest"
32+
echo "Setting hermes version"
3433
hermes_version=$(grep -oE 'HERMES_VERSION_NAME=([0-9]+\.[0-9]+\.[0-9]+)' packages/react-native/sdks/hermes-engine/version.properties | cut -d'=' -f2)
35-
hermes_v1_version=$(grep -oE 'HERMES_V1_VERSION_NAME=([0-9]+\.[0-9]+\.[0-9]+)' packages/react-native/sdks/hermes-engine/version.properties | cut -d'=' -f2)
3634
3735
echo "HERMES_VERSION=$hermes_version" >> $GITHUB_OUTPUT
38-
echo "HERMES_V1_VERSION=$hermes_v1_version" >> $GITHUB_OUTPUT
39-
- name: Print hermes versions
36+
- name: Print hermes version
4037
run: |
4138
echo "HERMES_VERSION=${{ steps.set_hermes_versions.outputs.HERMES_VERSION }}"
42-
echo "HERMES_V1_VERSION=${{ steps.set_hermes_versions.outputs.HERMES_V1_VERSION }}"
4339
4440
prebuild_apple_dependencies:
4541
if: github.repository == 'facebook/react-native'
@@ -148,4 +144,3 @@ jobs:
148144
secrets: inherit
149145
with:
150146
hermesVersion: ${{ needs.set_hermes_versions.outputs.HERMES_VERSION }}
151-
hermesV1Version: ${{ needs.set_hermes_versions.outputs.HERMES_V1_VERSION }}

0 commit comments

Comments
 (0)