Use umbrellas instead of direct includes in renderer core module

Summary:
Changelog: [Internal]

Update the `react/renderer/core` module to use the `React/Debug.h`, `React/FeatureFlags.h`, `React/Timing.h`, `React/Utils.h` and `React/MapBuffer.h` umbrella includes instead of direct ones.

`react/renderer/graphics` and `react/renderer/debug` keep direct includes. Their umbrellas re-export `rounding.h` and `debugStringConvertibleUtils.h`, which are unsafe to pull into every translation unit that sees a core header: the former makes unqualified `round()` ambiguous in ObjC++, the latter resolves `toString(T)` before later overloads are declared.

Differential Revision: D121395742

Author: j-piasecki

packages/react-native/ReactCommon/React-Fabric.podspec

@@ -44,6 +44,7 @@ Pod::Spec.new do |s|
   s.dependency "React-debug"
   s.dependency "React-cxxstableapi"
   s.dependency "React-featureflags"
+  s.dependency "React-timing"
   s.dependency "React-runtimescheduler"
   s.dependency "React-cxxreact"
   s.dependency "React-bridging"

packages/react-native/ReactCommon/react/renderer/core/CMakeLists.txt

@@ -25,6 +25,7 @@ target_link_libraries(react_renderer_core
         react_renderer_graphics
         react_renderer_mapbuffer
         react_renderer_runtimescheduler
+        react_timing
         react_utils
         runtimeexecutor
         yoga)

packages/react-native/ReactCommon/react/renderer/core/ConcreteComponentDescriptor.h

@@ -12,8 +12,8 @@
 #include <memory>
 #include <vector>
 
-#include <react/debug/react_native_assert.h>
-#include <react/featureflags/ReactNativeFeatureFlags.h>
+#include <React/Debug.h>
+#include <React/FeatureFlags.h>
 #include <react/renderer/core/ComponentDescriptor.h>
 #include <react/renderer/core/EventDispatcher.h>
 #include <react/renderer/core/Props.h>

packages/react-native/ReactCommon/react/renderer/core/ConcreteShadowNode.h

@@ -9,7 +9,7 @@
 
 #include <react/cxxstableapi/UmbrellaGuard.h>
 
-#include <react/debug/react_native_assert.h>
+#include <React/Debug.h>
 #include <react/renderer/core/ConcreteState.h>
 #include <react/renderer/core/Props.h>
 #include <react/renderer/core/PropsParserContext.h>

packages/react-native/ReactCommon/react/renderer/core/ConcreteState.h

@@ -12,13 +12,12 @@
 #include <functional>
 #include <memory>
 
-#include <react/debug/react_native_assert.h>
+#include <React/Debug.h>
 #include <react/renderer/core/State.h>
 
 #ifdef RN_SERIALIZABLE_STATE
+#include <React/MapBuffer.h>
 #include <fbjni/fbjni.h>
-#include <react/renderer/mapbuffer/MapBuffer.h>
-#include <react/renderer/mapbuffer/MapBufferBuilder.h>
 #endif
 
 namespace facebook::react {

packages/react-native/ReactCommon/react/renderer/core/EventEmitter.h

@@ -12,13 +12,13 @@
 #include <memory>
 #include <mutex>
 
+#include <React/Timing.h>
 #include <folly/dynamic.h>
 #include <react/renderer/core/EventDispatcher.h>
 #include <react/renderer/core/EventPayload.h>
 #include <react/renderer/core/EventTarget.h>
 #include <react/renderer/core/ReactPrimitives.h>
 #include <react/renderer/core/ValueFactoryEventPayload.h>
-#include <react/timing/primitives.h>
 
 namespace facebook::react {
 

packages/react-native/ReactCommon/react/renderer/core/EventLogger.h

@@ -9,8 +9,8 @@
 
 #include <react/cxxstableapi/UmbrellaGuard.h>
 
+#include <React/Timing.h>
 #include <react/renderer/core/EventTarget.h>
-#include <react/timing/primitives.h>
 
 #include <optional>
 #include <string_view>

packages/react-native/ReactCommon/react/renderer/core/EventPipe.h

@@ -12,12 +12,12 @@
 #include <functional>
 #include <string>
 
+#include <React/Timing.h>
 #include <jsi/jsi.h>
 #include <react/renderer/core/EventPayload.h>
 #include <react/renderer/core/EventTarget.h>
 #include <react/renderer/core/ReactEventPriority.h>
 #include <react/renderer/core/ValueFactory.h>
-#include <react/timing/primitives.h>
 
 namespace facebook::react {
 

packages/react-native/ReactCommon/react/renderer/core/LayoutConstraints.h

@@ -11,9 +11,9 @@
 
 #include <limits>
 
+#include <React/Utils.h>
 #include <react/renderer/core/LayoutPrimitives.h>
 #include <react/renderer/graphics/Size.h>
-#include <react/utils/hash_combine.h>
 
 namespace facebook::react {
 

packages/react-native/ReactCommon/react/renderer/core/LayoutMetrics.h

@@ -9,12 +9,12 @@
 
 #include <react/cxxstableapi/UmbrellaGuard.h>
 
+#include <React/Utils.h>
 #include <react/renderer/core/LayoutPrimitives.h>
 #include <react/renderer/debug/DebugStringConvertible.h>
 #include <react/renderer/debug/flags.h>
 #include <react/renderer/graphics/Rect.h>
 #include <react/renderer/graphics/RectangleEdges.h>
-#include <react/utils/hash_combine.h>
 #include <algorithm>
 
 namespace facebook::react {