Skip to content

Commit 19a23e7

Browse files
christophpurrermeta-codesync[bot]
christophpurrer
authored and
meta-codesync[bot]
committed
Fix unused parameter warnings in ShadowNode.h (#56519)
Summary: Pull Request resolved: #56519 Fixed clang-diagnostic-unused-parameter warnings in ShadowNode.h by commenting out unused parameter names in the completeClone method. This addresses warnings for parameters `sourceShadowNode` and `fragment` that were declared but not used in the function body. Also applied lint patch to remove redundant `virtual` keyword from the destructor declaration. Changelog: [Internal] Reviewed By: mdvacca Differential Revision: D101108467 fbshipit-source-id: 3c717f27df362e68f308b0e0f119b0fe43e82818
1 parent d655114 commit 19a23e7

7 files changed

Lines changed: 18 additions & 18 deletions

File tree

‎packages/react-native/ReactCommon/react/renderer/core/ShadowNode.h‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ class ShadowNode : public Sealable, public DebugStringConvertible, public jsi::N
8383
ShadowNode(const ShadowNode &shadowNode) noexcept = delete;
8484
ShadowNode &operator=(const ShadowNode &other) noexcept = delete;
8585

86-
virtual ~ShadowNode() override = default;
86+
~ShadowNode() override = default;
8787

8888
/*
8989
* Clones the shadow node using the ShadowNode's ComponentDescriptor.
@@ -118,7 +118,7 @@ class ShadowNode : public Sealable, public DebugStringConvertible, public jsi::N
118118
* Called, once a fully derived ShadowNode clone has been created via
119119
* ComponentDescriptor::cloneShadowNode.
120120
*/
121-
virtual void completeClone(const ShadowNode &sourceShadowNode, const ShadowNodeFragment &fragment) {}
121+
virtual void completeClone(const ShadowNode & /* sourceShadowNode */, const ShadowNodeFragment & /* fragment */) {}
122122

123123
#pragma mark - Getters
124124

‎scripts/cxx-api/api-snapshots/ReactAndroidDebugCxx.api‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4614,14 +4614,14 @@ class facebook::react::ShadowNode : public facebook::react::Sealable, public fac
46144614
public std::shared_ptr<facebook::react::ShadowNode> cloneTree(const facebook::react::ShadowNodeFamily& shadowNodeFamily, const std::function<std::shared_ptr<facebook::react::ShadowNode>(const facebook::react::ShadowNode& oldShadowNode)>& callback) const;
46154615
public using AncestorList = std::vector<std::pair<std::reference_wrapper<const facebook::react::ShadowNode>, int>>;
46164616
public virtual void appendChild(const std::shared_ptr<const facebook::react::ShadowNode>& child);
4617-
public virtual void completeClone(const facebook::react::ShadowNode& sourceShadowNode, const facebook::react::ShadowNodeFragment& fragment);
4617+
public virtual void completeClone(const facebook::react::ShadowNode&, const facebook::react::ShadowNodeFragment&);
46184618
public virtual void replaceChild(const facebook::react::ShadowNode& oldChild, const std::shared_ptr<const facebook::react::ShadowNode>& newChild, size_t suggestedIndex = std::numeric_limits<size_t>::max());
4619-
public virtual ~ShadowNode() override = default;
46204619
public void sealRecursive() const;
46214620
public void setMounted(bool mounted) const;
46224621
public void setRuntimeShadowNodeReference(const std::shared_ptr<facebook::react::ShadowNodeWrapper>& runtimeShadowNodeReference) const;
46234622
public void transferRuntimeShadowNodeReference(const std::shared_ptr<const facebook::react::ShadowNode>& destinationShadowNode, const facebook::react::ShadowNodeFragment& fragment) const;
46244623
public void updateRuntimeShadowNodeReference(const std::shared_ptr<const facebook::react::ShadowNode>& destinationShadowNode) const;
4624+
public ~ShadowNode() override = default;
46254625
}
46264626

46274627
class facebook::react::ShadowNodeFamily : public facebook::jsi::NativeState {
@@ -5478,7 +5478,7 @@ class facebook::react::YogaLayoutableShadowNode : public facebook::react::Layout
54785478
public using Shared = std::shared_ptr<const facebook::react::YogaLayoutableShadowNode>;
54795479
public virtual bool getIsLayoutClean() const override;
54805480
public virtual void appendChild(const std::shared_ptr<const facebook::react::ShadowNode>& child) override;
5481-
public virtual void completeClone(const facebook::react::ShadowNode& sourceShadowNode, const facebook::react::ShadowNodeFragment& fragment) override;
5481+
public virtual void completeClone(const facebook::react::ShadowNode&, const facebook::react::ShadowNodeFragment&) override;
54825482
public virtual void dirtyLayout() override;
54835483
public virtual void layout(facebook::react::LayoutContext layoutContext) override;
54845484
public virtual void layoutTree(facebook::react::LayoutContext layoutContext, facebook::react::LayoutConstraints layoutConstraints) override;

‎scripts/cxx-api/api-snapshots/ReactAndroidReleaseCxx.api‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4605,14 +4605,14 @@ class facebook::react::ShadowNode : public facebook::react::Sealable, public fac
46054605
public std::shared_ptr<facebook::react::ShadowNode> cloneTree(const facebook::react::ShadowNodeFamily& shadowNodeFamily, const std::function<std::shared_ptr<facebook::react::ShadowNode>(const facebook::react::ShadowNode& oldShadowNode)>& callback) const;
46064606
public using AncestorList = std::vector<std::pair<std::reference_wrapper<const facebook::react::ShadowNode>, int>>;
46074607
public virtual void appendChild(const std::shared_ptr<const facebook::react::ShadowNode>& child);
4608-
public virtual void completeClone(const facebook::react::ShadowNode& sourceShadowNode, const facebook::react::ShadowNodeFragment& fragment);
4608+
public virtual void completeClone(const facebook::react::ShadowNode&, const facebook::react::ShadowNodeFragment&);
46094609
public virtual void replaceChild(const facebook::react::ShadowNode& oldChild, const std::shared_ptr<const facebook::react::ShadowNode>& newChild, size_t suggestedIndex = std::numeric_limits<size_t>::max());
4610-
public virtual ~ShadowNode() override = default;
46114610
public void sealRecursive() const;
46124611
public void setMounted(bool mounted) const;
46134612
public void setRuntimeShadowNodeReference(const std::shared_ptr<facebook::react::ShadowNodeWrapper>& runtimeShadowNodeReference) const;
46144613
public void transferRuntimeShadowNodeReference(const std::shared_ptr<const facebook::react::ShadowNode>& destinationShadowNode, const facebook::react::ShadowNodeFragment& fragment) const;
46154614
public void updateRuntimeShadowNodeReference(const std::shared_ptr<const facebook::react::ShadowNode>& destinationShadowNode) const;
4615+
public ~ShadowNode() override = default;
46164616
}
46174617

46184618
class facebook::react::ShadowNodeFamily : public facebook::jsi::NativeState {
@@ -5469,7 +5469,7 @@ class facebook::react::YogaLayoutableShadowNode : public facebook::react::Layout
54695469
public using Shared = std::shared_ptr<const facebook::react::YogaLayoutableShadowNode>;
54705470
public virtual bool getIsLayoutClean() const override;
54715471
public virtual void appendChild(const std::shared_ptr<const facebook::react::ShadowNode>& child) override;
5472-
public virtual void completeClone(const facebook::react::ShadowNode& sourceShadowNode, const facebook::react::ShadowNodeFragment& fragment) override;
5472+
public virtual void completeClone(const facebook::react::ShadowNode&, const facebook::react::ShadowNodeFragment&) override;
54735473
public virtual void dirtyLayout() override;
54745474
public virtual void layout(facebook::react::LayoutContext layoutContext) override;
54755475
public virtual void layoutTree(facebook::react::LayoutContext layoutContext, facebook::react::LayoutConstraints layoutConstraints) override;

‎scripts/cxx-api/api-snapshots/ReactAppleDebugCxx.api‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7198,14 +7198,14 @@ class facebook::react::ShadowNode : public facebook::react::Sealable, public fac
71987198
public std::shared_ptr<facebook::react::ShadowNode> cloneTree(const facebook::react::ShadowNodeFamily& shadowNodeFamily, const std::function<std::shared_ptr<facebook::react::ShadowNode>(const facebook::react::ShadowNode& oldShadowNode)>& callback) const;
71997199
public using AncestorList = std::vector<std::pair<std::reference_wrapper<const facebook::react::ShadowNode>, int>>;
72007200
public virtual void appendChild(const std::shared_ptr<const facebook::react::ShadowNode>& child);
7201-
public virtual void completeClone(const facebook::react::ShadowNode& sourceShadowNode, const facebook::react::ShadowNodeFragment& fragment);
7201+
public virtual void completeClone(const facebook::react::ShadowNode&, const facebook::react::ShadowNodeFragment&);
72027202
public virtual void replaceChild(const facebook::react::ShadowNode& oldChild, const std::shared_ptr<const facebook::react::ShadowNode>& newChild, size_t suggestedIndex = std::numeric_limits<size_t>::max());
7203-
public virtual ~ShadowNode() override = default;
72047203
public void sealRecursive() const;
72057204
public void setMounted(bool mounted) const;
72067205
public void setRuntimeShadowNodeReference(const std::shared_ptr<facebook::react::ShadowNodeWrapper>& runtimeShadowNodeReference) const;
72077206
public void transferRuntimeShadowNodeReference(const std::shared_ptr<const facebook::react::ShadowNode>& destinationShadowNode, const facebook::react::ShadowNodeFragment& fragment) const;
72087207
public void updateRuntimeShadowNodeReference(const std::shared_ptr<const facebook::react::ShadowNode>& destinationShadowNode) const;
7208+
public ~ShadowNode() override = default;
72097209
}
72107210

72117211
class facebook::react::ShadowNodeFamily : public facebook::jsi::NativeState {

‎scripts/cxx-api/api-snapshots/ReactAppleReleaseCxx.api‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7189,14 +7189,14 @@ class facebook::react::ShadowNode : public facebook::react::Sealable, public fac
71897189
public std::shared_ptr<facebook::react::ShadowNode> cloneTree(const facebook::react::ShadowNodeFamily& shadowNodeFamily, const std::function<std::shared_ptr<facebook::react::ShadowNode>(const facebook::react::ShadowNode& oldShadowNode)>& callback) const;
71907190
public using AncestorList = std::vector<std::pair<std::reference_wrapper<const facebook::react::ShadowNode>, int>>;
71917191
public virtual void appendChild(const std::shared_ptr<const facebook::react::ShadowNode>& child);
7192-
public virtual void completeClone(const facebook::react::ShadowNode& sourceShadowNode, const facebook::react::ShadowNodeFragment& fragment);
7192+
public virtual void completeClone(const facebook::react::ShadowNode&, const facebook::react::ShadowNodeFragment&);
71937193
public virtual void replaceChild(const facebook::react::ShadowNode& oldChild, const std::shared_ptr<const facebook::react::ShadowNode>& newChild, size_t suggestedIndex = std::numeric_limits<size_t>::max());
7194-
public virtual ~ShadowNode() override = default;
71957194
public void sealRecursive() const;
71967195
public void setMounted(bool mounted) const;
71977196
public void setRuntimeShadowNodeReference(const std::shared_ptr<facebook::react::ShadowNodeWrapper>& runtimeShadowNodeReference) const;
71987197
public void transferRuntimeShadowNodeReference(const std::shared_ptr<const facebook::react::ShadowNode>& destinationShadowNode, const facebook::react::ShadowNodeFragment& fragment) const;
71997198
public void updateRuntimeShadowNodeReference(const std::shared_ptr<const facebook::react::ShadowNode>& destinationShadowNode) const;
7199+
public ~ShadowNode() override = default;
72007200
}
72017201

72027202
class facebook::react::ShadowNodeFamily : public facebook::jsi::NativeState {

‎scripts/cxx-api/api-snapshots/ReactCommonDebugCxx.api‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3174,14 +3174,14 @@ class facebook::react::ShadowNode : public facebook::react::Sealable, public fac
31743174
public std::shared_ptr<facebook::react::ShadowNode> cloneTree(const facebook::react::ShadowNodeFamily& shadowNodeFamily, const std::function<std::shared_ptr<facebook::react::ShadowNode>(const facebook::react::ShadowNode& oldShadowNode)>& callback) const;
31753175
public using AncestorList = std::vector<std::pair<std::reference_wrapper<const facebook::react::ShadowNode>, int>>;
31763176
public virtual void appendChild(const std::shared_ptr<const facebook::react::ShadowNode>& child);
3177-
public virtual void completeClone(const facebook::react::ShadowNode& sourceShadowNode, const facebook::react::ShadowNodeFragment& fragment);
3177+
public virtual void completeClone(const facebook::react::ShadowNode&, const facebook::react::ShadowNodeFragment&);
31783178
public virtual void replaceChild(const facebook::react::ShadowNode& oldChild, const std::shared_ptr<const facebook::react::ShadowNode>& newChild, size_t suggestedIndex = std::numeric_limits<size_t>::max());
3179-
public virtual ~ShadowNode() override = default;
31803179
public void sealRecursive() const;
31813180
public void setMounted(bool mounted) const;
31823181
public void setRuntimeShadowNodeReference(const std::shared_ptr<facebook::react::ShadowNodeWrapper>& runtimeShadowNodeReference) const;
31833182
public void transferRuntimeShadowNodeReference(const std::shared_ptr<const facebook::react::ShadowNode>& destinationShadowNode, const facebook::react::ShadowNodeFragment& fragment) const;
31843183
public void updateRuntimeShadowNodeReference(const std::shared_ptr<const facebook::react::ShadowNode>& destinationShadowNode) const;
3184+
public ~ShadowNode() override = default;
31853185
}
31863186

31873187
class facebook::react::ShadowNodeFamily : public facebook::jsi::NativeState {
@@ -3893,7 +3893,7 @@ class facebook::react::YogaLayoutableShadowNode : public facebook::react::Layout
38933893
public using Shared = std::shared_ptr<const facebook::react::YogaLayoutableShadowNode>;
38943894
public virtual bool getIsLayoutClean() const override;
38953895
public virtual void appendChild(const std::shared_ptr<const facebook::react::ShadowNode>& child) override;
3896-
public virtual void completeClone(const facebook::react::ShadowNode& sourceShadowNode, const facebook::react::ShadowNodeFragment& fragment) override;
3896+
public virtual void completeClone(const facebook::react::ShadowNode&, const facebook::react::ShadowNodeFragment&) override;
38973897
public virtual void dirtyLayout() override;
38983898
public virtual void layout(facebook::react::LayoutContext layoutContext) override;
38993899
public virtual void layoutTree(facebook::react::LayoutContext layoutContext, facebook::react::LayoutConstraints layoutConstraints) override;

‎scripts/cxx-api/api-snapshots/ReactCommonReleaseCxx.api‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3165,14 +3165,14 @@ class facebook::react::ShadowNode : public facebook::react::Sealable, public fac
31653165
public std::shared_ptr<facebook::react::ShadowNode> cloneTree(const facebook::react::ShadowNodeFamily& shadowNodeFamily, const std::function<std::shared_ptr<facebook::react::ShadowNode>(const facebook::react::ShadowNode& oldShadowNode)>& callback) const;
31663166
public using AncestorList = std::vector<std::pair<std::reference_wrapper<const facebook::react::ShadowNode>, int>>;
31673167
public virtual void appendChild(const std::shared_ptr<const facebook::react::ShadowNode>& child);
3168-
public virtual void completeClone(const facebook::react::ShadowNode& sourceShadowNode, const facebook::react::ShadowNodeFragment& fragment);
3168+
public virtual void completeClone(const facebook::react::ShadowNode&, const facebook::react::ShadowNodeFragment&);
31693169
public virtual void replaceChild(const facebook::react::ShadowNode& oldChild, const std::shared_ptr<const facebook::react::ShadowNode>& newChild, size_t suggestedIndex = std::numeric_limits<size_t>::max());
3170-
public virtual ~ShadowNode() override = default;
31713170
public void sealRecursive() const;
31723171
public void setMounted(bool mounted) const;
31733172
public void setRuntimeShadowNodeReference(const std::shared_ptr<facebook::react::ShadowNodeWrapper>& runtimeShadowNodeReference) const;
31743173
public void transferRuntimeShadowNodeReference(const std::shared_ptr<const facebook::react::ShadowNode>& destinationShadowNode, const facebook::react::ShadowNodeFragment& fragment) const;
31753174
public void updateRuntimeShadowNodeReference(const std::shared_ptr<const facebook::react::ShadowNode>& destinationShadowNode) const;
3175+
public ~ShadowNode() override = default;
31763176
}
31773177

31783178
class facebook::react::ShadowNodeFamily : public facebook::jsi::NativeState {
@@ -3884,7 +3884,7 @@ class facebook::react::YogaLayoutableShadowNode : public facebook::react::Layout
38843884
public using Shared = std::shared_ptr<const facebook::react::YogaLayoutableShadowNode>;
38853885
public virtual bool getIsLayoutClean() const override;
38863886
public virtual void appendChild(const std::shared_ptr<const facebook::react::ShadowNode>& child) override;
3887-
public virtual void completeClone(const facebook::react::ShadowNode& sourceShadowNode, const facebook::react::ShadowNodeFragment& fragment) override;
3887+
public virtual void completeClone(const facebook::react::ShadowNode&, const facebook::react::ShadowNodeFragment&) override;
38883888
public virtual void dirtyLayout() override;
38893889
public virtual void layout(facebook::react::LayoutContext layoutContext) override;
38903890
public virtual void layoutTree(facebook::react::LayoutContext layoutContext, facebook::react::LayoutConstraints layoutConstraints) override;

0 commit comments

Comments
 (0)