Skip to content

Commit 0da7e06

Browse files
cortinicokelset
cortinico
authored and
kelset
committed
Remove CallInvoker parameter from toJs method in Codegen (#37832)
Summary: Pull Request resolved: #37832 This parameter is currently unused and is causing Android builds to fail as they compile with `-Wall` This is a follow-up to #37454 as that PR updated only the `fromJs` and not the `toJs` method as well. Changelog: [Internal] [Changed] - Remove CallInvoker parameter from toJs method in Codegen Reviewed By: rshest Differential Revision: D46647110 fbshipit-source-id: 1f3e22aca7a3df11ac02b5c4b89c9311b8b1798c
1 parent 2d15f50 commit 0da7e06

3 files changed

Lines changed: 15 additions & 15 deletions

File tree

‎packages/react-native-codegen/e2e/__tests__/modules/__snapshots__/GenerateModuleH-test.js.snap‎

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -206,7 +206,7 @@ struct Bridging<NativeEnumTurboModuleStatusRegularEnum> {
206206
}
207207
}
208208

209-
static jsi::String toJs(jsi::Runtime &rt, NativeEnumTurboModuleStatusRegularEnum value, const std::shared_ptr<CallInvoker> &jsInvoker) {
209+
static jsi::String toJs(jsi::Runtime &rt, NativeEnumTurboModuleStatusRegularEnum value) {
210210
if (value == NativeEnumTurboModuleStatusRegularEnum::Active) {
211211
return bridging::toJs(rt, \\"Active\\");
212212
} else if (value == NativeEnumTurboModuleStatusRegularEnum::Paused) {
@@ -238,7 +238,7 @@ struct Bridging<NativeEnumTurboModuleStatusStrEnum> {
238238
}
239239
}
240240

241-
static jsi::String toJs(jsi::Runtime &rt, NativeEnumTurboModuleStatusStrEnum value, const std::shared_ptr<CallInvoker> &jsInvoker) {
241+
static jsi::String toJs(jsi::Runtime &rt, NativeEnumTurboModuleStatusStrEnum value) {
242242
if (value == NativeEnumTurboModuleStatusStrEnum::Active) {
243243
return bridging::toJs(rt, \\"active\\");
244244
} else if (value == NativeEnumTurboModuleStatusStrEnum::Paused) {
@@ -270,7 +270,7 @@ struct Bridging<NativeEnumTurboModuleStatusNumEnum> {
270270
}
271271
}
272272

273-
static jsi::Value toJs(jsi::Runtime &rt, NativeEnumTurboModuleStatusNumEnum value, const std::shared_ptr<CallInvoker> &jsInvoker) {
273+
static jsi::Value toJs(jsi::Runtime &rt, NativeEnumTurboModuleStatusNumEnum value) {
274274
if (value == NativeEnumTurboModuleStatusNumEnum::Active) {
275275
return bridging::toJs(rt, 2);
276276
} else if (value == NativeEnumTurboModuleStatusNumEnum::Paused) {
@@ -302,7 +302,7 @@ struct Bridging<NativeEnumTurboModuleStatusFractionEnum> {
302302
}
303303
}
304304

305-
static jsi::Value toJs(jsi::Runtime &rt, NativeEnumTurboModuleStatusFractionEnum value, const std::shared_ptr<CallInvoker> &jsInvoker) {
305+
static jsi::Value toJs(jsi::Runtime &rt, NativeEnumTurboModuleStatusFractionEnum value) {
306306
if (value == NativeEnumTurboModuleStatusFractionEnum::Active) {
307307
return bridging::toJs(rt, 0.2f);
308308
} else if (value == NativeEnumTurboModuleStatusFractionEnum::Paused) {
@@ -2149,7 +2149,7 @@ struct Bridging<NativeEnumTurboModuleStatusRegularEnum> {
21492149
}
21502150
}
21512151

2152-
static jsi::String toJs(jsi::Runtime &rt, NativeEnumTurboModuleStatusRegularEnum value, const std::shared_ptr<CallInvoker> &jsInvoker) {
2152+
static jsi::String toJs(jsi::Runtime &rt, NativeEnumTurboModuleStatusRegularEnum value) {
21532153
if (value == NativeEnumTurboModuleStatusRegularEnum::Active) {
21542154
return bridging::toJs(rt, \\"Active\\");
21552155
} else if (value == NativeEnumTurboModuleStatusRegularEnum::Paused) {
@@ -2181,7 +2181,7 @@ struct Bridging<NativeEnumTurboModuleStatusStrEnum> {
21812181
}
21822182
}
21832183

2184-
static jsi::String toJs(jsi::Runtime &rt, NativeEnumTurboModuleStatusStrEnum value, const std::shared_ptr<CallInvoker> &jsInvoker) {
2184+
static jsi::String toJs(jsi::Runtime &rt, NativeEnumTurboModuleStatusStrEnum value) {
21852185
if (value == NativeEnumTurboModuleStatusStrEnum::Active) {
21862186
return bridging::toJs(rt, \\"active\\");
21872187
} else if (value == NativeEnumTurboModuleStatusStrEnum::Paused) {
@@ -2213,7 +2213,7 @@ struct Bridging<NativeEnumTurboModuleStatusNumEnum> {
22132213
}
22142214
}
22152215

2216-
static jsi::Value toJs(jsi::Runtime &rt, NativeEnumTurboModuleStatusNumEnum value, const std::shared_ptr<CallInvoker> &jsInvoker) {
2216+
static jsi::Value toJs(jsi::Runtime &rt, NativeEnumTurboModuleStatusNumEnum value) {
22172217
if (value == NativeEnumTurboModuleStatusNumEnum::Active) {
22182218
return bridging::toJs(rt, 2);
22192219
} else if (value == NativeEnumTurboModuleStatusNumEnum::Paused) {
@@ -2245,7 +2245,7 @@ struct Bridging<NativeEnumTurboModuleStatusFractionEnum> {
22452245
}
22462246
}
22472247

2248-
static jsi::Value toJs(jsi::Runtime &rt, NativeEnumTurboModuleStatusFractionEnum value, const std::shared_ptr<CallInvoker> &jsInvoker) {
2248+
static jsi::Value toJs(jsi::Runtime &rt, NativeEnumTurboModuleStatusFractionEnum value) {
22492249
if (value == NativeEnumTurboModuleStatusFractionEnum::Active) {
22502250
return bridging::toJs(rt, 0.2f);
22512251
} else if (value == NativeEnumTurboModuleStatusFractionEnum::Paused) {

‎packages/react-native-codegen/src/generators/modules/GenerateModuleH.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -343,7 +343,7 @@ struct Bridging<${enumName}> {
343343
${fromCases}
344344
}
345345
346-
static ${toValue} toJs(jsi::Runtime &rt, ${enumName} value, const std::shared_ptr<CallInvoker> &jsInvoker) {
346+
static ${toValue} toJs(jsi::Runtime &rt, ${enumName} value) {
347347
${toCases}
348348
}
349349
};`;

‎packages/react-native-codegen/src/generators/modules/__tests__/__snapshots__/GenerateModuleH-test.js.snap‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -222,7 +222,7 @@ struct Bridging<SampleTurboModuleCxxNumEnum> {
222222
}
223223
}
224224

225-
static jsi::Value toJs(jsi::Runtime &rt, SampleTurboModuleCxxNumEnum value, const std::shared_ptr<CallInvoker> &jsInvoker) {
225+
static jsi::Value toJs(jsi::Runtime &rt, SampleTurboModuleCxxNumEnum value) {
226226
if (value == SampleTurboModuleCxxNumEnum::ONE) {
227227
return bridging::toJs(rt, 1);
228228
} else if (value == SampleTurboModuleCxxNumEnum::TWO) {
@@ -252,7 +252,7 @@ struct Bridging<SampleTurboModuleCxxFloatEnum> {
252252
}
253253
}
254254

255-
static jsi::Value toJs(jsi::Runtime &rt, SampleTurboModuleCxxFloatEnum value, const std::shared_ptr<CallInvoker> &jsInvoker) {
255+
static jsi::Value toJs(jsi::Runtime &rt, SampleTurboModuleCxxFloatEnum value) {
256256
if (value == SampleTurboModuleCxxFloatEnum::POINT_ZERO) {
257257
return bridging::toJs(rt, 0.0f);
258258
} else if (value == SampleTurboModuleCxxFloatEnum::POINT_ONE) {
@@ -282,7 +282,7 @@ struct Bridging<SampleTurboModuleCxxStringEnum> {
282282
}
283283
}
284284

285-
static jsi::String toJs(jsi::Runtime &rt, SampleTurboModuleCxxStringEnum value, const std::shared_ptr<CallInvoker> &jsInvoker) {
285+
static jsi::String toJs(jsi::Runtime &rt, SampleTurboModuleCxxStringEnum value) {
286286
if (value == SampleTurboModuleCxxStringEnum::HELLO) {
287287
return bridging::toJs(rt, \\"hello\\");
288288
} else if (value == SampleTurboModuleCxxStringEnum::GoodBye) {
@@ -1220,7 +1220,7 @@ struct Bridging<SampleTurboModuleNumEnum> {
12201220
}
12211221
}
12221222

1223-
static jsi::Value toJs(jsi::Runtime &rt, SampleTurboModuleNumEnum value, const std::shared_ptr<CallInvoker> &jsInvoker) {
1223+
static jsi::Value toJs(jsi::Runtime &rt, SampleTurboModuleNumEnum value) {
12241224
if (value == SampleTurboModuleNumEnum::ONE) {
12251225
return bridging::toJs(rt, 1);
12261226
} else if (value == SampleTurboModuleNumEnum::TWO) {
@@ -1250,7 +1250,7 @@ struct Bridging<SampleTurboModuleFloatEnum> {
12501250
}
12511251
}
12521252

1253-
static jsi::Value toJs(jsi::Runtime &rt, SampleTurboModuleFloatEnum value, const std::shared_ptr<CallInvoker> &jsInvoker) {
1253+
static jsi::Value toJs(jsi::Runtime &rt, SampleTurboModuleFloatEnum value) {
12541254
if (value == SampleTurboModuleFloatEnum::POINT_ZERO) {
12551255
return bridging::toJs(rt, 0.0f);
12561256
} else if (value == SampleTurboModuleFloatEnum::POINT_ONE) {
@@ -1280,7 +1280,7 @@ struct Bridging<SampleTurboModuleStringEnum> {
12801280
}
12811281
}
12821282

1283-
static jsi::String toJs(jsi::Runtime &rt, SampleTurboModuleStringEnum value, const std::shared_ptr<CallInvoker> &jsInvoker) {
1283+
static jsi::String toJs(jsi::Runtime &rt, SampleTurboModuleStringEnum value) {
12841284
if (value == SampleTurboModuleStringEnum::HELLO) {
12851285
return bridging::toJs(rt, \\"hello\\");
12861286
} else if (value == SampleTurboModuleStringEnum::GoodBye) {

0 commit comments

Comments
 (0)