-
Notifications
You must be signed in to change notification settings - Fork 482
Open
Labels
Description
Proposal
It seems starting from v3, we are using pre-compiled frameworks for iOS and macOS builds.
However, the library is only shipped with the following:
- macos-arm64_x86_64 (native macOS)
- ios-arm64_x86_64-simulator
- ios-arm64
To build for Mac Catalyst which is a special iOS target, we would need a framework built for ios-arm64_x86_64-maccatalyst.
v2 had support for Mac Catalyst out of the box, probably due to it being built from source. Could we add Mac Catalyst support to v3 as well? Thanks!
Alternatives
No response
Implementation Details
Same as the native macOS macos-arm64_x86_64 build, the framework probably needs to be symlinked, like
async-storage/scripts/build-native-lib.sh
Lines 57 to 66 in 079c767
| # symlinks | |
| rm "$MAC_OS_FRAMEWORK/Headers" "$MAC_OS_FRAMEWORK/Modules" "$MAC_OS_FRAMEWORK/Resources" "$MAC_OS_FRAMEWORK/SharedAsyncStorage" | |
| cp -rL "$MAC_OS_FRAMEWORK/Versions/A/Headers" "$MAC_OS_FRAMEWORK/" | |
| cp -rL "$MAC_OS_FRAMEWORK/Versions/A/Modules" "$MAC_OS_FRAMEWORK/" | |
| cp -rL "$MAC_OS_FRAMEWORK/Versions/A/Resources" "$MAC_OS_FRAMEWORK/" | |
| cp -L "$MAC_OS_FRAMEWORK/Versions/A/SharedAsyncStorage" "$MAC_OS_FRAMEWORK/" | |
| # clear versions, not needed | |
| rm -r "$MAC_OS_FRAMEWORK/Versions" |
Additional Context
No response
Reactions are currently unavailable