|
24 | 24 | import sqlite3 as sqlite |
25 | 25 | import unittest |
26 | 26 |
|
27 | | -from test.support import captured_stderr, force_not_colorized, import_helper |
| 27 | +from test.support import import_helper |
28 | 28 | from test.support.os_helper import TESTFN, unlink |
29 | 29 |
|
30 | 30 | from .util import memory_database, cx_limit, with_tracebacks |
@@ -106,50 +106,6 @@ def mycoll(x, y): |
106 | 106 | self.assertEqual(result, [('c',), ('b',), ('a',)], |
107 | 107 | msg="the expected order was not returned") |
108 | 108 |
|
109 | | - @force_not_colorized |
110 | | - def test_collation_error_then_step_failure_while_fetching(self): |
111 | | - # gh-161837: A collation can set an exception. Then a later error can |
112 | | - # make the same sqlite3_step() fail. The fetch must raise |
113 | | - # OperationalError for that failure, not SystemError. |
114 | | - def mycoll(x, y): |
115 | | - if x == "boom": |
116 | | - raise KeyError("collation raised") |
117 | | - return (x > y) - (x < y) |
118 | | - self.con.create_collation("mycoll", mycoll) |
119 | | - self.con.execute("create table t(x, y)") |
120 | | - # abs() of the smallest 64-bit integer causes "integer overflow". |
121 | | - self.con.executemany("insert into t values (?, ?)", |
122 | | - [(1, "a"), (-2**63, "boom")]) |
123 | | - sql = """ |
124 | | - select case when y = 'q' collate mycoll then abs(x) else 0 end |
125 | | - from t order by rowid |
126 | | - """ |
127 | | - |
128 | | - def fetch_with_fetchone(): |
129 | | - cur = self.con.execute(sql) |
130 | | - self.assertEqual(cur.fetchone(), (0,)) |
131 | | - cur.fetchone() |
132 | | - |
133 | | - def fetch_by_iteration(): |
134 | | - list(self.con.execute(sql)) |
135 | | - |
136 | | - for fetch in fetch_with_fetchone, fetch_by_iteration: |
137 | | - for tracebacks in False, True: |
138 | | - with self.subTest(fetch=fetch.__name__, tracebacks=tracebacks): |
139 | | - sqlite.enable_callback_tracebacks(tracebacks) |
140 | | - try: |
141 | | - with captured_stderr() as err: |
142 | | - with self.assertRaisesRegex(sqlite.OperationalError, |
143 | | - "integer overflow"): |
144 | | - fetch() |
145 | | - finally: |
146 | | - sqlite.enable_callback_tracebacks(False) |
147 | | - if tracebacks: |
148 | | - self.assertIn("KeyError: 'collation raised'", |
149 | | - err.getvalue()) |
150 | | - else: |
151 | | - self.assertEqual(err.getvalue(), "") |
152 | | - |
153 | 109 | def test_collation_register_twice(self): |
154 | 110 | """ |
155 | 111 | Register two different collation functions under the same name. |
@@ -192,6 +148,83 @@ def test_deregister_collation(self): |
192 | 148 | self.assertEqual(str(cm.exception), 'no such collation sequence: mycoll') |
193 | 149 |
|
194 | 150 |
|
| 151 | +class CollationErrorTests(MemoryDatabaseMixin, unittest.TestCase): |
| 152 | + # gh-161837: A collation callback cannot report an error to SQLite, so |
| 153 | + # the exception stays set while SQLite continues the step. |
| 154 | + |
| 155 | + # When the collation raises, the comparison is true, so abs() of the |
| 156 | + # smallest 64-bit integer causes "integer overflow". |
| 157 | + step_fails = """ |
| 158 | + select case when y = 'q' collate mycoll then abs(x) else 0 end |
| 159 | + from t order by rowid |
| 160 | + """ |
| 161 | + step_succeeds = "select x, y = 'q' collate mycoll from t order by rowid" |
| 162 | + # The cursor reads one row ahead, so the first fetch steps to the |
| 163 | + # second row, where the collation raises. |
| 164 | + |
| 165 | + def setUp(self): |
| 166 | + super().setUp() |
| 167 | + def mycoll(x, y): |
| 168 | + if x == "boom": |
| 169 | + raise KeyError("collation raised") |
| 170 | + return (x > y) - (x < y) |
| 171 | + self.con.create_collation("mycoll", mycoll) |
| 172 | + self.con.execute("create table t(x, y)") |
| 173 | + self.con.executemany("insert into t values (?, ?)", |
| 174 | + [(1, "a"), (-2**63, "boom")]) |
| 175 | + |
| 176 | + @with_tracebacks(KeyError, regex="collation raised", |
| 177 | + msg_regex="sqlite3 callback") |
| 178 | + def test_step_failure_in_execute(self): |
| 179 | + with self.assertRaisesRegex(sqlite.OperationalError, |
| 180 | + "integer overflow"): |
| 181 | + self.con.execute(self.step_fails + " desc") |
| 182 | + |
| 183 | + @with_tracebacks(KeyError, regex="collation raised", |
| 184 | + msg_regex="sqlite3 callback") |
| 185 | + def test_step_failure_in_fetchone(self): |
| 186 | + cur = self.con.execute(self.step_fails) |
| 187 | + with self.assertRaisesRegex(sqlite.OperationalError, |
| 188 | + "integer overflow"): |
| 189 | + cur.fetchone() |
| 190 | + self.assertIsNone(cur.fetchone()) |
| 191 | + |
| 192 | + @with_tracebacks(KeyError, regex="collation raised", |
| 193 | + msg_regex="sqlite3 callback") |
| 194 | + def test_step_failure_in_iteration(self): |
| 195 | + with self.assertRaisesRegex(sqlite.OperationalError, |
| 196 | + "integer overflow"): |
| 197 | + list(self.con.execute(self.step_fails)) |
| 198 | + |
| 199 | + @with_tracebacks(KeyError, regex="collation raised", |
| 200 | + msg_regex="sqlite3 callback") |
| 201 | + def test_step_failure_in_executescript(self): |
| 202 | + with self.assertRaisesRegex(sqlite.OperationalError, |
| 203 | + "integer overflow"): |
| 204 | + self.con.executescript(self.step_fails) |
| 205 | + |
| 206 | + def test_error_in_fetchone(self): |
| 207 | + cur = self.con.execute(self.step_succeeds) |
| 208 | + with self.assertRaisesRegex(KeyError, "collation raised"): |
| 209 | + cur.fetchone() |
| 210 | + self.assertIsNone(cur.fetchone()) |
| 211 | + self.assertEqual(cur.execute("select 1").fetchone(), (1,)) |
| 212 | + |
| 213 | + def test_error_in_iteration(self): |
| 214 | + rows = [] |
| 215 | + with self.assertRaisesRegex(KeyError, "collation raised"): |
| 216 | + for row in self.con.execute(self.step_succeeds): |
| 217 | + rows.append(row) |
| 218 | + self.assertEqual(rows, []) |
| 219 | + |
| 220 | + def test_error_in_executescript(self): |
| 221 | + with self.assertRaisesRegex(KeyError, "collation raised"): |
| 222 | + self.con.executescript(self.step_succeeds + "; create table u(x)") |
| 223 | + # The script stops after the statement that caused the error. |
| 224 | + with self.assertRaisesRegex(sqlite.OperationalError, "no such table"): |
| 225 | + self.con.execute("select * from u") |
| 226 | + |
| 227 | + |
195 | 228 | class AuthorizerTests(MemoryDatabaseMixin, unittest.TestCase): |
196 | 229 |
|
197 | 230 | def assert_not_authorized(self, func, /, *args, **kwargs): |
|
0 commit comments