Skip to content

Commit 4faf413

Browse files
[3.14] gh-162034: Quote the utils.sh path in the Apple testbed build phase (GH-162035) (#162090)
Modifies the iOS testbed to ensure that the path to the `utils.sh` script is quoted so that spaces in the path don't prevent the script from operating. (cherry picked from commit ea678b2) Co-authored-by: Ferdinando Ametrano <fametrano@users.noreply.github.com>
1 parent b92dbe9 commit 4faf413

4 files changed

Lines changed: 5 additions & 3 deletions

File tree

‎Apple/testbed/Python.xcframework/build/utils.sh‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
# * There is an `app_packages` folder that contains installed Python packages.
1515
# -----
1616
# set -e
17-
# source $PROJECT_DIR/Python.xcframework/build/build_utils.sh
17+
# source "$PROJECT_DIR/Python.xcframework/build/utils.sh"
1818
# install_python Python.xcframework app app_packages
1919
# -----
2020

‎Apple/testbed/iOSTestbed.xcodeproj/project.pbxproj‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -250,7 +250,7 @@
250250
);
251251
runOnlyForDeploymentPostprocessing = 0;
252252
shellPath = /bin/sh;
253-
shellScript = "set -e\nsource $PROJECT_DIR/Python.xcframework/build/utils.sh\ninstall_python Python.xcframework app app_packages\n";
253+
shellScript = "set -e\nsource \"$PROJECT_DIR/Python.xcframework/build/utils.sh\"\ninstall_python Python.xcframework app app_packages\n";
254254
showEnvVarsInLog = 0;
255255
};
256256
/* End PBXShellScriptBuildPhase section */

‎Doc/using/ios.rst‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -219,7 +219,7 @@ To add Python to an iOS Xcode project:
219219
.. code-block:: bash
220220
221221
set -e
222-
source $PROJECT_DIR/Python.xcframework/build/build_utils.sh
222+
source "$PROJECT_DIR/Python.xcframework/build/utils.sh"
223223
install_python Python.xcframework app
224224
225225
If you have placed your XCframework somewhere other than the root of your
Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
The Apple testbed projects now build when the path of the project contains a
2+
space.

0 commit comments

Comments
 (0)