Commit 09c98be
committed
gh-153677: Fix ValueError in http.cookiejar.http2time() for a strict-format fake month
The STRICT_DATE_RE fast path in http2time() matched date strings whose
month field fit the pattern but named a non-existent month (for example
"Foo"), then called MONTHS_LOWER.index() which raised a raw ValueError.
The documented contract is to return None for unrecognized formats, and
the slower parser already does so. Guard the fast-path month lookup and
fall through to the slower parser on failure.1 parent 832bc0b commit 09c98be
3 files changed
Lines changed: 18 additions & 4 deletions
File tree
- Lib
- http
- test
- Misc/NEWS.d/next/Library
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
262 | 262 | | |
263 | 263 | | |
264 | 264 | | |
265 | | - | |
266 | | - | |
267 | | - | |
268 | | - | |
| 265 | + | |
| 266 | + | |
| 267 | + | |
| 268 | + | |
| 269 | + | |
| 270 | + | |
| 271 | + | |
| 272 | + | |
| 273 | + | |
| 274 | + | |
269 | 275 | | |
270 | 276 | | |
271 | 277 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
121 | 121 | | |
122 | 122 | | |
123 | 123 | | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
124 | 129 | | |
125 | 130 | | |
126 | 131 | | |
| |||
Lines changed: 3 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
0 commit comments