Skip to content

Commit 08a032b

Browse files
committed
Fix additional changes (missed in last commit)
1 parent a6de334 commit 08a032b

13 files changed

Lines changed: 10 additions & 64 deletions

File tree

.azure-pipelines/windows-layout-steps.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ steps:
1212
displayName: Show layout info (${{ parameters.kind }})
1313

1414
- ${{ if eq(parameters.fulltest, 'true') }}:
15-
- script: .\python.exe -m test -q -uall -u-cpu -rwW --slowest --timeout=1200 -j0 --junit-xml="$(Build.BinariesDirectory)\test-results-${{ parameters.kind }}.xml" --tempdir "$(Build.BinariesDirectory)\tmp-${{ parameters.kind }}-$(arch)" -i test_launcher
15+
- script: .\python.exe -m test -q -uall -u-cpu -rwW --slowest --timeout=1200 -j0 --junit-xml="$(Build.BinariesDirectory)\test-results-${{ parameters.kind }}.xml" --tempdir "$(Build.BinariesDirectory)\tmp-${{ parameters.kind }}-$(arch)"
1616
workingDirectory: $(Build.BinariesDirectory)\layout-${{ parameters.kind }}-$(arch)
1717
displayName: ${{ parameters.kind }} Tests
1818
env:

.gitattributes

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
*.zip binary
2020

2121
# Specific binary files
22-
PC/classicAppCompat.* binary
22+
# -- None right now --
2323

2424
# Text files that should not be subject to eol conversion
2525
[attr]noeol -text

.github/CODEOWNERS

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -188,12 +188,8 @@ Tools/wasm/wasi @brettcannon @emmatyping @savannahostrowski
188188
PC/ @python/windows-team
189189
PCbuild/ @python/windows-team
190190

191-
# Windows installer packages
192-
Tools/msi/ @python/windows-team
193-
Tools/nuget/ @python/windows-team
194-
195-
# Windows Launcher
196-
PC/launcher.c @python/windows-team @vsajip
191+
# Windows Venv launcher/redirector
192+
PC/venvlauncher.c @python/windows-team @vsajip
197193

198194

199195
# ----------------------------------------------------------------------------

.gitignore

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ gmon.out
5050

5151
*.exe
5252

53-
# Ignore core dumps... but not Tools/msi/core/ or the like.
53+
# Ignore core dumps... but not .../core/ subdirectories
5454
core
5555
!core/
5656

@@ -158,7 +158,6 @@ Tools/unicode/data/
158158
/coverage/
159159
/externals/
160160
/htmlcov/
161-
Tools/msi/obj
162161
Tools/ssl/amd64
163162
Tools/ssl/win32
164163
Tools/freeze/test/outdir

Include/internal/pycore_magic_number.h

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -310,9 +310,6 @@ Known values:
310310
You should always use the *upcoming* tag. For example, if 3.12a6 came out
311311
a week ago, I should put "Python 3.12a7" next to my new magic number.
312312
313-
Whenever PYC_MAGIC_NUMBER is changed, the ranges in the magic_values array in
314-
PC/launcher.c must also be updated.
315-
316313
*/
317314

318315
#define PYC_MAGIC_NUMBER 3704

InternalDocs/interpreter.md

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -307,9 +307,7 @@ With a new bytecode you must also change what is called the "magic number" for
307307
.pyc files: bump the value of the variable `MAGIC_NUMBER` in
308308
[`Lib/importlib/_bootstrap_external.py`](../Lib/importlib/_bootstrap_external.py).
309309
Changing this number will lead to all .pyc files with the old `MAGIC_NUMBER`
310-
to be recompiled by the interpreter on import. Whenever `MAGIC_NUMBER` is
311-
changed, the ranges in the `magic_values` array in
312-
[`PC/launcher.c`](../PC/launcher.c) may also need to be updated. Changes to
310+
to be recompiled by the interpreter on import. Changes to
313311
[`Lib/importlib/_bootstrap_external.py`](../Lib/importlib/_bootstrap_external.py)
314312
will take effect only after running `make regen-importlib`.
315313

Lib/test/test_tools/test_compute_changes.py

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -109,15 +109,6 @@ def test_unix(self):
109109
self.assertTrue(result.run_tests)
110110
self.assertFalse(result.run_windows_tests)
111111

112-
def test_msi(self):
113-
for f in (
114-
".github/workflows/reusable-windows-msi.yml",
115-
"Tools/msi/build.bat",
116-
):
117-
with self.subTest(f=f):
118-
result = process_changed_files({Path(f)})
119-
self.assertTrue(result.run_windows_msi)
120-
121112
def test_all_run(self):
122113
for f in (
123114
".github/workflows/some-new-workflow.yml",

PCbuild/readme.txt

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -140,12 +140,6 @@ CPython in different ways:
140140
pythonw
141141
pythonw.exe, a variant of python.exe that doesn't open a Command
142142
Prompt window
143-
pylauncher
144-
py.exe, the Python Launcher for Windows, see
145-
https://docs.python.org/3/using/windows.html#launcher
146-
pywlauncher
147-
pyw.exe, a variant of py.exe that doesn't open a Command Prompt
148-
window
149143
_testembed
150144
_testembed.exe, a small program that embeds Python for testing
151145
purposes, used by test_capi.py
@@ -156,8 +150,6 @@ _freeze_module
156150
_freeze_module.exe, used to regenerate frozen modules in Python
157151
after changes have been made to the corresponding source files
158152
(e.g. Lib\importlib\_bootstrap.py).
159-
pyshellext
160-
pyshellext.dll, the shell extension deployed with the launcher
161153
python3dll
162154
python3.dll, the PEP 384 Stable ABI dll
163155
(not installed on free-threaded builds)

PCbuild/venvlauncher.vcxproj

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -109,9 +109,6 @@
109109
<ItemGroup>
110110
<ClCompile Include="..\PC\venvlauncher.c" />
111111
</ItemGroup>
112-
<ItemGroup>
113-
<None Include="..\PC\icons\launcher.ico" />
114-
</ItemGroup>
115112
<ItemGroup>
116113
<ResourceCompile Include="..\PC\python_exe.rc" />
117114
</ItemGroup>

PCbuild/venvlauncher.vcxproj.filters

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -9,12 +9,7 @@
99
</Filter>
1010
</ItemGroup>
1111
<ItemGroup>
12-
<None Include="..\PC\icons\launcher.ico">
13-
<Filter>Resource Files</Filter>
14-
</None>
15-
</ItemGroup>
16-
<ItemGroup>
17-
<ResourceCompile Include="..\PC\pylauncher.rc">
12+
<ResourceCompile Include="..\PC\python_exe.rc">
1813
<Filter>Resource Files</Filter>
1914
</ResourceCompile>
2015
</ItemGroup>

0 commit comments

Comments
 (0)