From 2cf6ae8b4a96c017627332cbe0fc746b35d34520 Mon Sep 17 00:00:00 2001
From: RDaxini <rajivdaxini@msn.com>
Date: Tue, 25 Feb 2025 15:59:30 -0700
Subject: [PATCH 1/4] correct keys

---
 pvlib/spectrum/mismatch.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/pvlib/spectrum/mismatch.py b/pvlib/spectrum/mismatch.py
index 3afc210e73..239faeb735 100644
--- a/pvlib/spectrum/mismatch.py
+++ b/pvlib/spectrum/mismatch.py
@@ -576,8 +576,8 @@ def spectral_factor_pvspec(airmass_absolute, clearsky_index,
     _coefficients = {}
     _coefficients['multisi'] = (0.9847, -0.05237, 0.03034)
     _coefficients['monosi'] = (0.9845, -0.05169, 0.03034)
-    _coefficients['fs-2'] = (1.002, -0.07108, 0.02465)
-    _coefficients['fs-4'] = (0.9981, -0.05776, 0.02336)
+    _coefficients['fs4-2'] = (1.002, -0.07108, 0.02465)
+    _coefficients['fs4-1'] = (0.9981, -0.05776, 0.02336)
     _coefficients['cigs'] = (0.9791, -0.03904, 0.03096)
     _coefficients['asi'] = (1.051, -0.1033, 0.009838)
 

From c62a4ecba2a67910d36fb70173cefec5513b6c2c Mon Sep 17 00:00:00 2001
From: RDaxini <rajivdaxini@msn.com>
Date: Tue, 25 Feb 2025 16:03:53 -0700
Subject: [PATCH 2/4] Update v0.11.3.rst

---
 docs/sphinx/source/whatsnew/v0.11.3.rst | 1 +
 1 file changed, 1 insertion(+)

diff --git a/docs/sphinx/source/whatsnew/v0.11.3.rst b/docs/sphinx/source/whatsnew/v0.11.3.rst
index 6363275fd2..abb9f68cc1 100644
--- a/docs/sphinx/source/whatsnew/v0.11.3.rst
+++ b/docs/sphinx/source/whatsnew/v0.11.3.rst
@@ -16,6 +16,7 @@ Enhancements
   ground irradiance when the sun was below the horizon. (:issue:`2245`, :pull:`2359`)
 * Fix a bug where :py:func:`pvlib.transformer.simple_efficiency` could only be imported
   using the `from pvlib.transformer` syntax (:pull:`2388`)
+* Correct keys for First Solar modules in `~pvlib.spectrum.spectral_factor_pvspec` (:issue:`2398`, :pull:`2400`)
 
 Documentation
 ~~~~~~~~~~~~~

From fbcc3b10028310672202fd42986be8ad27981274 Mon Sep 17 00:00:00 2001
From: RDaxini <rajivdaxini@msn.com>
Date: Tue, 25 Feb 2025 16:08:07 -0700
Subject: [PATCH 3/4] Update test_mismatch.py

---
 pvlib/tests/spectrum/test_mismatch.py | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/pvlib/tests/spectrum/test_mismatch.py b/pvlib/tests/spectrum/test_mismatch.py
index 5397a81f46..ed2257747f 100644
--- a/pvlib/tests/spectrum/test_mismatch.py
+++ b/pvlib/tests/spectrum/test_mismatch.py
@@ -202,8 +202,8 @@ def test_spectral_factor_caballero_supplied_ambiguous():
 
 @pytest.mark.parametrize("module_type,expected", [
     ('asi', np.array([1.15534029, 1.1123772, 1.08286684, 1.01915462])),
-    ('fs-2', np.array([1.0694323, 1.04948777, 1.03556288, 0.9881471])),
-    ('fs-4', np.array([1.05234725, 1.037771, 1.0275516, 0.98820533])),
+    ('fs4-2', np.array([1.0694323, 1.04948777, 1.03556288, 0.9881471])),
+    ('fs4-1', np.array([1.05234725, 1.037771, 1.0275516, 0.98820533])),
     ('multisi', np.array([1.03310403, 1.02391703, 1.01744833, 0.97947605])),
     ('monosi', np.array([1.03225083, 1.02335353, 1.01708734, 0.97950110])),
     ('cigs', np.array([1.01475834, 1.01143927, 1.00909094, 0.97852966])),
@@ -218,8 +218,8 @@ def test_spectral_factor_pvspec(module_type, expected):
 
 @pytest.mark.parametrize("module_type,expected", [
     ('asi', pd.Series([1.15534029, 1.1123772, 1.08286684, 1.01915462])),
-    ('fs-2', pd.Series([1.0694323, 1.04948777, 1.03556288, 0.9881471])),
-    ('fs-4', pd.Series([1.05234725, 1.037771, 1.0275516, 0.98820533])),
+    ('fs4-2', pd.Series([1.0694323, 1.04948777, 1.03556288, 0.9881471])),
+    ('fs4-1', pd.Series([1.05234725, 1.037771, 1.0275516, 0.98820533])),
     ('multisi', pd.Series([1.03310403, 1.02391703, 1.01744833, 0.97947605])),
     ('monosi', pd.Series([1.03225083, 1.02335353, 1.01708734, 0.97950110])),
     ('cigs', pd.Series([1.01475834, 1.01143927, 1.00909094, 0.97852966])),

From e0bce5ad9096010d741124b355f56ad7b773636a Mon Sep 17 00:00:00 2001
From: RDaxini <rajivdaxini@msn.com>
Date: Wed, 26 Feb 2025 11:47:46 -0700
Subject: [PATCH 4/4] add "series" to module description

---
 pvlib/spectrum/mismatch.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/pvlib/spectrum/mismatch.py b/pvlib/spectrum/mismatch.py
index 239faeb735..980f0d0165 100644
--- a/pvlib/spectrum/mismatch.py
+++ b/pvlib/spectrum/mismatch.py
@@ -520,7 +520,7 @@ def spectral_factor_pvspec(airmass_absolute, clearsky_index,
         One of the following PV technology strings from [1]_:
 
         * ``'fs4-1'`` - First Solar series 4-1 and earlier CdTe module.
-        * ``'fs4-2'`` - First Solar 4-2 and later CdTe module.
+        * ``'fs4-2'`` - First Solar series 4-2 and later CdTe module.
         * ``'monosi'`` - anonymous monocrystalline Si module.
         * ``'multisi'`` - anonymous multicrystalline Si module.
         * ``'cigs'`` - anonymous copper indium gallium selenide module.